From nobody Wed Nov 04 13:25:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKR5049Lpz6ymHV for ; Wed, 04 Nov 2026 13:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKR501T6nz3Lf8 for ; Wed, 04 Nov 2026 13:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793798708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oantFiu0lgRueb8WR4GShrIsDrsKKTkDQ6i6qb9CPJM=; b=xD8JwuCoFuRsIMpYPuDLpxxYlBkhUY4klbTPlGvde2lIvFnVX7axqbWn3j8VKgnEu/NV87 JF7nUDeYqY9kdCVvsD+25e6sfh9HoMKuqj6PUKI4IEoDV5GsFKdWdzhBZRuDZGtbuHmTUR T8ZL3CQoZJwOLkaAnCo6xLYMozBNGv2u2HY8RbqakRKWqZ0dNdUNNIP1XB34VQS8QvFhmF NygAe/uNg7XQbJAaBQK64fULeDN1OpMExcMjN2SBXgi65Oh4m5cmC8HhLW+rsQhOtcGbhg 2DsqtZXONT8O5mdWQmRblTcgCowrwRCW/pOpYtqRakj04rKceGm977XlMnbsOw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793798708; b=wrffx3IhuVxMCSHHukFBHNHWehmRRgnzNMpvOhaU84iCzVgNnjIaCmPd7L0RbWesT81klT DJhIvMcuD134xhRMdfDNJjW5rboQyRuaVjwWfIwPrUiXT762Dw++iThFASCTuEPUWZpGen kvDtf7mVx7zJ7YkDQXM0AZLyQ2KGKyNO1h0yIGrih51zQgjp0ZROLtsu3fC/sNBW0PqDSY reaE+s6FKFCfTMNJs8NjqqwxNfvf/xL84wndrX+fjb3tsYcTFpjOQk5OvU2PoX+WpJ4nJT +NnpO4uQxjiomr1wnvBYoeWZRcnnquWNFGEdIZTkKHHpIf7CXSdzcnw+tk/jvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793798708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oantFiu0lgRueb8WR4GShrIsDrsKKTkDQ6i6qb9CPJM=; b=TLap/w/s8BrqFcHTdWaMzBCBgPUcIXM5dJEXhmQx+ZNfVbrdqC9vZL+h7hyz26x7rCy95H rvyLzPFKXEb0fCu82rurfr6+cDpGpZdA4TMt8K9RbxHlPFfDOBXVNHVIDFBbdRoPR1Ewsi 2bIcuLWqhqHmKOPbJRfyHV7sHDt45NCBUVPeDGxNO/nVRddoshCzQuiaVpQ31hQ4RcMO// uwNH9Kj6RMD9jRYybGciig8+Xw9QkjL6SNEZgfcTWKIbPnZhqbKKnmSsrAUMu7eiSXVwka mmwscW9/oHlhCc8TBnB7P0KyqYc9I8dLj2rExU06LnZMLTpLdGZLgBBaprXcSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKR500QDlz14L1 for ; Wed, 04 Nov 2026 13:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c6a8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 13:25:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: b8cadc76350d - stable/15 - systm.h: Remove unused List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b8cadc76350d57317abb50508323ea0d32b70dd8 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 13:25:08 +0000 Message-Id: <6aeb3234.3c6a8.1ffca90@gitrepo.freebsd.org> The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=b8cadc76350d57317abb50508323ea0d32b70dd8 commit b8cadc76350d57317abb50508323ea0d32b70dd8 Author: Olivier Certner AuthorDate: 2026-10-06 09:36:09 +0000 Commit: Olivier Certner CommitDate: 2026-11-04 13:21:34 +0000 systm.h: Remove unused It only contains sched_pin_lite() and sched_unpin_lite(), which have been unused in-tree for the past 8 years, and were only briefly used between 6573d7580b85 ("epoch(9): allow preemptible epochs to compose") and a760c50c9ea7 ("With epoch not inlined, there is no point in using _lite KPI. (...)"). Additionally, these functions are redundant with the existing sched_pin() and sched_unpin() in , which are already themselves inline functions. The only difference is that the sched_*_lite() ones do not require the full definition of 'struct thread', which may have been useful to circumvent namespace pollution. That problem, if it materializes again, could be quickly circumvented without this trickery by the use of non-inline functions, or using inline functions referencing a variable filled at kernel startup with the desired offset. The trickery of using offsets computed at compile-time appears necessary only in the case of extremely performance sensitive functions. Cleaning up namespace pollution should stay the preferred way forward whenever possible. Reviewed by: glebius, imp MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60404 (cherry picked from commit e478037df4f12e3d1b6b551f05ea7ce23c096886) --- sys/sys/kpilite.h | 52 ---------------------------------------------------- sys/sys/systm.h | 2 +- 2 files changed, 1 insertion(+), 53 deletions(-) diff --git a/sys/sys/kpilite.h b/sys/sys/kpilite.h deleted file mode 100644 index b48b062bd7ea..000000000000 --- a/sys/sys/kpilite.h +++ /dev/null @@ -1,52 +0,0 @@ -/*- - * SPDX-License-Identifier: BSD-2-Clause - * - * Copyright (c) 2018, Matthew Macy - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - */ - -#ifndef _SYS_KPILITE_H_ -#define _SYS_KPILITE_H_ -#if !defined(GENOFFSET) && (!defined(KLD_MODULE) || defined(KLD_TIED)) && defined(_KERNEL) -#include "offset.inc" - -static __inline void -sched_pin_lite(struct thread_lite *td) -{ - - KASSERT((struct thread *)td == curthread, ("sched_pin called on non curthread")); - td->td_pinned++; - atomic_interrupt_fence(); -} - -static __inline void -sched_unpin_lite(struct thread_lite *td) -{ - - KASSERT((struct thread *)td == curthread, ("sched_unpin called on non curthread")); - KASSERT(td->td_pinned > 0, ("sched_unpin called on non pinned thread")); - atomic_interrupt_fence(); - td->td_pinned--; -} -#endif -#endif diff --git a/sys/sys/systm.h b/sys/sys/systm.h index 13103325595e..8056bf94c7b2 100644 --- a/sys/sys/systm.h +++ b/sys/sys/systm.h @@ -97,7 +97,6 @@ struct ucred; #ifdef _KERNEL #include /* MAXCPU */ #include /* curthread */ -#include #include extern bool scheduler_stopped; @@ -179,6 +178,7 @@ int linux_alloc_current_noop(struct thread *, int); #define critical_enter() critical_enter_KBI() #define critical_exit() critical_exit_KBI() #else +#include "offset.inc" static __inline void critical_enter(void) {