git: 7817357c2601 - stable/15 - cred: freebsd14_setgroups(): Remove a now-unnecessary local variable
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 04 Nov 2026 13:25:03 UTC
The branch stable/15 has been updated by olce:
URL: https://cgit.FreeBSD.org/src/commit/?id=7817357c2601969c06d4ceb8dd292fcb051a2f80
commit 7817357c2601969c06d4ceb8dd292fcb051a2f80
Author: Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2026-09-30 09:10:44 +0000
Commit: Olivier Certner <olce@FreeBSD.org>
CommitDate: 2026-11-04 13:21:30 +0000
cred: freebsd14_setgroups(): Remove a now-unnecessary local variable
MFC with: e6fbef451dd4 ("cred: Fix a race in the FreeBSD-14-compatible setgroups(2)")
Sponsored by: The FreeBSD Foundation
(cherry picked from commit e40d60838c9a0ebe5e5fb0e3cb00e7b08dd8c959)
---
sys/kern/kern_prot.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c
index bfb95508b64e..005131b1561f 100644
--- a/sys/kern/kern_prot.c
+++ b/sys/kern/kern_prot.c
@@ -1231,11 +1231,8 @@ freebsd14_setgroups(struct thread *td, struct freebsd14_setgroups_args *uap)
groups = smallgroups;
error = copyin(uap->gidset, groups, gidsetsize * sizeof(gid_t));
- if (error == 0) {
- int ngroups = gidsetsize;
-
- error = kern_setgroups(td, &ngroups, groups, true);
- }
+ if (error == 0)
+ error = kern_setgroups(td, &gidsetsize, groups, true);
if (groups != smallgroups)
free(groups, M_TEMP);