From nobody Tue Nov 03 03:04:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJYM70HwSz6xhy6 for ; Tue, 03 Nov 2026 03:04:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJYM66sg1z4T4Z for ; Tue, 03 Nov 2026 03:04:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793675059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dpo4uUS4FZSX/oUPT1Y/quByyvF3irHsclZqYB/fyic=; b=dxTT/9y/Z68HBwMP2eTKm3PLXPRZb+foV6gyRiZb4TBe02TCF20rKk+ondFH12/nShg+Qa q4GkTXefPYNjKN46Qe4OFviHuhbgGuyJeJCsmGp2sI6MTTb87ayWJu3aUpqUtoIs/F9TOJ okD4YCgjws5/Y8FkKGyi3n6tB3++4NcmsQjbOcNl92Z6VveOkRO+Wb9ucO7J5NeyEbAxNd TGepOTkeoqRwTHlc2tNBJ3z/TKDeSVtkrsG0qn1LgUPobPLdGsVXK3fZduloXcJb5zJqIv v4cBlnTgtwwI41oLNyxJ3815jPLEwWemJlNXa2/7G5Q7w5HpDU6mybZDV6nauw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793675059; b=QqzgO2yDyLxMoTLrIWC7lPdVFgP40cfNl85wVSusR6vw7K2VmV0J/3f/j90e4UX/pqvBP4 nTHqwbRdrIYPM9BOCk1p93UwcE8ZggWTi3yNb+6I0tFfJetBlzAK9GZTqIXxwLaAYhVqVN 7crjESZS62YJ7MJj5cVBFTb3t86xvkVBAjGTI0Vrp0VSPSmjqOINqn8JFyX58/w+dHIecZ 65zG5BJG+qAk8gNMFSWYkE4JJ1+ntREnhImvH/rrpAwIcoERMfgE6vSnUBWA6OtPZs3ruc fgPQLgDL8M/LKJb9db1w5GEoDY1krSb3ba8aHjrK1MbYDrcWsm8UTTs3WKLE4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793675059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dpo4uUS4FZSX/oUPT1Y/quByyvF3irHsclZqYB/fyic=; b=uR6PNT+qt+vLq191obtt5uElbgwFQND90YCFG7I2TQdkPr4f/nbI2cTsTAeLPYIF06GLhi ITLYt48XJxk9OmDkV2fxdk2GYQfuf848RBIiNe5+ykpFr+ZvYb8s7IoQl3ymKVn3JVx3Jr 1N0IKb3RdISLBz1RxLZ/56Zy7wI5EigvXvWnrJfkimJmoAWRDCnVXUYdEscqHUupeCP6I1 IyD/ZL6KdlsK5LG96Kqv82LTf1NdN/Sa85ceywpNwA10VPpDSc1z8cACNO9gTkjUy1vc/C h1TGS0LlRpsSV8ELizi1IwvDUh8kOgiEnWFSJ7WuKuI7tTy1qsmuDUoqmxOTwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJYM66ShQz1CmP for ; Tue, 03 Nov 2026 03:04:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e55a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Nov 2026 03:04:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Xin LI Subject: git: fbac0abdc5ab - main - mqueuefs: set *a_eofflag in VOP_READDIR List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fbac0abdc5ab1fe867ac85635662ef06b2ee9d10 Auto-Submitted: auto-generated Date: Tue, 03 Nov 2026 03:04:13 +0000 Message-Id: <6ae94f2d.3e55a.618ae182@gitrepo.freebsd.org> The branch main has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=fbac0abdc5ab1fe867ac85635662ef06b2ee9d10 commit fbac0abdc5ab1fe867ac85635662ef06b2ee9d10 Author: Xin LI AuthorDate: 2026-11-03 03:02:03 +0000 Commit: Xin LI CommitDate: 2026-11-03 03:02:03 +0000 mqueuefs: set *a_eofflag in VOP_READDIR mqfs_readdir() never reported end of directory. Since 77b273d8f5f4 VOP_READDIR_APV() asserts that a readdir which returns no entries also sets *a_eofflag, so with INVARIANTS the final zero-length getdirentries(2) that ls(1) issues on a mounted mqueuefs panics: panic: VOP_READDIR: eofflag not set Report end of directory when the child list was walked to its end; leave the flag clear when the walk stopped because the buffer was full. MFC after: 1 week --- sys/kern/uipc_mqueue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/uipc_mqueue.c b/sys/kern/uipc_mqueue.c index 68eda5ecb039..cd402fa3e80b 100644 --- a/sys/kern/uipc_mqueue.c +++ b/sys/kern/uipc_mqueue.c @@ -1459,6 +1459,8 @@ mqfs_readdir(struct vop_readdir_args *ap) sx_xunlock(&mi->mi_lock); uio->uio_offset = offset; + if (ap->a_eofflag != NULL) + *ap->a_eofflag = (pn == NULL); if (tmp_ncookies != NULL) ap->a_ncookies = tmp_ncookies;