From nobody Mon Nov 02 18:42:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJLCz5WPGz6yC2c for ; Mon, 02 Nov 2026 18:42:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJLCz4l8Cz4MV5 for ; Mon, 02 Nov 2026 18:42:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793644943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J5CdG5pwNwtAiQR+I8aE9oP8LCVonMlCiqZ3QjVZ4qo=; b=AHf+W2VcP79/g0AjjUYdzl79ehGIz+iUIQDMkCofgeu8aPbwgEQlwiqyZdYn4uwSMdd3Jb dtFvOsGNGJ6Uw+xORbVIiqVLAtFOyR3ONvCadHFVuLAYZVWJQr3+pSs8BlSlk1qUTVl1Ca J7WRQ9XCvK3R1NDU0NVZeUs3ttmFsheV4Z6nWh/pwyzd6pRweKftzk87dC4KjA8xOzbXvE COTwKcuEIKOFYa9INftTUQBaf8JWhu3TP2QuIla/aPTn76jpG2jLoNqkvRme5NlXgZjOkx 8/2erwnHyn099p8VC3OKam7J/9NVFwLbFhFa1QxQSPpt2uOnQDfNKb1p8kpaYA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793644943; b=GAFvW7MEfKRqU557b9U44NhTga9LAtvjUNoiekKlrvTo/r1NgBb1MZOWJVFusUsAKDpnEW CwuacUsSb4rAKO/xMbneM8yNnUQesT5DLwCtqJAm3KNQBm8Vk7ZnCV4HVqhxLaSJWLy3Jg t88LSAtjSTyCzZRTkSQO6QpmnJEefQ0gMY9rMHVOkjLYkCGVmf1bTUETQgWns5uStVYip0 afl1aOG75jzOTUQYUz98/PlWA+V9JZI5X9YUA2WgWtqUQMqQINiyeZ3xABYah4vpNlUaKW u85wXmdGQIGKa1hWNm2A3kOyHCyqcF2FM4Emqhk+CeJRFPHJOaLkqrn8Epf8lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793644943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J5CdG5pwNwtAiQR+I8aE9oP8LCVonMlCiqZ3QjVZ4qo=; b=PoeR0ZtArwHk242UPFwCKYnk4c2As2+gcCeh/eaIQVeJM2QUB4x1/imjEkhWxNK8FUJN8l 8DWv5JfVyXJA1nDZJENOJiKtXlta75YedyNkCS79h87HxCCU0aCHPHzCUeY3eVdom49jT2 d50gKjKN74Oo53vFbCKHhmh2w7abfDCls24cl5JCZ/tsR+ifdXUFXMeCOqWGoSdJxg6r++ lPHkLcYhNJTsP53IREff4k4YdZBneS6McaGPPYmMB3j/B+RjLp9M0fcvFoDI6FnVyWLvmS gkQki7iBldSEVcUAY/vpOeMMixSlQhfB2mHmDwkZpX3jasBhGnTJzeVC8y+Dtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJLCz4P8jzyFT for ; Mon, 02 Nov 2026 18:42:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30403 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 18:42:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Arthur Kiyanovski From: Arthur Kiyanovski Subject: git: ccceb1729a6b - main - Revert "ena: Reinit RSS components during queue count change flow" List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ccceb1729a6bd82b8b293bc5ea61b863179a268e Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 18:42:23 +0000 Message-Id: <6ae8d98f.30403.c5a6117@gitrepo.freebsd.org> The branch main has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=ccceb1729a6bd82b8b293bc5ea61b863179a268e commit ccceb1729a6bd82b8b293bc5ea61b863179a268e Author: Arthur Kiyanovski AuthorDate: 2026-10-30 01:38:44 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-11-02 18:31:51 +0000 Revert "ena: Reinit RSS components during queue count change flow" This reverts commit 2a27dd0076c5. Changing the IO queue count destroys the RSS table, and if this is done while the device is down a new table is not rebuilt until the next ena_up(). That leaves 2 problems in the meantime: 1. A stale copy of the destroyed table is still returned via sysctl. 2. Reading the destroyed key, or writing the table, panics. That commit addressed 1 by creating a new RSS table, so that sysctl returns a fresh default table with the new number of queues. It did not set out to fix 2, but the rebuild hid it by accident. The rebuilt table is the default round-robin one, wired to no queues and unusable: a write still fails, because programming the device needs the IO queues that only exist after ena_up(). ena_up() builds that same table anyway. Rebuilding also programs the device while no IO queues exist. When the queue count grows this fails with EINVAL; when it shrinks it succeeds and points the device at completion queues that ena_down() destroyed. The following commit addresses both issues properly. Reviewed by: cperciva MFC after: 3 days Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D61056 --- sys/dev/ena/ena.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 63743cbc9db2..74594fdb1496 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1437,11 +1437,6 @@ ena_update_io_queue_nb(struct ena_adapter *adapter, uint32_t new_num) ENA_REGS_RESET_OS_TRIGGER); } } - } else { - /* Reconfigure RSS to reflect the new queue count. - * When dev_was_up, this happens through ena_up(). - */ - rc = ena_rss_configure(adapter); } return (rc);