From nobody Mon Nov 02 15:58:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJGb81qn0z6xtkH for ; Mon, 02 Nov 2026 15:58:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJGb76XQyz4fCq for ; Mon, 02 Nov 2026 15:58:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793635123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n6xNrV9bSCrEU/C3OcwWvK+x6AaI03DR8zxRcM3aOwM=; b=eDFq9dNsBYrXUH36l+mXhnnqP9yWSI0YEbGyiCck3ReEwfi12wf1Eqaj+OiCG61xd7YCFo dYmNGXGWRbRYS81yxFfUGc+4XRx/jTrUttod+jQ00ZZsnNrb35EbSDtjlC3QyTdjDC4c/5 mWtlhYIth1cmjiQLBtETAWo6ovF9IvZ2CGtDcTPKCuoQsec3PIC9CvJKkr2c7NCX8pDLoN zofPHKDfWled9JRBmBGbt6Y7MD/iOX5d3z7Zq759ICXPfug9acQzYdZCuCVgCg3mZKuRs6 L49L4A0lf+vMDIaXYpqudPx9BOteO0VfdI80poJN/vz37cJ5IyZyHhFma9ifjA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793635123; b=v4n9sLPM9pVtbBH5RJfhpd62qnpffGnifQBPmXC+XvonWrzOyIESfqp8V/BdfwIcat+OTZ TFmwm4s6Y9IXzk/kAllwfGYilbD3Aj6tQXq5TQCS9F8LRkFyZ+l1LGedCUdkTv3lG2SKN4 cf6V5+DSGqjv7tI8J7d3QZ87bCeAPqHgsus5GsVhNgOZKr4dH6y9TAkGTRhtdKY/yN4HMU iB++rzFCvrhrvP9g0WXWS2NH5tP9pMKj/VxgzMv8YiwqhCfTEPIDtD6V7zE2N7CF6vB7d2 sAIQI/FdQ27OSKlcQROhJ9T46ZaW6PY3eoUSVnHBdd5oKOMua11JVal4t7hZNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793635123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n6xNrV9bSCrEU/C3OcwWvK+x6AaI03DR8zxRcM3aOwM=; b=nm/LM+5fkYIMOlk045sFEWJ1iEry/0cnGnEJTtpubS3Kw0W3GbD3R2kXyYER1Yh18Wz/b4 Jh5LPfVdPp1CN3GVajxLxtTPG2bPX8Azz8MudhTGNmmMb8gd2iKTI2DC5oUdm1HPsI/d33 LmDdsUEwluy3fVkzQAi3mQwO7uM1zOGGaItekVGC/uHyMcceQRTE4vGOnOTopJdVhSYrMS 31qDkYPBKuvlhQDXv1d9sQssEFosI34jxs6lJWAoeV17EGSPsDdpFW2TO+VWirQaq/pQw2 2sUvNUageU2oGJCMTT8xp//jNgKO8mR/uMIUWAQtln1E9ysFHIXPx1cVOqd6AQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJGb76CLbzsjb for ; Mon, 02 Nov 2026 15:58:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4435c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 15:58:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 0b420c655f81 - main - lacp: fix lacp for interfaces with unknown media List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b420c655f816a31165c457b9462183b25eaecf2 Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 15:58:38 +0000 Message-Id: <6ae8b32e.4435c.3b3443d3@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=0b420c655f816a31165c457b9462183b25eaecf2 commit 0b420c655f816a31165c457b9462183b25eaecf2 Author: Andrew Gallatin AuthorDate: 2026-11-02 15:53:34 +0000 Commit: Andrew Gallatin CommitDate: 2026-11-02 15:58:28 +0000 lacp: fix lacp for interfaces with unknown media Fall back to if_baudrate if ifmedia_baudrate() returns 0 in lacp_aggregator_bandwidth(). When lacp_aggregator_bandwidth() returns 0, lacp will never come up, due to aggregator selection starting with a 0. This is why its important for interfaces with unknown media (meaning ifmedia_baudrate() returns 0) to fall back to using if_baudrate in order to avoid this state. Differential Revision: https://reviews.freebsd.org/D61084 Reviewed by: kbowling Sponsored by: Netflix --- sys/net/ieee8023ad_lacp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/ieee8023ad_lacp.c b/sys/net/ieee8023ad_lacp.c index 7861dfe455ca..92f45a3c74c4 100644 --- a/sys/net/ieee8023ad_lacp.c +++ b/sys/net/ieee8023ad_lacp.c @@ -960,6 +960,8 @@ lacp_aggregator_bandwidth(struct lacp_aggregator *la) } speed = ifmedia_baudrate(lp->lp_media); + if (speed == 0) + speed = lp->lp_ifp->if_baudrate; speed *= la->la_nports; if (speed == 0) { LACP_DPRINTF((lp, "speed 0? media=0x%x nports=%d\n",