From nobody Mon Nov 02 15:26:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJFsg26hsz6xppy for ; Mon, 02 Nov 2026 15:26:15 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2001:41d0:700:4a43:a25:de0:0:13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJFsf2H6rz4Z8Z; Mon, 02 Nov 2026 15:26:13 +0000 (UTC) (envelope-from freebsd@omnilan.de) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2001:41d0:700:4a43:a25:de0:0:13 as permitted sender) smtp.mailfrom=freebsd@omnilan.de Received: from mh0.gentlemail.de (mh0.gentlemail.de [135.125.173.218]) by mx0.gentlemail.de (8.18.1/8.18.1) with ESMTP id 6A2FQ9br036926; Mon, 2 Nov 2026 15:26:09 GMT (envelope-from freebsd@omnilan.de) Received: from [172.21.35.3] (s1.omnilan.de [217.91.127.234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 2DFFE1AE71; Mon, 02 Nov 2026 15:26:09 +0000 (UTC) Message-ID: Date: Mon, 2 Nov 2026 16:26:08 +0100 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: bb50bb45f5f6 - main - vtnet: move offload functions to virtio_net.h To: Pouria Mousavizadeh Tehrani , Faraz Vahedi Cc: "dev-commits-src-all@freebsd.org" , =?UTF-8?Q?Timo_V=C3=B6lker?= , Michael Tuexen References: <6a903124.1e7f7.2909a17b@gitrepo.freebsd.org> <85481F33-C074-431B-A7BC-75542A6301A0@FreeBSD.org> <06fc3500-3e6e-4f3b-b346-94ae3e13855a@FreeBSD.org> Content-Language: en-US, de-DE From: Harry Schmalzbauer Organization: OmniLAN In-Reply-To: <06fc3500-3e6e-4f3b-b346-94ae3e13855a@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4jJFsf2H6rz4Z8Z X-Spamd-Bar: / X-Spamd-Result: default: False [-0.30 / 15.00]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR]; MIME_TRACE(0.00)[0:+]; HAS_ORG_HEADER(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DNSWL_BLOCKED(0.00)[217.91.127.234:received]; DMARC_NA(0.00)[omnilan.de]; RCPT_COUNT_FIVE(0.00)[5] On 2026-11-02 15:57, Pouria Mousavizadeh Tehrani wrote: > Add Faraz (kfv@) to the loop. > > On 11/1/26 23:55, Michael Tuexen wrote: >>> On 1. Nov 2026, at 13:35, Harry Schmalzbauer wrote: >>> >>> On 2026-08-27 14:44, Michael Tuexen wrote: >>>> The branch main has been updated by tuexen: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/? >>>> id=bb50bb45f5f650873b202e644bfcd9f2992cdace >>>> >>>> commit bb50bb45f5f650873b202e644bfcd9f2992cdace >>>> Author:     Timo Völker >>>> AuthorDate: 2026-08-27 03:09:55 +0000 >>>> Commit:     Michael Tuexen >>>> CommitDate: 2026-08-27 03:15:17 +0000 >>>> >>>>      vtnet: move offload functions to virtio_net.h >>>>           Move the functions vtnet_rxq_csum() and >>>> vtnet_txq_offload() and the >>>>      subfunctions they call from if_vtnet.c to virtio_net.h. This >>>> allows >>>>      us to call these functions from if_tuntap.c and if_ptnet.c. >>>>      virtio_net.h already contained a copy of these functions, but a >>>> copy >>>>      of an outdated version. The functions evolved in if_vtnet.c. >>>>      In if_vtnet.c, the copy has never been used because it increments >>>>      counters in their own functions. >>>>      This patch removes the outdated copy from virtio_net.h and >>>> moves the >>>>      new version of the functions from if_vtnet.c to virtio_net.h. >>>>      if_tuntap.c, if_ptnet.c, and if_vtnet.c just call these functions, >>>>      and if_vtnet.c increments its counters depending on the return >>>> value. >>>>           Reviewed by:            tuexen >>>>      MFC after:              1 month >>>>      MFC to:                 stable/15 >>>>      Differential Revision:  https://reviews.freebsd.org/D57299 >>> >>> >>> Hello, >>> >>> do you still plan to MFC this? >>> Along with c1fa70c6e9f6 - main - vtnet: offer VIRTIO_NET_F_GUEST_CSUM >>> probably? >> That was originally that plan, but I think trying to do this ended >> up in several merge conflicts. >> >> Do you need these changes? Then I can try harder than I did initially. No, thanks, I'm currently happy with vtnet as is and I can't test in high-load environments currently. I just wanted to send a reminder in case this was lost. And maybe to avoid more diverging code base causing future extensions to be even harder to merge... Best, -harry