From nobody Mon Nov 02 15:02:43 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJFLc5ncGz6xnJb for ; Mon, 02 Nov 2026 15:02:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJFLc37Qgz4SdV for ; Mon, 02 Nov 2026 15:02:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793631768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pviAECbx7iCO88lVAiqs4UM+Dg15I8bFYot9R1yy0k8=; b=AMHYkomeejy2DMHUbYl6F+YqR/6wPIRjUrh3NA1MHLgeIfjKpjKkG6LYLWNdGNOkcAL9T/ XMTWAvHbwSkB/0UbBvlcRAj/pl5XpkNqnBp3Hr3Uq+Ky18B1J6CYlICPyrbblocq3VpH7r wZEHwNFJz/ODJJdMa2LYPQmf18Xr+C9vZ7GU/trTUIFSeddfjQscbhOYv1q7iCUtKils+1 /lZRYQmweYsse8tSqeiHFpsfbZjB2YXkuk+aUlFuzE75gc2yFUTh8mKs+j7pznQkU1zheB d+hNonbCuNQcjpHHmuiYH93whU0KDsIePUqYHnXxxxsClJ5G3AeAiZ3QutBVRQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793631768; b=p2eh24iy+pNEjSY2Tk5iPniQ5duVGy1u8S5mBHcuJjc5VSm53a2YMAND5DQNX6Oxl+MxAp rgYEAgIshERiYXy+kmjOD/00FkfWj+8oPPzEmkThhuzlXh48WqCsx7VJ4jb00QiMdWUVYc 9RuHJnovDH+e2BstY3BiZl9QGuFm8ZcEuL0kQHo/6gFzvyTga89fgaolybB4I7VMaE2a6w FsXMI/84ri5F2B+ApD8mJztvq5S3WSU1Hxf4rIMRy+y4JbT1tgOy1+YE0x864uhheW7JPW qxJC0ZVvP2QMkwuQNd1zqbalv7Luygt66VQgLgDfiLwKb/QtGT786ksvHrqVJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793631768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pviAECbx7iCO88lVAiqs4UM+Dg15I8bFYot9R1yy0k8=; b=bfPbO32G1ikFAd9nvAIy06+oItHZCGu6VHzqS0kMD5PQ8+8zgMEjU3w/Ba2ZlloQ6u4sX9 gGDTIr0EFnjfw4i6E3dUFMHc3a5Bmnvd9ELXg0t/Z7T59fKDgdosURb16/7l+GGOg3QJSg OeCiCD/eLXSYqufStiMki70QPfN/rxUtrExmXjo8zaHEcqw5AyYvs6uwZOa/8BAhJ67rBl Bj3Hjk2pzT39QRC7B6OMhNJXi7/d2tMnLSNR6MiU5P3V/hGWttwb3ty0vn0z6HXJZ3/x1i h7rO4zjDkHWZMkeSCIQWbRZ5C0/Jxc3wBbl71cIiO1BJ5ndRuqthSNqys0pcAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJFLc2mr8zr8j for ; Mon, 02 Nov 2026 15:02:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f5bb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 15:02:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: bc7366a340ed - main - nfs_nfsdstate.c: Partial revert of 64857418bb23 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bc7366a340edb366c37352c636b8360de92aa3a2 Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 15:02:43 +0000 Message-Id: <6ae8a613.3f5bb.7526310e@gitrepo.freebsd.org> The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=bc7366a340edb366c37352c636b8360de92aa3a2 commit bc7366a340edb366c37352c636b8360de92aa3a2 Author: Rick Macklem AuthorDate: 2026-11-02 15:00:40 +0000 Commit: Rick Macklem CommitDate: 2026-11-02 15:00:40 +0000 nfs_nfsdstate.c: Partial revert of 64857418bb23 Dropping the cached reply that is too large causes a correctness problem that is too difficult to fix, so revert this and leave it the way it was. Although there is an argument that not doing could cause resource exhaustion, it has not been reported in the field as a problem. MFC after: 1 month --- sys/fs/nfsserver/nfs_nfsdstate.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdstate.c b/sys/fs/nfsserver/nfs_nfsdstate.c index de0c729acfa6..2fdce567c1ce 100644 --- a/sys/fs/nfsserver/nfs_nfsdstate.c +++ b/sys/fs/nfsserver/nfs_nfsdstate.c @@ -6222,10 +6222,6 @@ nfsrv_cache_session(struct nfsrv_descript *nd, struct mbuf **m) m_freem(*m); return; } - if (*m != NULL && m_length(*m, NULL) > sep->sess_maxrespcached) { - m_freem(*m); - *m = NULL; - } nfsv4_seqsess_cacherep(nd->nd_slotid, sep->sess_slots, nd->nd_repstat, m); NFSUNLOCKSESSION(shp);