From nobody Mon Nov 02 13:25:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJC9w4BQfz6yLJS for ; Mon, 02 Nov 2026 13:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJC9w1jmyz3NWP for ; Mon, 02 Nov 2026 13:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793625908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CsPAe5wLxR9bkFSmE0cLpP2f9VdHch+J6mkFIIWj/QM=; b=nI4HYjT63t5lXOWrPbJBugSeSZA3d1T02jvgBzzuLhRUFPOXno6nIqREYWOG10ae39X46o FAydWAkqF6igvBSpgm8xn5TM77keXy9mbtjGdQYIcd8e3sbhdGYIVQfqIlEL0xbjSu5PWB /vjA6DtSvcnt4fyTp3UqDzSte+1gqXNV7vSIZUHCJJ2hZNIubWD8mPDDmDUl3YcDkg1YZE ypXLh8xgSzyWJN0YngQfsUKRdXlEUOgk15hiRYhnGsrRq2BIJEQO5XkN012+chVsSPGPYp 0xICerPWzh+ktn7uqx7u1J/dSZF2rvEgKirx5uZPzukmyqqgL267QSKRxlmq2w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793625908; b=Ydt4xq+FpYgXb4YymGF6Cw93mZOf9bAUDi6xDWT+xiz7XU4JsEwOYbHgKwVMJjazOm+rvZ bNHOtekFEPXrVco6o9OBBQkk6MDOSoWVJlzy93PAmRpRsCe47HZb+u7H7f7OWslXYuF1qt 3fLh0B0dZV0VtNDqOU6GxL4CudTNqWWNaXqckTw/yu0je+t6pqh7HUxKe2dPWIicfuaoKx li1wcOmlZ9oxnJup0V5ZSe7OjfzMFJRFeqsK2e/blqiEKZzuJl41RjjK6TtFgNW9B/55ji +wVPjYFQ8d67DSMaeSpvBNKEl1fJP9nI6P3AM4Qs4S/1C2ThL96/YRYwzVQnZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793625908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CsPAe5wLxR9bkFSmE0cLpP2f9VdHch+J6mkFIIWj/QM=; b=ypm12FmoDkf56hhSOzngwNDH0bVqNfhSQN2DtQD6G0oK8Q04X/C44rTzMOpoXgWWyNWvaV RliEfT3w4I0PyhR/Bv5Nu8RRGy3MVm+EpSb0agno72Vz0RqgodMlsApRoM2Xt3sUn8Z3f3 STwPBD2HLYZGj9p8mvUVgxfOoIriZaqCfGd8Sfj7rvN+xxZ6PTTR7xWqoFdQVoXfw0n3Hm 5eGmwW+zqtHHGZ0vcxFCdOe0lmXbJtfqqwjVIPyGrKjLp3uZqZtWmEvoJwgtG/fGGq6qXP ZBbKpt/31cjYsas1Gbea+14VTbf7xao3b5+gNnUiSs8UD/IJjUHf19sO72Vs5Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJC9w0cl9zp2n for ; Mon, 02 Nov 2026 13:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36517 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 13:25:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 240a76704b49 - main - if_pfsync: fix mbuf leaks on errors List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 240a76704b49b6c67104c5027ddf4d4cf18abfe5 Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 13:25:08 +0000 Message-Id: <6ae88f34.36517.32b11a61@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=240a76704b49b6c67104c5027ddf4d4cf18abfe5 commit 240a76704b49b6c67104c5027ddf4d4cf18abfe5 Author: Kristof Provost AuthorDate: 2026-11-02 10:09:13 +0000 Commit: Kristof Provost CommitDate: 2026-11-02 12:40:01 +0000 if_pfsync: fix mbuf leaks on errors Some of the pfsync input handlers freed the mbuf on errors, others did not. Unify this by having the caller free the mbuf on error. Fixes: c6a520af95b2 (pfsync: improve handling of large packets, 2026-10-30) Reported by: markj's Post-Commit LLM Review Service Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/if_pfsync.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 783d1280d5fb..23916241eb4c 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -1029,6 +1029,7 @@ pfsync_input(struct mbuf **mp, int *offp __unused, int proto __unused) rv = (*pfsync_acts[subh.action])(m, offset, count, flags, subh.action); if (rv == -1) { PF_RULES_RUNLOCK(); + m_freem(m); return (IPPROTO_DONE); } @@ -1716,7 +1717,6 @@ pfsync_in_eof(struct mbuf *m, int offset, int count, int flags, int action) V_pfsyncstats.pfsyncs_badlen++; /* we're done. free and let the caller return */ - m_freem(m); return (-1); } @@ -1725,7 +1725,6 @@ pfsync_in_error(struct mbuf *m, int offset, int count, int flags, int action) { V_pfsyncstats.pfsyncs_badact++; - m_freem(m); return (-1); } @@ -1733,7 +1732,6 @@ static int pfsyncoutput(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst, struct route *rt) { - m_freem(m); return (0); }