From nobody Mon Nov 02 04:24:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHz9x4BMTz6ydLF for ; Mon, 02 Nov 2026 04:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHz9x3HrFz4gt9 for ; Mon, 02 Nov 2026 04:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793593461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0+xm3Ww05pUZAJEiIU1xtvE/9cU2HM1+cA04pFS9hFA=; b=VBPOkBMC32aRrbXff9XBH5/zIg2BVc+KSUwINNwXAos1IiOjXdp419tT6q47VbqhStfv6j +Sm2DE1H3k9Nd2PwPrTtO15XJq3sowguruzxGhIEWu6pMeQBQN1VRVqx3fY5DjhKUJJrMl DgCA2cwwvW+pGGF5uiW6XymydCscVrRyiFQJuaTkCpPquJrFjXqh0QSbQeCtQT3tm7qhsu 22PVZ3bgSMpnNQ4k2Oc11Q7eyG0By9WLf7KpJjWyvb05zLhbAC1rngd9j7TS5UKLaWX3GE 5kAgOfoQhEgMS/wKLr40L08V4RKKhEA7MYWfLF6e7CQcD3gbGsplKvJQLd+rwg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793593461; b=C58Tmxzj3fJ5SSaZXCbUUKQ1SPBddOc7WYhqSnNqtylcITMZGr3nzle8AeQQKJwzVp/lfs DiPa+MR6hPJWXI9PDpotS9ixBYGIbzXsaOLOXv70z87frGLRFPr1ab2uAVh0jA9CrYxCfZ XU5xdHS/xuEgilCPesihMszH+QlNuR6x3JMXEfq9g2NhpKqncKfeZYEMUAfbE4LsSOaugm M42e4VCQh91TSm5CEh9dFkKf9P49ugHB7c5TYFINt5bLKoei4RpIJ9WO4Z5Ik1e+wlqqPW xw4Mpon3QLWE3L7yY+dbEtlUafsDA50LK1JRajOlnw5listoDFr9gYUYOXUrcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793593461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0+xm3Ww05pUZAJEiIU1xtvE/9cU2HM1+cA04pFS9hFA=; b=M1RfbCWUKVMvqWz/01kNJLpbDEPzwfKI8tVkVnMYD1KHPL2/dY4Qy9l0qCudAUJxDh85GG PGi8tOeU3yMErfzo61E8CHo9ckXtnESiQdbLaFk5SOWAamjtPZETTw/i0V9rWk0HoyBghS vSrj2AMz9Y3v/F0OsqTgmRtJxTVKhikGcmukVnGOSoclL3EY3IFZNGMTe+Z6xjNpn15Iwz LRybIJv5TukBDM/z3YA11NF2KAC+O2IIbkK5nlqpmCAI9AsGyyTsClals2u151yR9WaK7w J7GZy0g5vcr8wXJgvpRbLeB6fE3LIyLQ4Q+tSziwL1LCrTDwoCilwxs+WfM/EQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHz9x2y3BzTfH for ; Mon, 02 Nov 2026 04:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4252b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 04:24:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Enji Cooper Subject: git: 029bb78ebee0 - stable/15 - acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 029bb78ebee0f7305a7c39f7501d8e21dc839ed8 Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 04:24:21 +0000 Message-Id: <6ae81075.4252b.7d2a45f2@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=029bb78ebee0f7305a7c39f7501d8e21dc839ed8 commit 029bb78ebee0f7305a7c39f7501d8e21dc839ed8 Author: Abdelkader Boudih AuthorDate: 2026-05-05 19:49:01 +0000 Commit: Enji Cooper CommitDate: 2026-11-02 04:24:16 +0000 acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown acpi_panasonic_shutdown() calls hkey_sound_mute() without holding the ACPI serial lock. Every other call site holds `ACPI_SERIAL_BEGIN(panasonic)` before calling it, as the locking model is caller-owned. This seems to affect the whole Panasonic Toughtbook lineup btw. Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D56718 (cherry picked from commit 7619d14d08a0036a07dce670f55b9568f8133b38) --- sys/dev/acpi_support/acpi_panasonic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/acpi_support/acpi_panasonic.c b/sys/dev/acpi_support/acpi_panasonic.c index 67d51ea9bc1f..f6e943201b23 100644 --- a/sys/dev/acpi_support/acpi_panasonic.c +++ b/sys/dev/acpi_support/acpi_panasonic.c @@ -228,7 +228,9 @@ acpi_panasonic_shutdown(device_t dev) /* Mute the main audio during reboot to prevent static burst to speaker. */ sc = device_get_softc(dev); mute = 1; + ACPI_SERIAL_BEGIN(panasonic); hkey_sound_mute(sc->handle, HKEY_SET, &mute); + ACPI_SERIAL_END(panasonic); return (0); }