From nobody Mon Nov 02 04:23:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHz9Z5fHxz6yd3h for ; Mon, 02 Nov 2026 04:24:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHz9Z4fPjz4gVB for ; Mon, 02 Nov 2026 04:24:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793593442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r51XXTUi9OE+M8mQvusSraC4nUlM6Ilm6k51QtpSAk0=; b=Hpv50r7AaQkN8/JoEbEyGKbOa3I2oTnqdRHqEzgKya0K2YpWfxvLZ2HMdP+8wk71gYnHih ALmHarHZz+b51bcOXtW1yQfCsxNQeWhTPIo1cbn8KHDld5AnOkLoDc44S0L782nIGRcbCH cq8JKhwQ3hhpKi7tb8c4Inb24JyiK57v2NMl917S+cP1L0RnoCUW2/awLgW1IYWNAw0gvI QYiWh2RneASPTmSDGHsNcumdHfTiKytiEis4enJ4fb48EkxxxAY3vVEGvtg7W3UsuUvE93 Vg0lVy9CabyslAIZDGITwzDbtYz82Krke/ue4PPY17cWYxR9ASdUWwsxAM2lVw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793593442; b=Bb5Qq4ZnQtgEhYN1g6BFagyhVqnaw8TbKJEEELrkyHUVD9mNJruB9daMWh03vaIWBbo/xr 26T4mK8TeZwTqy3I9OPzBHeIABLusnZM+Fi05AfhcDsp3pbD4oM5q4p6iJuV1WPceVqJqJ DmxrbvC6Fi+Jw1HUcxehJ2r6zcmBYDtHCbuZCli4nfUmqA9B64TSx7hyZrO/gOnKN7bbeK vcGKVZT5YXMMLbKd4QEZHpPM/AZyg0m86VXR6vc873NQQdBH1R9LfQenh+MMzB6ehzX60I XgX6lZnu6SyYPmmdaj0er5KxZCi4FKWZCUESh3Z5XK3BS/mmO7qsyDAm7KI+fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793593442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r51XXTUi9OE+M8mQvusSraC4nUlM6Ilm6k51QtpSAk0=; b=JLmzO2J+jA84r3LjGxaQV9Iiz81YMLPrMS2nDRagrIE72Lz7taqI7rQqh4FLwmviW/WcD5 f85SfdLqzmpPKtnRyQ4vGcViDCVV15ujZvhhtYPnLjLMGYmDUIKuRs2cc7inHuqV1vKyXC 9l39VbRT1jZ2o5F5+J1bYBt0JKtxr+Q+OfbezWgh4qvPX5f47JpSEkfYVztJxoepbljTR9 VbuNQAE4rHvzsSoqGVS2wEK70A1X3yG4OgCRBWg7VsPf+j94AQLgIUetU6QlK7I5qptxHI NAzmwX52zPWU6zrjitkKEvPrywsrYdhZmVS2y9qk6ZyOkodkZZl6bTA+qIATDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHz9Z4BFwzSQr for ; Mon, 02 Nov 2026 04:24:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 432e4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 04:23:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Enji Cooper Subject: git: 20f7b539220a - stable/14 - acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 20f7b539220ada24b3c57f312148846bc790b493 Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 04:23:57 +0000 Message-Id: <6ae8105d.432e4.142c6b6c@gitrepo.freebsd.org> The branch stable/14 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=20f7b539220ada24b3c57f312148846bc790b493 commit 20f7b539220ada24b3c57f312148846bc790b493 Author: Abdelkader Boudih AuthorDate: 2026-05-05 19:49:01 +0000 Commit: Enji Cooper CommitDate: 2026-11-02 04:14:56 +0000 acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown acpi_panasonic_shutdown() calls hkey_sound_mute() without holding the ACPI serial lock. Every other call site holds `ACPI_SERIAL_BEGIN(panasonic)` before calling it, as the locking model is caller-owned. This seems to affect the whole Panasonic Toughtbook lineup btw. Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D56718 (cherry picked from commit 7619d14d08a0036a07dce670f55b9568f8133b38) --- sys/dev/acpi_support/acpi_panasonic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/acpi_support/acpi_panasonic.c b/sys/dev/acpi_support/acpi_panasonic.c index 67d51ea9bc1f..f6e943201b23 100644 --- a/sys/dev/acpi_support/acpi_panasonic.c +++ b/sys/dev/acpi_support/acpi_panasonic.c @@ -228,7 +228,9 @@ acpi_panasonic_shutdown(device_t dev) /* Mute the main audio during reboot to prevent static burst to speaker. */ sc = device_get_softc(dev); mute = 1; + ACPI_SERIAL_BEGIN(panasonic); hkey_sound_mute(sc->handle, HKEY_SET, &mute); + ACPI_SERIAL_END(panasonic); return (0); }