From nobody Sun Nov 01 20:25:30 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHmYT1mhqz6xsfL for ; Sun, 01 Nov 2026 20:25:33 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHmYT19bkz4NG2; Sun, 01 Nov 2026 20:25:33 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793564733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OBOalILKPLmphW3gIJ2cIFTgEzL4Q02wP6Vl0gWpa3k=; b=JTDFAGpKZituOBJxogrB9XhGFBqflsyew0ugWs8aHGNtOFI8SdHf5bSjx8eswPRC3JleQR uTnPTdBlxFf/AxSoMSxt71r3oojYAon3FluSjEQGFGamuakWKk3Jhk7DQiQQpCNtpoOcLb ETt2AH+dXUA8dkYhyMxKYDjy2RFiuyx5sRLqQeNDBG4AC20GmTTFDhAwb79uNyTENEdbwF d+gk7OgQmrN6r+y4c2PXEG9YnMgBr5iKKpA8A2bb3tpsu+jbPUTvWAQ7YROQglRUt/F5gA Vv0rFZ/bzJXH++O6RHs1TOD/EEDRVRfy1/WaeYzawHacapL2Y3Rrbroh0zBL/w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793564733; b=P8OzWE+pQnVV1234S3M2yGDJBZH9ApI8bn6rHMLsXSXL5zmuqWdd92t11vTRPzou5jj4w5 CY/s9HQhMQudqiV1g/5iPuCWy3eKhz4o7E2oNUCTS63bvWVsK4gysRw+chJPTf46XAnFtK zV90np5qYmuXGdCsTQx8BVPXVsmnaGc9ccBLiveeUwAf+M9MHKpyV6bV4uuWJ+FLK/Q37b Vp6pQgDeW9oI6PUnDcm8mJog29GEtZaKHpRUiQYtQBN8nIuueBiBdD8rVsONJPwDto/6aC 7ZVBZB2BAzD2lx7qxUQilPqYyh+F3YluzVqoUDDsK6V6CQiVKNCcUQJCrgGBAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793564733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OBOalILKPLmphW3gIJ2cIFTgEzL4Q02wP6Vl0gWpa3k=; b=K0C+iLSmUtKEiD18AlUGjsUc9Wg7flvBtpWRxZMHLkRFgQHectUr74VnZel79jObzBF2VE CYpWkxbs5bmXepGT7Z5yci10BIgG1Wej+vxiOpkVdxbZVg2RAKk2ot/OXoHuZvzeQLLhJ1 tSgpuwzvyeDdc/PH87+tIqlp4OH4UjQ6CngVc+hIeVFUz9s3wXcMtiCvQEbEQMUxT1lVx2 zF/KH+jORkQFpbOVDatGWUtuAzLprt8rIk9FOlTl/6Yo2jI8cicVkDZiE6j6Ph7lWrtLkC nsvokTkLGeBd6X7RF8XiJMVDn4YJD9KxnklYK99XWKwzwamYtwPFFCdmoPTghQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:3973:153d:2ae4:c145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jHmYS3NJDz17bs; Sun, 01 Nov 2026 20:25:32 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.200.71.1.16\)) Subject: Re: git: bb50bb45f5f6 - main - vtnet: move offload functions to virtio_net.h From: Michael Tuexen In-Reply-To: Date: Sun, 1 Nov 2026 21:25:30 +0100 Cc: "dev-commits-src-all@freebsd.org" , =?utf-8?Q?Timo_V=C3=B6lker?= , Pouria Mousavizadeh Tehrani Content-Transfer-Encoding: quoted-printable Message-Id: <85481F33-C074-431B-A7BC-75542A6301A0@FreeBSD.org> References: <6a903124.1e7f7.2909a17b@gitrepo.freebsd.org> To: Harry Schmalzbauer X-Mailer: Apple Mail (2.3901.200.71.1.16) > On 1. Nov 2026, at 13:35, Harry Schmalzbauer = wrote: >=20 > On 2026-08-27 14:44, Michael Tuexen wrote: >> The branch main has been updated by tuexen: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbb50bb45f5f650873b202e644bfcd9f2= 992cdace >>=20 >> commit bb50bb45f5f650873b202e644bfcd9f2992cdace >> Author: Timo V=C3=B6lker >> AuthorDate: 2026-08-27 03:09:55 +0000 >> Commit: Michael Tuexen >> CommitDate: 2026-08-27 03:15:17 +0000 >>=20 >> vtnet: move offload functions to virtio_net.h >> Move the functions vtnet_rxq_csum() and vtnet_txq_offload() = and the >> subfunctions they call from if_vtnet.c to virtio_net.h. This = allows >> us to call these functions from if_tuntap.c and if_ptnet.c. >> virtio_net.h already contained a copy of these functions, but a = copy >> of an outdated version. The functions evolved in if_vtnet.c. >> In if_vtnet.c, the copy has never been used because it increments >> counters in their own functions. >> This patch removes the outdated copy from virtio_net.h and moves = the >> new version of the functions from if_vtnet.c to virtio_net.h. >> if_tuntap.c, if_ptnet.c, and if_vtnet.c just call these = functions, >> and if_vtnet.c increments its counters depending on the return = value. >> Reviewed by: tuexen >> MFC after: 1 month >> MFC to: stable/15 >> Differential Revision: https://reviews.freebsd.org/D57299 >=20 >=20 > Hello, >=20 > do you still plan to MFC this? > Along with c1fa70c6e9f6 - main - vtnet: offer VIRTIO_NET_F_GUEST_CSUM = probably? That was originally that plan, but I think trying to do this ended up in several merge conflicts.=20 Do you need these changes? Then I can try harder than I did initially. >=20 > Thanks, >=20 > -harry >=20 > P.S.: Could you please check if we want to get these MFCd before 15.2 = too? > 5481c2d3ac1f - main - vtnet: Retry feature negotiation without = offloads > c5caf8564533 - main - vtnet: Implement VIRTIO_NET_F_GUEST_ANNOUNCE > d4ddf8eaee93 - main - vtnet: Accept VIRTIO_NET_F_CTRL_RX_EXTRA None of these are mine. So I can't tell. The commit message does not indicate any intention for MFCing. I CC pouria, since he committed these changes. Best regards Michael >=20 >=20 >=20