From nobody Sun Nov 01 13:14:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHb0S2sr5z6yFTQ for ; Sun, 01 Nov 2026 13:14:48 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2001:41d0:700:4a43:a25:de0:0:13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHb0R3q80z4NSn; Sun, 01 Nov 2026 13:14:47 +0000 (UTC) (envelope-from freebsd@omnilan.de) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2001:41d0:700:4a43:a25:de0:0:13 as permitted sender) smtp.mailfrom=freebsd@omnilan.de Received: from mh0.gentlemail.de (mh0.gentlemail.de [135.125.173.218]) by mx0.gentlemail.de (8.18.1/8.18.1) with ESMTP id 6A1DEi9J047119; Sun, 1 Nov 2026 13:14:44 GMT (envelope-from freebsd@omnilan.de) Received: from [172.21.35.3] (s1.omnilan.de [217.91.127.234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id BBAC01A97A; Sun, 01 Nov 2026 13:14:44 +0000 (UTC) Message-ID: <47d5d4c6-3302-42df-bd4a-4f9aa5f7807d@omnilan.de> Date: Sun, 1 Nov 2026 14:14:44 +0100 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 35b59986b5aa - main - g_part: access leak causes process to hang To: Warner Losh , dev-commits-src-all@FreeBSD.org References: <6ac2a76a.3d5f9.55e8bc71@gitrepo.freebsd.org> Content-Language: en-US, de-DE From: Harry Schmalzbauer X-Enigmail-Draft-Status: N11222 Autocrypt: addr=h.schmalzbauer@omnilan.de; keydata= xsDNBGYAIiYBDAC60wPttMw9ESCW1NCayghEHYqdBb0tTQpwzPEidSAEwLYUceWznTKOoBub vqRT4MjkFhVitEVSsx0c9isq75w5PuKr8XHwxvne1nDAuRQZxDWlhimTkPago7zC+X4dKUBb 8+3gWV8WCyno8nsdlf3VvO/GeagX4l4SR9msiQM3XZIDfoqIXMeMF8Z85COdtcQf6JxGHmm3 //X0Z4FbhvUMEXWHOVFigyUippvQa95T3k5fUoZAdhcve+4p/XasIdexpPHCKGWXm/dpGzpm edMN0hUlBSgtjdRfgfDsQGwaPmSYsRBMOoHat7DuEhvFMSY3qE7KU7kEvrUwU420b6iuOROp JNFbIMAqozwEd0IqM4dGQqoxRyDMP/yh10Juy/E/fNTYS8OIbR7JXStXhlBf+B2qTAE0JkDD nhwiHmaMweV6BVhvCfK8nT2pmyKfBSfSMD3gUzLQaq4WQinEz5WSQSWBdYPWYsquVNr+DwpT NmOcYRD7CSKmvojMC1ThqxEAEQEAAc0vSGFyYWxkIFNjaG1hbHpiYXVlciA8aC5zY2htYWx6 YmF1ZXJAb21uaWxhbi5kZT7CwQ0EEwEIADcWIQTjKgWHwF1RpC5MiPNOp16HIeNrLQUCZgAi JgUJBaOagAIbAwQLCQgHBRUICQoLBRYCAwEAAAoJEE6nXoch42st1+EMALbSpQeb11yc95u8 5sbK03jFey4hBf1EZpRpDEFhxLk1uVzr2plrpf4OZw571p6BI5K2GnoMSlzQF1RNUmVqz0zk iJgJmc338oO0+u5xKuf39O8e2JsOuIalOgUEOg5BBqZvVZHivDxjLQ1genVTHZgr2LQE327Z iNvRiQ04JMhlbxGKqpp0YcXLhQ5wwxvjq7+057KB9G4opycpKlRzWkykEKhbVOm5hd7HxTZh +G7QNsEdk0Tkjpt8MKvEZut036Xeo2AlJnoVySJcsGJgDeKngRxbuxwoZ9y6almAvcAXMht3 WRtgk8HWv0KeX9kqvMcZ8nZcoK+TQnXHjKNfVq7pvggmju6d6sFetteGGwpMrKnpXeDZ79GW bjUHFSQNJtJO04KaLrpj4aW+bcACoscUhRjkUVpMXvaSY6i4RVx4Ji9o8CZIEoPD63ii60/4 HDo2H+kLXI3mVOfVhjmfBOmF7nLDt69ZBiXtGKZTV2G0fKLV4ygAV8Zgci2y26q5yc7AzQRm ACInAQwA7JCRsBaHiTGAZ2WxyG3QKOaZuStQ9RIL4m+l3bfIdS6sXJ3skdE7u5r36PKrU2gX QdMmC6c1oN43RpwVZour2xF1Z6HekDkGeN5c8XjKjCbBejVnn6BwHEzvxs+zimIx80uW2iEo cCzB0zA7ItetFTheyZcIYSfu7ZJb48HNFV+43VPDsr/jUY0BbQFGacioEE6UB+nwZSqDVmrw rI574qffBK9Fj9MNO80wiMTK4qS5nviaDU/OKxfs1t5UyoYW3ZxTXLP4xORiJFLBbjovVKhM +5JrUS5TK0tL0N6j2YcMWtJqL8OvuCuczZsUOezFI5Z3RTkQDcGydquj+JlR5pVV94P02M19 KYDLs5ZA4m69aOFTTjl2JvWOPJ037aWNpLFcBJ0h1LBkUel4Z7HSa6WJ+c6iUtD0lVMfxJlT cGBRXzq/0SMn6QVNC1qrBMTN1bVDkrIkCYmTqohMvCW0SUg5K4R8RDG1ruGSqj5LXwAeSZ43 Zns6UhJ80Im1QxhTABEBAAHCwPwEGAEIACYWIQTjKgWHwF1RpC5MiPNOp16HIeNrLQUCZgAi JwUJBaOagAIbDAAKCRBOp16HIeNrLeAQC/98l0xG48cPQ825wCADmR4juIiEqeU/KfZyR2zW GoHHb6rBJth2tU4JAv2TayHT+jYhioo6a1rhxlYfZeVKlCK+toEnJ+usnd0hJ+rwffURWdef uDwKAqvSavWVVDQ07gjlQjgTIiStn+PJ4jvH6YaLroH9aStADje730BqgWwq9BzO45V0GEoM DqF+xtTATDSPkhopcA2n05qeXLJ6/2FAsPjFfHGUr92Gw4wEWOm0wkoGRnRSxpF0ectRNmXk d0Z8JA0hY+XIzXYr9lTJo89CUdx/ppkkKC3mB8E8H7vGCaOim1nGCjTZ6hJ5lAv4Np/Xlzng kT6+wWnWa5j5VXyZykvr+y1JzIFpiDdy9TpmsJBeAbF80UBur2CuXQNxPhRHJyXAxZe2Q0A+ tQgHN6uOjW8Bp9nQdOy4y55FfUMoN9nbdeNNLq7qhTv6GmOQ2PUupocn4YOskKZJn3PXJ18S YNz7MneVch+fUKhJS+DIXkNvInWH/sZBGlBTK0A+Bp4= Organization: OmniLAN In-Reply-To: <6ac2a76a.3d5f9.55e8bc71@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4jHb0R3q80z4NSn X-Spamd-Bar: / X-Spamd-Result: default: False [-0.30 / 15.00]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[omnilan.de]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[217.91.127.234:received]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+] On 2026-10-04 21:22, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=35b59986b5aaedbafefbb79e3da30789ca9aeb24 > > commit 35b59986b5aaedbafefbb79e3da30789ca9aeb24 > Author: Warner Losh > AuthorDate: 2026-10-04 19:19:59 +0000 > Commit: Warner Losh > CommitDate: 2026-10-04 19:21:17 +0000 > > g_part: access leak causes process to hang > > So if one inserts a USB drive with a GPT that doesn't match the media > size, a resize is initiated, so gpart takes g_access(cp, 1, 1, 1) on the > disk and holds it until the resize is accepted or rejected. The orphan > path releases it, but the spoil path does not. So if the drive is > ejected while the resize is in flight, we call spoil directly, without > releasing the access. Since gpt_opened is not cleared for the spoil > path, this causes several different process to hang in the open path > waiting for the leaked access. > > Move the release into the wither function when gpt_opened is set, and > remove the release elsewhere. Since all paths to destroy the geom pass > through wither, this ensure that access is always released when we've > taken the access for resize. > > PR: 297777 > Reported by: Rick Richard > MFC After: 1 week > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D59138 Hello, are you still planning to MFC this? I noted two more of your highly appreciated contributions as MFC-timer lapsed: 0bc6c9279e51 - main - da: Stop the probing when periph invalidated in dadone_proberc e2bcab51fb50 - main - da: Fix logic error Maybe this is a desireable MFC candidate as well: b5f0e7f36afc - main - loader.efi: Be cautious about using GOPs Thanks, -harry