From nobody Sun Nov 01 02:32:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHJl74hJLz6vfr0 for ; Sun, 01 Nov 2026 02:32:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHJl712Klz4Str for ; Sun, 01 Nov 2026 02:32:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793500339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IylujqgAZjEsoYBcYjbJtJ3riuTFEWJRRi7/ETuYYsw=; b=xj1xN9of4W9MJl1Ciw6ScbBOoV274r+foUE2P8ac8rK9PVRxDHERFIeTJKLAlw8PXcSld4 AkUG7GwnSZr9rxRGiGdUbqH/fJNv/PJiCpPfO6ihBD0uPlCYbLk8Ya782TF45YZrJfwbnf lVedT/GqP+BTXjihFBXzjQ0zFcNnw+fDW4jDLoQQP40gbl1R2NePr6rbLoKOAozFqVdMyT NzlvWFoQQjZzrCTOQvhoI3Ib4R3ucoikKfrxd9ztGpjleuwewmJOFyjhH2bXOKnumIUY+2 0/9DxDL0QJZF5kuqr5FMV7VKRtwjDPPPsVBgDGvg4jmVCquzetEL1E23y1rEvA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793500339; b=KH568r4+EWeSXLjfSSjBuURqVLP/EaaPBU+zJ2IAR1hfB9XAsg2F06kjsTFVt9uPiZ+EOx CzCoIkjqOtIXcAEWGvoUDSgy/Nq25lxdHekDNrJu9Avyn77EluOp14VIR/6Iw/bfZA/Cc7 3IHYlYOCaJLGJgSLIUTgNMROXhR6kOa0EpVYuOU4iksLnIa2+ffXlzL6cR0hjBIRw86ZaX 300oZ/STcfuS4wL6dzC//O5Ta2zPrwImEt+lxkoNWd4dQTarrsquBeYuORiAHbnB3EzRKv aK87dVRA9e6HYlYEaAd8zRNMhSE5BUVFRXeNsivtJwpmja78h6w274lrB2PUEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793500339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IylujqgAZjEsoYBcYjbJtJ3riuTFEWJRRi7/ETuYYsw=; b=y1EuZIdfeC982/iUM1ARRPGZUvYn6A48USShBir7JV4gHYFOjNbj3bINrIH538YrOz/vkl 1znzAAbB1KEPKm9F/LdZe8H64nK1jzzQEHM9uwH4uOeQTBhN+Ka0fqVyBLzeOCuVGNaH6B iO9pFR5Rt63FTgW4YWKWmoetihOBJzPF17tCHoNLZOzeEfMqneIVW4tH0Wf3PU3wBuoRI1 VmhFW27DAGzF25vYCV+rO1c24OP4rpr1oYvF7uStXSKudU9RfDJhrqHiZ7cWIxB23mMbyM d3e88+7iQDNVs4tmUJ6YloDkIHUjKEMD2wYcALOUEhtlYB4AD+Mj7KediFjt5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHJl70jVGzgKh for ; Sun, 01 Nov 2026 02:32:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3471d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Nov 2026 02:32:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: 4e17a6f588df - stable/15 - tests/sys/netinet/tcp_socket: fix build with ATF 0.22+ List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 4e17a6f588dfa6edc8a798cda76b9388af11f412 Auto-Submitted: auto-generated Date: Sun, 01 Nov 2026 02:32:19 +0000 Message-Id: <6ae6a4b3.3471d.5ce6fb52@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=4e17a6f588dfa6edc8a798cda76b9388af11f412 commit 4e17a6f588dfa6edc8a798cda76b9388af11f412 Author: Enji Cooper AuthorDate: 2026-09-02 07:38:17 +0000 Commit: Enji Cooper CommitDate: 2026-11-01 02:31:58 +0000 tests/sys/netinet/tcp_socket: fix build with ATF 0.22+ Confirm that creating clients/sockets was successful by testing the result separate from the assignment and test that the return value is not -1 instead of testing that the value returned is non-zero. This fixes the build with [ATF 0.22+][1]. MFC after: 2 weeks Reported by: clang (-Wparenthesis) Reviewed by: tuexen, cc Differential Revision: https://reviews.freebsd.org/D59284 [1]: https://github.com/freebsd/atf/pull/72 Conflicts: tests/sys/netinet/tcp_implied_connect.c (cherry picked from commit 4aea6ea2eb400737837ff8d22c25688f88c7966c) --- tests/sys/netinet/tcp_implied_connect.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/sys/netinet/tcp_implied_connect.c b/tests/sys/netinet/tcp_implied_connect.c index d03d6be4fb92..e81372e9d32d 100644 --- a/tests/sys/netinet/tcp_implied_connect.c +++ b/tests/sys/netinet/tcp_implied_connect.c @@ -45,8 +45,10 @@ ATF_TC_BODY(tcp_implied_connect, tc) socklen_t len; int s, c, a; - ATF_REQUIRE(s = socket(PF_INET, SOCK_STREAM, 0)); - ATF_REQUIRE(c = socket(PF_INET, SOCK_STREAM, 0)); + s = socket(PF_INET, SOCK_STREAM, 0); + ATF_REQUIRE(s != -1); + c = socket(PF_INET, SOCK_STREAM, 0); + ATF_REQUIRE(c != -1); ATF_REQUIRE(bind(s, (struct sockaddr *)&sin, sizeof(sin)) == 0); len = sizeof(sin);