From nobody Sun Nov 01 01:23:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHHCF6kqFz6vXP4 for ; Sun, 01 Nov 2026 01:23:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHHCF5VWrz4GV8 for ; Sun, 01 Nov 2026 01:23:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793496185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9unTDvuTZiJ7tGMScEnuh1MJX7TjoTGJoSIxYBJdWlc=; b=UIgmjuAHeg69LSjqMvooQTpIgUdNQeGVHyEv/WW0kprm6MZFtO1twf70fSEz5DAhYuem6f 73yT2Tl+PJfOshFAcL96zdITe7AKJI7nM35XN2wJGmBbw8wYZ0YaOovTzlWtipsfuO0i8K HPu9PMFX0wBmLWnx/bSYWG5JjQAuxJUNi4nCU9kR6nLusVfuH0UfGxA9PQ/0tym/nHbzin DLgPEKYeGIT+oYtwVCqZ4VyJ8rbbkIrTAVyVSZkC0hz12+Eg4+LFy0BQPMEiIVwrVTsGPj sfbSlNMrcl9IsjyGvskTbBoxjddqCzM17K+WFQLjNknog7M4fR5nMC4RLg2g+Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793496185; b=bmNCyaw4R4xQpAsXhsTcAscuPm6Rf6lrpdQ/jirrIY7URYxlnFcJjacGdTVP0bEk6C93wz HW4fM1+laxIsYvEHRvqvqB/g5Wn+gpFw59XTccdMHMU2IBvf4XLFwVzYtnNMTTpE9G/jC5 w4cj7ATZRRPjvW3HBM8ja+bTWlLAbLjeTTMHycMTfu/BOfX99lVpad3sGf6NTXvWHb+yHY +b1KpQ8oZ7egGOBsun5RfjI3TSfykoZ/F7aDv9GKg7SwXVp4qO2GIZh12P3e3enpqc0wGL vbX7egrl7RcofLQ32aLrflef7VBXRkruT79nTuoyDH8tmplMfAxFFD9kUYqajA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793496185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9unTDvuTZiJ7tGMScEnuh1MJX7TjoTGJoSIxYBJdWlc=; b=AsDcuDb8UC2/zXBw1W84TLYZ1frokwrkuLK3GjBX9tX/WO2ZaNuQu/7cSN/F2jlWDE4GF4 cZC5BahjqDv13NRy02++DVl0Fstl/MNYUtDUoCDRGMo7z1lWgnt1NtKSGTjqpJbr4NblP0 2ylO9rcVPLEVPcbtq0ypMI2RXqQgb2hVzOhUYSudzfnMtnzmRGVDYTlzts1G+Gh33I0ePn tAQrFHa5g8CupKj2e86xaxFJ+g+zY3GdB3rWItZgVPr2dGhbyXJGNvO1f5vrOH3ld2Wwcj EO7RqrlON+nEgywQ0SiA/ePO0oHUaWUHdaJe10tq2mCKnotN6oDurakW4xsFOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHHCF53tBzdnW for ; Sun, 01 Nov 2026 01:23:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24b5c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Nov 2026 01:23:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: b165ec5e21cf - stable/14 - LinuxKPI: firmware: remove `enoentok` logic in `*firmware_request(..)` List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b165ec5e21cf8ee53921eb6c0614c0f61eafab66 Auto-Submitted: auto-generated Date: Sun, 01 Nov 2026 01:23:05 +0000 Message-Id: <6ae69479.24b5c.5c7432ea@gitrepo.freebsd.org> The branch stable/14 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=b165ec5e21cf8ee53921eb6c0614c0f61eafab66 commit b165ec5e21cf8ee53921eb6c0614c0f61eafab66 Author: Enji Cooper AuthorDate: 2026-10-07 18:22:00 +0000 Commit: Enji Cooper CommitDate: 2026-11-01 01:22:56 +0000 LinuxKPI: firmware: remove `enoentok` logic in `*firmware_request(..)` Prior to this change, in the event that a firmware module could not be loaded, the linux_firmware driver would return a partially initialized structure with uninitialized/zeroed out values for certain fields. Linux does not do this, however, so some drivers that use `request_firmware_nowait` expecting Linux behavior, like `if_bcrmfmac`, would crash trying to dereference a NULL pointer. This doesn't address the load/unload situation completely as the driver remains loaded after the "firmware crashes", but it makes a completely unusable situation (a kernel panic) into a slightly more usable situation (driver does not unload). As a sidenote: the raw free(9) call was replaced with a call to `linuxkpi_release_firmware` because the latter call [better] ensures that all resources allocated earlier on in the function are cleaned up. MFC after: 1 weeks Reviewed by: bz Differential Revision: https://reviews.freebsd.org/D58451 (cherry picked from commit ef947bb97302d8862545cd0a5f38b24fa1bae2f6) --- sys/compat/linuxkpi/common/src/linux_firmware.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_firmware.c b/sys/compat/linuxkpi/common/src/linux_firmware.c index f514f05ea67b..7c35320b34fa 100644 --- a/sys/compat/linuxkpi/common/src/linux_firmware.c +++ b/sys/compat/linuxkpi/common/src/linux_firmware.c @@ -57,7 +57,7 @@ struct lkpi_fw_task { static int _linuxkpi_request_firmware(const char *fw_name, const struct linuxkpi_firmware **fw, - struct device *dev, gfp_t gfp __unused, bool enoentok, bool warn) + struct device *dev, gfp_t gfp __unused, bool warn) { const struct firmware *fbdfw; struct linuxkpi_firmware *lfw; @@ -123,12 +123,8 @@ _linuxkpi_request_firmware(const char *fw_name, const struct linuxkpi_firmware * } } if (fbdfw == NULL) { - if (enoentok) - *fw = lfw; - else { - free(lfw, M_LKPI_FW); - *fw = NULL; - } + linuxkpi_release_firmware(lfw); + *fw = NULL; if (warn) device_printf(dev->bsddev, "could not load firmware image '%s'\n", @@ -158,8 +154,8 @@ lkpi_fw_task(void *ctx, int pending) if (lfwt->cont == NULL) goto out; - _linuxkpi_request_firmware(lfwt->fw_name, &fw, lfwt->dev, - lfwt->gfp, true, true); + _linuxkpi_request_firmware(lfwt->fw_name, &fw, lfwt->dev, lfwt->gfp, + true); /* * Linux seems to run the callback if it cannot find the firmware. @@ -199,8 +195,7 @@ linuxkpi_request_firmware(const struct linuxkpi_firmware **fw, const char *fw_name, struct device *dev) { - return (_linuxkpi_request_firmware(fw_name, fw, dev, GFP_KERNEL, false, - true)); + return (_linuxkpi_request_firmware(fw_name, fw, dev, GFP_KERNEL, true)); } int @@ -208,7 +203,7 @@ linuxkpi_firmware_request_nowarn(const struct linuxkpi_firmware **fw, const char *fw_name, struct device *dev) { - return (_linuxkpi_request_firmware(fw_name, fw, dev, GFP_KERNEL, false, + return (_linuxkpi_request_firmware(fw_name, fw, dev, GFP_KERNEL, false)); }