From nobody Sun Nov 01 01:18:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHH5X06Hmz6vX9r for ; Sun, 01 Nov 2026 01:18:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHH5W6678z4Dp3 for ; Sun, 01 Nov 2026 01:18:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793495887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ibJ+KKv5f+OJBAjO7iG776pQ3hHk5RFJtum+tjBvy0A=; b=RFisq3Z2kD05wNldIBfIfx2advxC5CGORVXnqOVjxLGeNzjWqCKzZRChQ3HtwZK0VA/14h r0iLrKfurJTQW0pOQudhlM8ZyiWjgSaiIv+lHU06IhTXmVoOR5DlPKgxokCxxdo2egrMpR YE7v+LDbs2ASd6EtWeKJQajiNhgBJ6r1Kcvbe0iSvAaZ+liiGdf4YIIMEBY/X3nT3SAwsh 1KTik4mIv1GFgCrh9LuAgWCmqFpdsPsb8i1hbv98hwV5Yoz49yRUhpLaw8o5LIt8hVuhaE Mu3l2dzklcqGjrD86yxpEG5f6WWFpMV4tQypDi7r2LfFKcCcA1rIpiCnYybEmg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793495887; b=qhwI2RpHjmt2Zk/Y0VnKFnxKpXBAzQbxuGaZAYT5WXSp5bKAeHfEHK57A8yKsUj45wfaH8 tar0suRWjMiI4gBdNFffTcYMgWt5Bl27lsiRHF/WnJCyqKk4/bzPL7Rk0LmQwQigVW9Moz 8jhpWQTS4g2/toQKV/RpQZzIYAi2jKkISOSEjr5BdxCGfsgzgtFohH0NmLCEAgm+zwIa0/ p/cy2P/qYIUXghdAJ+R8BlOyPaCsdn9c9NfwlGFueqCcMMxkpKr9kJscWgyN1N2zvrSTBy JQPbgquaITBMw5LUQDsO3qQ93+ShjQ/wk2P+MwLpZ+pk+zjcReGdGknnDC6BKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793495887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ibJ+KKv5f+OJBAjO7iG776pQ3hHk5RFJtum+tjBvy0A=; b=gVJ4ek8LbxqADv5vww/cmOenUykERobFBDMUWQ001MyCkd8Eps67CQ3hrF+HGOMBeGZwiz qlarA6Zvfm+ho/juH7ug6eYwZKZWHL7Ukl3a8vkQ1IP6ZXVSlgXWWqIvb1y5nkYq1K29Fb mnf732h1Qwr3JLx7PD6EWnQ6F60k2tx+rDi4ohD9MC97rdzFycYQ+TNRfGHmcozYUoaYnB aHANvGYcgn++GlSD7L50Bn1WKAr0PFc9WKpRo9l0DE6avZTdfE9R2UKf1YJMir4BluakN/ 9iA5sFBZleFxrvZ1AmkPVxRA4sya0FddjDgqU3kzvblKMnP8edjOqsQwhrpjxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHH5W5mZHzdb5 for ; Sun, 01 Nov 2026 01:18:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22bf3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Nov 2026 01:18:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: c88dd36d7cd4 - stable/15 - [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c88dd36d7cd42d00a2ee735ec6e508b7c0e39b69 Auto-Submitted: auto-generated Date: Sun, 01 Nov 2026 01:18:07 +0000 Message-Id: <6ae6934f.22bf3.545cecd5@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=c88dd36d7cd42d00a2ee735ec6e508b7c0e39b69 commit c88dd36d7cd42d00a2ee735ec6e508b7c0e39b69 Author: Enji Cooper AuthorDate: 2026-09-22 06:22:57 +0000 Commit: Enji Cooper CommitDate: 2026-11-01 01:17:59 +0000 [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set In the event that NDEBUG is specified in CFLAGS--which is most likely triggered via `MK_ASSERT_DEBUG` == "no" -- all assert(3) statements are optimized out by design. This breaks the assert(3) tests as they specifically rely on assert(3) actually raising a `SIGABRT` instead of quietly succeeding. Skip both tests if `NDEBUG` is set. There's no sense running the `assert(true)` test if the result could instead be a false positive. MFC after: 2 weeks (cherry picked from commit 6f3445006aa05550f14af65b04276c3d25169941) --- contrib/netbsd-tests/lib/libc/gen/t_assert.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/contrib/netbsd-tests/lib/libc/gen/t_assert.c b/contrib/netbsd-tests/lib/libc/gen/t_assert.c index ce73015142d6..b4023223b446 100644 --- a/contrib/netbsd-tests/lib/libc/gen/t_assert.c +++ b/contrib/netbsd-tests/lib/libc/gen/t_assert.c @@ -43,6 +43,18 @@ __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); #include #include +#ifdef __FreeBSD__ +/* TODO: upstream this. */ +static void +skip_if_ndebug_set(void) +{ + +#ifdef NDEBUG + atf_tc_skip("Testcase requires code to be compiled without -DNDEBUG."); +#endif +} +#endif + static void disable_corefile(void) { @@ -74,6 +86,10 @@ ATF_TC_BODY(assert_false, tc) pid_t pid; int sta; +#ifdef __FreeBSD__ + skip_if_ndebug_set(); +#endif + pid = fork(); ATF_REQUIRE(pid >= 0); @@ -112,6 +128,10 @@ ATF_TC_BODY(assert_true, tc) pid_t pid; int sta; +#ifdef __FreeBSD__ + skip_if_ndebug_set(); +#endif + pid = fork(); ATF_REQUIRE(pid >= 0);