From nobody Sun Nov 01 01:17:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHH4m3LsBz6vWTm for ; Sun, 01 Nov 2026 01:17:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHH4m2DN8z4DS3 for ; Sun, 01 Nov 2026 01:17:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793495848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1B/g5vFDKfUvEUitrJp5TsouWCeuC0M8Rv23y8R2S1o=; b=eXF+xRytp4zrwvnveo/OVqXtrJWV/S0ohe1ZZJxHLaD8Uzb29YAur+X5CsVyOwIR42mpMz wa3HVbWysit7KmJLKf8/ui7dOClPkf6esuETszHXi1ndHbrmkUO8qP3N5ctiQokTU1QRFh KNgLXnuU9BbnaTzdY3X/1fii6AykLUOziyTlzCSZ3KvnuYq1tQOBmIwsYEGYJ8sKRFWTvu sb8H8DlCI8Hka5YV+K+u6wUzeYRF/Xy3FwrFI6uvANowCiE8fHbjUxsvYG84Ho10nWvA8b B4XyjFJ5hGc3GG08VKDV18ea/D+U58FvuWldMX1WflRVzibPyVUr7zmqUxZaVA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793495848; b=X+ht9gCBBp3KlbLSQbYbP7MFie/LNGhh6d+yzt46b71XSg02ZKzPdVooHXVJxMw0vK4M/G 1dLui/yMIuPjj/wyJIvuoJ4qFH/auC23948Se5rZUmatA6gSQdnjIrfs2LfTGgOLq52zns nJI3VjAOmvusGgwGkBcCW+IZUMRRCyPE0iT/BprSwEP81PhvDC7TaDLsfDHuyLGDNApSji 8ODq6PxnYOXnQL8UIuGCsIxxfKeRrDErROp+NYVH0TsfkVInn4Z7E9G2IXA5rnleQIrF/n mK3dBzSeivcFLmTSxii9CumpcrSAj7syfzYpGHkmvogg5H8uKCiIpqd67BhSCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793495848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1B/g5vFDKfUvEUitrJp5TsouWCeuC0M8Rv23y8R2S1o=; b=rI3SYZcQOWM2wcV1YcudpPr6FySLfrIpDbV89xu+HbYPAh8P+ehuhx1CXIyCehL+LPmbyj sMEL0J8TJCuO337CC+NtOetdZPzdZQ6IDo2f4PEIIaQG+EEml3Bd3CzahCByUL/SZAbG4k fM97fekg4gVlJ9w+UmMHM2bP+/QL+B8raoJ5qzby5JeJpEV65gwyF9D5gClsR9HvDGXUyV hqkcJ88vAen2NRaj0xCInQFm/vdZqWtw95SGGt1St2O4Yc/eHBZnixxA8Ldq9JfhHRMnCG SB1rUZDYG2TBj2/Zg5GBeJg+kq/JVs3t2S3Jg+EO5y+grReL9wbf1KSmDkkgjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jHH4m11WhzdRN for ; Sun, 01 Nov 2026 01:17:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24700 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Nov 2026 01:17:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: fe7fe52ed0d6 - stable/14 - [tests] lib/libc/gen:assert_test: undefine `NDEBUG` List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: fe7fe52ed0d65b1548436b754aa181b83d51800e Auto-Submitted: auto-generated Date: Sun, 01 Nov 2026 01:17:28 +0000 Message-Id: <6ae69328.24700.7201c1ef@gitrepo.freebsd.org> The branch stable/14 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=fe7fe52ed0d65b1548436b754aa181b83d51800e commit fe7fe52ed0d65b1548436b754aa181b83d51800e Author: Enji Cooper AuthorDate: 2026-10-02 19:27:51 +0000 Commit: Enji Cooper CommitDate: 2026-11-01 01:05:31 +0000 [tests] lib/libc/gen:assert_test: undefine `NDEBUG` In the event `NDEBUG` was defined, `assert` would become a no-op, breaking some of the expectations in `assert_test` around `assert(..)` failing generating a coredump. This is a better approach than the previous one committed in 6f3445006a as it continues to test the `assert(..)` function instead of just skipping it if `NDEBUG` was defined. Suggested by: kevans MFC after: 4 days MFC with: 6f3445006a Fixes: 6f3445006a Differential Revision: https://reviews.freebsd.org/D60253 (cherry picked from commit 9d5a33d9c294b01cead6ff65b0773b5b5ab85ccd) --- contrib/netbsd-tests/lib/libc/gen/t_assert.c | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/contrib/netbsd-tests/lib/libc/gen/t_assert.c b/contrib/netbsd-tests/lib/libc/gen/t_assert.c index b4023223b446..cec98c3beed0 100644 --- a/contrib/netbsd-tests/lib/libc/gen/t_assert.c +++ b/contrib/netbsd-tests/lib/libc/gen/t_assert.c @@ -28,6 +28,12 @@ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. */ + +#if defined(__FreeBSD__) +/* TODO: upstream this. */ +#undef NDEBUG +#endif + #include __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); @@ -43,18 +49,6 @@ __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); #include #include -#ifdef __FreeBSD__ -/* TODO: upstream this. */ -static void -skip_if_ndebug_set(void) -{ - -#ifdef NDEBUG - atf_tc_skip("Testcase requires code to be compiled without -DNDEBUG."); -#endif -} -#endif - static void disable_corefile(void) { @@ -86,10 +80,6 @@ ATF_TC_BODY(assert_false, tc) pid_t pid; int sta; -#ifdef __FreeBSD__ - skip_if_ndebug_set(); -#endif - pid = fork(); ATF_REQUIRE(pid >= 0); @@ -128,10 +118,6 @@ ATF_TC_BODY(assert_true, tc) pid_t pid; int sta; -#ifdef __FreeBSD__ - skip_if_ndebug_set(); -#endif - pid = fork(); ATF_REQUIRE(pid >= 0);