git: f0e702a7a289 - main - smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 27 May 2026 08:10:05 UTC
The branch main has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=f0e702a7a289f0f350bdaeb943805d6d17f9e403
commit f0e702a7a289f0f350bdaeb943805d6d17f9e403
Author: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
AuthorDate: 2026-05-26 13:21:39 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-05-27 08:09:31 +0000
smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails
PR: 295577
MFC after: 2 weeks
---
sys/fs/smbfs/smbfs_node.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sys/fs/smbfs/smbfs_node.c b/sys/fs/smbfs/smbfs_node.c
index 9893987f7ccd..b2b5d63e2eaf 100644
--- a/sys/fs/smbfs/smbfs_node.c
+++ b/sys/fs/smbfs/smbfs_node.c
@@ -212,6 +212,10 @@ smbfs_node_alloc(struct mount *mp, struct vnode *dvp, const char *dirnm,
SMBERROR("new vnode '%s' born without parent ?\n", np->n_name);
error = insmntque(vp, mp);
if (error) {
+ smbfs_name_free(np->n_name);
+ free(np->n_rpath, M_SMBNODENAME);
+ if (np->n_parent != NULL && (np->n_flag & NREFPARENT) != 0)
+ vrele(np->n_parent);
free(np, M_SMBNODE);
return (error);
}