Re: git: 1df431576f99 - main - sh/tests: Cut down builtins/read12.0 by 2 seconds

Jilles Tjoelker <jilles@FreeBSD.org> writes:
> commit 1df431576f99c3cc26dd4ceb1a6eda864cc9f196
> Author:     Jilles Tjoelker <jilles@FreeBSD.org>
> AuthorDate: 2026-05-23 19:47:15 +0000
> Commit:     Jilles Tjoelker <jilles@FreeBSD.org>
> CommitDate: 2026-05-23 19:47:15 +0000
>
>     sh/tests: Cut down builtins/read12.0 by 2 seconds
>     
>     Since the test assumes a 250 ms response time, there is no need to delay
>     for 3 seconds. Instead, delay for the minimum possible 1 second.
>     
>     Also, fix some assertions in builtins/read11.0 and builtins/read12.0. If
>     `set -e` is in effect, `foo` in `foo && bar` is considered tested and
>     therefore a failure does not cause the shell to exit.
>     
>     Reviewed by:    bdrewery
>     Differential Revision:  https://reviews.freebsd.org/D55191

I said no, several times.  I also showed you how to speed up your tests
by much more than thte two seconds you save here.  Furthermore, I asked
you several times to explain the login in this sentence:

>     Since the test assumes a 250 ms response time, there is no need to delay
>     for 3 seconds. Instead, delay for the minimum possible 1 second.

and you were unable to.  Please revert the non-functional parts of this
change.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org