Re: git: 36b855f18925 - main - amd64/vmm: Lock global PCI passthrough structures

From: Bjoern A. Zeeb <bz_at_freebsd.org>
Date: Fri, 22 May 2026 22:35:07 UTC
On Fri, 22 May 2026, Mark Johnston wrote:

>> There's a bug here.  That should be return (error).  That's been breaking
>> pci passthru since February.  I cannot imagine how no one noticed this in
>> 3 months?
>
> Fixed in commit b13335331092, thanks.
>
> If I'm reading the bhyve code correctly, this is "cosmetic": the
> libvmmapi wrapper for this operation is vm_unmap_pptdev_mmio(), called
> in bhyve's passthru_mmio_map().  When the ioctl fails,
> passthru_mmio_map() prints that warning and returns an error to the
> caller... and all callers ignore it.  I think that was true even before
> my refactoring in commit 86150ed98b790.
>
> How exactly is passthru broken for you?

Was goingt o say see virtualization@ but maybe it's not broken as such as I am
fighting the next issue.

After fixing the ENOENT locally and the errors (or warnings as you say) being gone,
which I thought may be the cause preventing the next bit, I am still not getting a
virtio-net device to netboot the guest.  The tap interface is there and also gets
connected but EFI says there is no device to boot from.  I am still trying to debug
that.  Help will be appreciated :)

-- 
Bjoern A. Zeeb                                                     r15:7