From nobody Fri May 22 00:40:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gM5z14NsDz6fNyy for ; Fri, 22 May 2026 00:40:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gM5z13mF1z3DY2 for ; Fri, 22 May 2026 00:40:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779410413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c4CleROlR17wTldiFGFcWFiATmZqfdOlSkb2YQ6Cslc=; b=RBb4ZQQLHkFNzuxaR0lXs9BE72Wfx/mtcRiBQT/yFdtEtC6E1yKotg7gDKPzpmXO/Gj5kG PN0y6K3F7F9yvmPiqnxzSA7BZnVuWDTrsFUcHuSG4bqi5ouA1eRrwtannZpSUaMowNdNv1 LE+wXD4kupa2uTCDPEho2f2sRfR0OzpFeFisI/iIrSXrCoGijwdT7tGT7vPt07GRZDFDlD oVRmVeFdfWR2w7MYh3+TUvGWHhiic/+d7m2WmCg35XhaewPanYWomJx1uuHeXhwZJ9lOjA IDntL00sOy/mC7z2nu7au54KBM9JSkGKtVrwAORNf7PD9grIMSiPV0Cx763IMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779410413; a=rsa-sha256; cv=none; b=Mm8q0Kh19QmD0vjtuxa1h/VnChgv+VA70rOdQ42q37/caL7R7RzbP8BerBXYFuIBCYuT/A iUBp0HTxV9qwyX2EAUpvibj0mkkSGG+CvQl+hqNMdLVCvnbfChEJrclE+21/5rIILZY0Iu zoJujbT3qRHcatQSZBGfw0ZPdTZ8cbzy3FIbHC3JzlXXBXnBQZjTm26R84lMrmfO6UdtTg Av4A+pzh18TyYbbjOpgRbWSOrZ93qBH042xDMayJ55nHVjzJFtFGFVhHNsROJnnazgNVcC rua7anhYH7rlD4H9gxYvEKW1aA+FYrL20nlcGCZkerUNznWBi5mXl9WFb4ElYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779410413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c4CleROlR17wTldiFGFcWFiATmZqfdOlSkb2YQ6Cslc=; b=jqkxt4hzdzX/VIgQ/6js5GJO8HCUrX8dcJWBCY3xOCEIkPtN9tau65lB50acnCzydMzsnG bgP5XC4NolDCP/ELEEYCeEY2D5aeVb+WUvCCgvP5c0OC3m6PKnFJWd5RBu1AGsXTI6FTqf xcUblK4XSowcr9URh7agg/lY+VqoRfAmMlPUWs0yoTnWcpub+PPHxT4URafd7spLFNbLwX SPbxBuEGkmAUGTKJNqEIeE+xr4//hW4/EF5Sy+DvVCDyrQ9xtGqqQIdHFspv2xa9yqRkiR YBJyEweLFdO83yg6cq2Xr5GXW5zd6Ni24vJLoB0DoV6qLinXQB6Hz5n0uX9Ttg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gM5z132kVzwZt for ; Fri, 22 May 2026 00:40:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39e4b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 22 May 2026 00:40:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: d66fec481bfd - main - netlink: Fix lock leak in nl_find_nhop List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d66fec481bfd65cbabb6c12a410d76843e76083e Auto-Submitted: auto-generated Date: Fri, 22 May 2026 00:40:08 +0000 Message-Id: <6a0fa5e8.39e4b.39a1a3f0@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=d66fec481bfd65cbabb6c12a410d76843e76083e commit d66fec481bfd65cbabb6c12a410d76843e76083e Author: Ed Maste AuthorDate: 2026-05-21 21:14:41 +0000 Commit: Ed Maste CommitDate: 2026-05-22 00:38:45 +0000 netlink: Fix lock leak in nl_find_nhop Reviewed by: bz, pouria Fixes: 7e5bf68495cc ("netlink: add netlink support") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57156 --- sys/netlink/route/nexthop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netlink/route/nexthop.c b/sys/netlink/route/nexthop.c index 314fb66431b9..0b4a929f65a6 100644 --- a/sys/netlink/route/nexthop.c +++ b/sys/netlink/route/nexthop.c @@ -173,7 +173,7 @@ nl_find_nhop(uint32_t fibnum, int family, uint32_t uidx, CHT_SLIST_FIND_BYOBJ(&ctl->un_head, unhop, &key, unhop); if (unhop != NULL) { struct nhop_object *nh = unhop->un_nhop; - UN_RLOCK(ctl); + UN_RUNLOCK(ctl); *perror = 0; nhop_ref_any(nh); return (nh);