From nobody Thu May 21 21:20:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gM1XB74lgz6dyvd for ; Thu, 21 May 2026 21:20:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gM1XB1TNKz3CJW for ; Thu, 21 May 2026 21:20:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779398410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c3xfRQE63F3Wr3vXcyEzl8MfgEBWbEt0m92YAPUJmUQ=; b=ejRF6SwA6/AKFyvH7DRXArkjLLr//qSKPu2Wq2P7OWje6/tB2ZZBUX2RWRo2KWhlgbiR/N HAZSOHz8caWRWPOIIWPTKERUTFaQRI8L9kNKouHrgdkH8+THBotx/nfy6qOpHkQyA5gXAi wNtSdjhz6oBk4SttXdZw27acHrOoVv+wVZBehD+kp087VGIwFoohlGJj6oPWuZlieHL1Tp cjRzke4jJ69qajdPv4rAmG+tjFxcQeSauaWfv6NU08C+6H/dk3wHvCn5raux+mH7E6Kjv1 7HU+IkvqAKnu6Xm+7mPkUae1HIf3B1fOb7KneSWQXCHWQeKJLIks3SSpzXpXjg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779398410; a=rsa-sha256; cv=none; b=woEH5GEul4nZOQNQ4sdG5R5mdKEGGJFOL2BzqIvmrHFowSaNab/+TJZY21jtalPNEoPJPv EUiYaVkPym2PKQiVq9IkDiVGUPgBM6a9ZQayvxmoax4JWXHXj0Fha15ffz4b/tU259vgtz z/EMeWykUao4gO/RWDRnEXGqjVVR483d5iBKz/KuEuG8iy2Tz5y1B8mwL8MHB6vnU6bpiL ovFbVS89gkVdIt9rh1KRtmhhXzpumhw9PUEdPZPghvcjlv56lcTXCv6yUBhAYxvRXS+G6Z khpS8AEQ485P+TAoI5KpVFfsdl9uDJ/KVceu74W/JBRwmQG8W79MXgH/p9aUDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779398410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c3xfRQE63F3Wr3vXcyEzl8MfgEBWbEt0m92YAPUJmUQ=; b=qlJ7uPymlMYkVzWmNel0wPOSb4ZqFMaEwnY2P/Xy075Xp9HKQuTT3FHK0hCSjLkKzPgBA6 AnQJk0p0VWFk+w+4a9tF8KpKA3/LLficWeU/FQC4WSfV5utpaRSH1JWfWqu8tMqtP67GYl nieKomA5ONYGF22n6rgoa733aBQ4m+mmOMQoaRcXkQZ/LY55WNjGhJUPjsO9s4NoilRKwf EdjhP5yzcs9aF1/umnoUXJr7jMStoShgphONgdgZv8zzJ2brR8oVKdJdUzyjNZmD3Fehpi xcKGJ7OFxxjgM2pb4j3TgKg8ZLa/Fwmvk0KLxH3/S4THZg2/WdO0cYwPau1FRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gM1XB0qKfzqp6 for ; Thu, 21 May 2026 21:20:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d8e4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 21 May 2026 21:20:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 64327f769cee - main - pf: fix incorrect table decoding in netlink List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 64327f769cee0c26e1b81e6195a5092498b10403 Auto-Submitted: auto-generated Date: Thu, 21 May 2026 21:20:05 +0000 Message-Id: <6a0f7705.1d8e4.4e2eb214@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=64327f769cee0c26e1b81e6195a5092498b10403 commit 64327f769cee0c26e1b81e6195a5092498b10403 Author: Kristof Provost AuthorDate: 2026-05-21 08:13:24 +0000 Commit: Kristof Provost CommitDate: 2026-05-21 21:19:49 +0000 pf: fix incorrect table decoding in netlink We used nla_p_table for pfr_table structures, but this netlink decoder was intended for pfioc_table and decoded an extra field, outside of pfr_table. This allowed userspace to write (slightly) outside of pfr_table. Use a separate nlattr_parser for pfr_table. PR: 295218 Reported by: Robert Morris MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_nl.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/pf/pf_nl.c b/sys/netpfil/pf/pf_nl.c index d1beb7681c21..0e1c77864615 100644 --- a/sys/netpfil/pf/pf_nl.c +++ b/sys/netpfil/pf/pf_nl.c @@ -2189,7 +2189,14 @@ nlattr_get_pfr_addr(struct nlattr *nla, struct nl_pstate *npt, const void *arg, return (0); } -NL_DECLARE_ATTR_PARSER(nested_table_parser, nla_p_table); +#define _OUT(_field) offsetof(struct pfr_table, _field) +static const struct nlattr_parser nla_p_pfrtable[] = { + { .type = PF_T_ANCHOR, .off = _OUT(pfrt_anchor), .arg = (void *)MAXPATHLEN, .cb = nlattr_get_chara }, + { .type = PF_T_NAME, .off = _OUT(pfrt_name), .arg = (void *)PF_TABLE_NAME_SIZE, .cb = nlattr_get_chara }, + { .type = PF_T_TABLE_FLAGS, .off = _OUT(pfrt_flags), .cb = nlattr_get_uint32 }, +}; +#undef _OUT +NL_DECLARE_ATTR_PARSER(nested_table_parser, nla_p_pfrtable); #define _OUT(_field) offsetof(struct nl_parsed_table_addrs, _field) static const struct nlattr_parser nla_p_table_addr[] = {