From nobody Thu May 21 20:21:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gM0DN74rFz6drqs for ; Thu, 21 May 2026 20:21:24 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gM0DN2kqtz3x00 for ; Thu, 21 May 2026 20:21:24 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1779394876; bh=OiBNytJ5wxSfxnzrG0kMb3yh7vlyBWOWkfUzopc09kM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=ruLuKi+r+3gGE5V0yb8uKrYF76lI9g8WfMsgVQpYFNLrjiDR1en34dtIcevzzE6vPoQ4s7zbUVXmYG+tl9xB9zX7mmGyu8O9YM8wyVGhnxWLTmQFm9/xOU7sjJvcmLAPfs9ryUiq5mxlaFgEeQrqo2jzSGBR01s/ZEJWCy6SWYsD54tDkjU2jvBKY5SBBZFYBgDevBANpoVSHRBWC8vqo6Aj5anf8O2xqu+EUTxDqtD7Ats0ZIjXH1oIrUrvhhFW7kPiAaG46HNPh9kfNCQtev6f4t7T1dGJGM/zb37W0I6rjOhIkkivC/yjI1lOaoan/TIIlP7DoqD9ryikbhUcUg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1779394876; bh=Rwt/rbxE3MA9Gt1+TWirJJ7pCVRKDJrHBDAOGOeIXQ2=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ZrkvE4Dr/fVRD2+hNFnuQAsDNEIwxYxVclMTZvAgjRtFgP/tlfbQTJwz6egt4H2Vd8xtdSV5AqY8n41O3aYehHUKuq6Q7PkrQxIBJarTgCqVj5BZA8JfNhaSmKdr0Q2d3uORrNoCL+RPp+ZON9Hk2Q9n4eFiY8FUZp2f2K7tVnB354GqcwnbTUIBiwy0rfno/NlvDUuWxI/Tb2DxwZoeipcvU+peHiRXsPYhzTJNEzGmCMeh963gvD1mMLomn3WC/Gu3CwPguwbhV79SfcTBwVW+AWl1JLMUwTDSmEnwkfzx4Hgmy23zbtwBR2wzjfDwDVlnrOyGG6kuR2ayf2l/eQ== X-YMail-OSG: 2sjVIIwVM1nvH7hYmFB.YiQI9tjt.gJkPZpMeY9_gzIbSZjltihhvuHY4Gnqxg. 9r2BO33BuwFF6tYZ7t.ruDMYAi_IY3et1zbwzBll0_RTmoASlv1e_SLYzjDeojmHGocFNDIG3bBU VZQVEoJmH32ohPZffyHtkLBgpeLBF5LRVSie.xBFRXpNuAHGkeTV2MU38zG9DmIuP9iPjlJ40rFl Rw_UZv4mLPhMGCJDqN4pwCwP0WSG1poJuzAWmvU64Rz22fY7HFULhkNxu_D1clr2wk3BFoC2jNzZ Wz6holUB1BBk1aG498o.RSVcqLLGckVJE7jICV2hgF7x6l1skY0BFE32pL4ANk7EetD0Tf.J4grm ES5m3hIEMguCtx49bu6UyzEn9te3.0Mor7Oa_WFy71npJaXG_ydLpV.Zp.JxyFEjmDUsFweva4sV m000pbNpq6DV1JKduzYI_Z3I4SC.G1uSrAYMeicKttalDQ5_v2lvXtllSOLoJFS0sSXkNHp3nTXg .1mrN.6R9129T_ytbsYoshKlhlu8Z2SzgDQ5R1cre2Eb24AbiQ_tLSmDFHjZDNk1ZOQg1uKMDPCi ytcM0dNaJ9NLDb639p3OtXiaURxCith.9vVY86gVrjKhuara9C7wAU0C9Tq8Htgdts3czT0mGjkE uoUMLmIVmliM.W3aDuPHambDQVMOAJK8am75Qqk8z1LK8sD0XKEqsg2l3seCvAQcnRG33.cdO9Vy xaSfnW7d2MARrf4_lj2oDuhmxWmUpp7KSpZkGYr6hczFXOIn4bXcDbgfPSbxS81C1fPDcC1qZH4w yhpquw.03B1mPcPjHKMhmP6qALoCIcy8mGbcWL2Fne6_VtASjA1.F7PONTiEtDj7R2fQFZicwD6K 8veEWXGa3XVYQgt4UsDwfkbW9yZwlxSWhdP22UyP5DJSj0QAPkbaVa0uV22acycedUyWcQs1rsbp KvjBUrhawLJQotmbD4mfrYJWxn51wXEUqCjJDTmoqotfbxCoaZDtbmw8dGzrW.IEmnb7EgmK47Ha SRmjx.r_mdKJvC9ziNV7tXd3uQDLiqSy3t16hPwkBzcP6fAuQLao6WhmSAWQATKX_1g9kNgygUet ca2bdf5LYEgAMLwV.QWC5jtHWic9SRl6RTGXJFu8tHuB2wO99I6U2vaaf5Uc8uDUwoVApSsoGITg X4xdhYvDJBR6viV9LidA9JVIEAp5ctN3Mb3nRAM9q6KPDw0kZjMoUEPg8iSMCtZlOfzDp4oqNDaQ pu7J3EXBtrRH2fWNX9ROK_a51KIDR2lI4Jlr0YGL5HLvj8DH9EkKmccRXZz9Xj0YT79t3KgeYrNG j_WrUzBEDEoQN9ZkK0og8giGvlqZ2Iw5CF6.dzFtXiuP2fAQ8YGgd.9.NL202v1.UPqYm67Qt0Dd tbrhtINmqK2WQJrycxxD8tLcWHW8bovaVT2G3FU.AWuQ.LG1owlCk9bAQBejMfMiQk56uG50eZHu m_IHRjsYSwpP_gB.K_0Hi6NZqGStHsdl.qDusJOJVip1fRNyLEPJr_F_T.xgEtoyBXePfEnL8ya7 qarNvximwyFh_Z88fUDKSHO_lgfJUS1q.PeCHJ7PHa9JoPevvw6wJxc1wXjkWPqDfUWmyUkx6QdX pW08GhvhbxA4RBuS__Cco5i_vl2xXK.xELU3B_omI_fxd8RzDCDvguLp_JNyddjQ4JaUid0p_iGS dMihIzHsu4Y88_s7jduOR_AhuGs9fMiIYhaQGQVdgarqXhbXz0dp6iV7IX5r2zo39ZHS9KpFOfFq OxzgcSq.JhXm6IiO71b2wpt.ilqgT7SP7GOHGL1evc5CqPUI44wD75jbK4a3h3OPz3THN_.GftsD KQWuS2u06fvkctNUmRjl.5rVjvWJh6wui4lMOca4rkux_7psOuE0GoyrRChcl1V5SmMT8UE0Omva ZEniGFGLb_LaNrQtPoQ7t6o0A8k2_uz4XMN5fScM2mlBUACzN4Tc5exB6deiFFyI4SQD3jfpbLIf ALkauPvAqxzVQMDzKtD_ZmIu7ylkUxJ7w2PjnpLOpsp_smNrXAT1jtwwgsbrRBQd1nUVEs8ouYap UJb0pa4mw_r3Orxfy.ZC_0txts4c_dkuvLj2PFg6C5B.2l4bv635.xyvOwkB8HVj6ZukYN1UARfd x9Fj8znqFy7phtqnpLb1jt3r7IHoxKZnKxP0eA1jigIwSz9LHb0bR3bZewU42VORhPpmAxV5YuM7 Tp5wZ91CvuAzMl8cEtd1p.kvhEitK8o0nieEvCZbLSsE6RbG75PVfDpZum3knAid1tB9ubs8o.vr WQhXMt94GoZAhqYY__rdTMprz1yO1uiuik7sNf.Cf27jhglRQGNk- X-Sonic-MF: X-Sonic-ID: 34827c72-eecb-4003-91d0-3ae2b942ea22 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Thu, 21 May 2026 20:21:16 +0000 Received: by hermes--production-gq1-7bb7df5c46-c2zcp (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 592a36ae2923a42f47e24dfbd6fe8300; Thu, 21 May 2026 20:21:11 +0000 (UTC) Message-ID: <6f82ab2f-b5da-429f-84ed-4d5b7af5f5f0@yahoo.com> Date: Thu, 21 May 2026 13:21:11 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4dd97955e68d - main - libpkgconf: Fix paths To: Nuno Teixeira Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <69ee1653.34850.61462b24@gitrepo.freebsd.org> <24a05f73-84a3-480f-b797-e0688753810c@yahoo.com> Content-Language: en-US From: Mark Millard In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.25725 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Queue-Id: 4gM0DN2kqtz3x00 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On 5/21/26 11:18, Nuno Teixeira wrote: > Hello, > > This change doens't honour PREFIX when it is set to other path than > default "/usr/local/" As I only had noted an unexpected year in a date when I read the original and replied about that, replying to my message instead of des@'s original message is a little odd. But, in response, I did post a question to the review of the original https://reviews.freebsd.org/D56404 ("pkgconf: import into the base system"), asking: "What is the relationship of this type of change to use of ${PREFIX} when ports install themselves and it is not the /usr/local default value? (There is also a linux compatibility related standard default for PREFIX and folks can specify things like /opt .)" I referenced you and your message. > > -CFLAGS+=       -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U}/etc/pkgconfig/ > personality.d\" > -CFLAGS+=       -DPKG_DEFAULT_PATH=\"${LOCALBASE:U}/libdata/pkgconfig:/ > usr/libdata/pkgconfig:${LOCALBASE:U}/share/pkgconfig\" > +CFLAGS+=       -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U/usr/local}/etc/ > pkgconfig/personality.d\" > +CFLAGS+=       -DPKG_DEFAULT_PATH=\"${LOCALBASE:U/usr/local}/libdata/ > pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U/usr/local}/share/pkgconfig\" > > Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439 > > > Thanks, > > Mark Millard > escreveu > (domingo, 26/04/2026 à(s) 19:08): > > On 4/26/26 06:42, Dag-Erling Smørg rav wrote: > > The branch main has been updated by des: > > > > URL: https://cgit.FreeBSD.org/src/commit/? > id=4dd97955e68df02b26d59e4e7c9a8167947a5164 cgit.FreeBSD.org/src/commit/? > id=4dd97955e68df02b26d59e4e7c9a8167947a5164> > > > > commit 4dd97955e68df02b26d59e4e7c9a8167947a5164 > > Author:     Dag-Erling Smørgrav > > AuthorDate: 2026-04-26 13:41:47 +0000 > > Commit:     Dag-Erling Smørgrav > > CommitDate: 2026-04-26 13:41:47 +0000 > > > >     libpkgconf: Fix paths > >      > >     ${LOCALBASE:U} evaluates to exactly the same thing as > ${LOCALBASE}. > >     Presumably what was meant was ${LOCALBASE:U/usr/local}. > >      > >     Fixes:          b8352da33f34 ("pkgconf: import into the base > system") > >     Reviewed by:    khorben > >     Differential Revision:  https://reviews.freebsd.org/D56642 > > > --- > >  lib/libpkgconf/Makefile       | 4 ++-- > >  tools/build/depend-cleanup.sh | 4 ++++ > >  2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/lib/libpkgconf/Makefile b/lib/libpkgconf/Makefile > > index fee7f275d9ff..3cfb2172a00e 100644 > > --- a/lib/libpkgconf/Makefile > > +++ b/lib/libpkgconf/Makefile > > @@ -14,8 +14,8 @@ INCS=               bsdstubs.h iter.h > libpkgconf-api.h libpkgconf.h stdinc.h > >  > >  WARNS?=              3 > >  > > -CFLAGS+=     -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U}/etc/ > pkgconfig/personality.d\" > > -CFLAGS+=     -DPKG_DEFAULT_PATH=\"${LOCALBASE:U}/libdata/ > pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U}/share/pkgconfig\" > > +CFLAGS+=     -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U/usr/local}/ > etc/pkgconfig/personality.d\" > > +CFLAGS+=     -DPKG_DEFAULT_PATH=\"${LOCALBASE:U/usr/local}/ > libdata/pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U/usr/local}/ > share/pkgconfig\" > >  CFLAGS+=     -DSYSTEM_INCLUDEDIR=\"/usr/include\" > >  CFLAGS+=     -DSYSTEM_LIBDIR=\"/usr/lib\" > >  CFLAGS+=     -I${SRCTOP}/lib/libpkgconf -I${PKGCONFDIR} > > diff --git a/tools/build/depend-cleanup.sh b/tools/build/depend- > cleanup.sh > > index e9c02d015368..c186c39a3448 100755 > > --- a/tools/build/depend-cleanup.sh > > +++ b/tools/build/depend-cleanup.sh > > @@ -317,6 +317,10 @@ check_epoch_and_opts > >  #          "$OBJTOP"/tests/sys/kqueue/libkqueue/* > >  #fi > >  > > +# 20250426 # libpkgconfig contains incorrect paths > > 2025 above is a typo? > > > +clean_obj lib/libpkgconf personality c pkgconfig:/share > > +clean_obj lib/libpkgconf pkg c pkgconfig:/share > > + > >  # 20251219 # libkrb5profile is now internal > >  for libcompat in "" $ALL_libcompats; do > >       dirprfx=${libcompat:+obj-lib${libcompat}} > > > > > > > -- > === > Mark Millard > marklmi at yahoo.com > > > > -- > Nuno Teixeira > FreeBSD UNIX:     Web:  https://FreeBSD.org > -- === Mark Millard marklmi at yahoo.com