From nobody Thu May 21 13:38:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gLqHK2WJsz6f2gt for ; Thu, 21 May 2026 13:38:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gLqHK0qSyz3FTc for ; Thu, 21 May 2026 13:38:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779370701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AMP0f1V2InbOnpMH/b061Olgki0csDO/y+G5ednoTLo=; b=IAiAHxsWlk4ZF2NvP/lk6nwv4m2gzmOyCsPDIMNrfU4TKH9qOKeiKlYrGtEJzaL6JhXGVr EjRMaQWr5zZFVFuc4XebEwa0gDumzt6yLB6nD6lAVfc2NpT844uBt9/r6k52lmTv1GXOQQ cPOMf5RKmETsg79+BlnnO6Syh0n3H7bNaUUMm3LPKIiFZCmsh7WpU9tjHrAXrHvi2atTxH RatLzF51XoZXkll0Z9ihS38jp0KStWhmguhJYODWzInhX42KIS8iH76ZZgsfKEejxJszJs Fuw85kITGMmZZI8lmGraX6FjZdi9c2Q0Y7eRWBfnJ3kgFSYtjkqmJikNcAT3eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779370701; a=rsa-sha256; cv=none; b=coACXpAyh+qeWPbLAyWyMU4d0adNDewbkmEsV2hw1bpjm//Dr6FrzEi+jrhmpVnR36zken 2Z4azLeyhC84eRIHMCtr98FofeE6WxhUcMErwBMUu7jabkTKz3vqbPEwSH5YPv30VYHndT 3xOIomZC85tPdye/S2AtJbcC3YenQFJAoagLA/aXaqTvjFtsWztaDh5l6T3dffRoACXb6J +v1T24DH1YXlFWOXaxVFMVJyCQRvQhYZSDRieJdJGSBrgmzCpK76qKI/IDNgKDoH2FZAW7 8Nv4k3AeTUK9vVJ9WYTXJrA8v6ygew/iiBfjrBlU/KdQfMOU1mSNnhOTHsZl+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779370701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AMP0f1V2InbOnpMH/b061Olgki0csDO/y+G5ednoTLo=; b=S2XaDE5wRVOuAKD385eRKM/ATSh/4rxWv3WwAol4wz80BYA/eRqkeEKPl+iONxhjFoGZPA FsqtgBZvTNdZtLnsNdBf9WWx5yhLgOFXyGi3douTCyXuXVyYXP0INU4A7a57WaoF7q/ckg 0oo9ltgOX77Ti6UFL8EpdhNLwdiLD3IcN6qrBLCx4qNMfDyyaQk2Oi/slYPYniUT0a2mEE j8cs6b8n5A5p2u7W9j0nooedSKYLD90XCOopGy0EEAgjbAAaebFs9emWUzfiozQMy82ZWp R9LPC4XA3QmPU8oaBcFSn2hpW8R+PZNm+9T/6XHp4mA4s2hsYfSWRRzMoJqYwg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gLqHK03p5zbTD for ; Thu, 21 May 2026 13:38:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b54d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 21 May 2026 13:38:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: d7cde43f95bf - main - Revert "loopback: Clear hash unconditionally." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d7cde43f95bf432b6894c3cf804a8dffe99461e4 Auto-Submitted: auto-generated Date: Thu, 21 May 2026 13:38:15 +0000 Message-Id: <6a0f0ac7.3b54d.68a9a336@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=d7cde43f95bf432b6894c3cf804a8dffe99461e4 commit d7cde43f95bf432b6894c3cf804a8dffe99461e4 Author: Andrew Gallatin AuthorDate: 2026-05-21 13:28:46 +0000 Commit: Andrew Gallatin CommitDate: 2026-05-21 13:34:40 +0000 Revert "loopback: Clear hash unconditionally." This reverts commit 2fe37927d41990abe8d1c336e75fd75873285e90. This turns out to have been misguided. First, clearing the hash results in all loopback ip/ip6 traffic being hashed to the netisr queue associated with the if_index of the loopback interface. Eg, it bottlenecks loopback traffic. When the hash is kept, traffic is spread evenly among netisrs. Also, it is safe to keep the hash here. The clearing was only needed when RSS core selection is enabled; we only enabled the consistent hashing parts of RSS globally, not the cpuid mapping stuff. So there is no need to clear it. Reviewed by: glebius Sponsored by: Netflix --- sys/net/if_loop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/if_loop.c b/sys/net/if_loop.c index 33ddd3a8540e..fc5ce9548bcc 100644 --- a/sys/net/if_loop.c +++ b/sys/net/if_loop.c @@ -219,7 +219,9 @@ looutput(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst, if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1); if_inc_counter(ifp, IFCOUNTER_OBYTES, m->m_pkthdr.len); +#ifdef RSS M_HASHTYPE_CLEAR(m); +#endif /* BPF writes need to be handled specially. */ if (dst->sa_family == AF_UNSPEC || dst->sa_family == pseudo_AF_HDRCMPLT)