From nobody Wed May 20 19:40:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gLMMj1TJRz6fJvc for ; Wed, 20 May 2026 19:40:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gLMMh5YFnz3ZvZ for ; Wed, 20 May 2026 19:40:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779306032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JzE2dSC2fmL6CrYGRlVGhusdcTmWYTROnEj3ImFANjg=; b=nM9RDSsnmgbTuybAQ6CHUCyotLenU6Kq/TM4bhXf9pQhEyPaxc9I8KYl3ogtsWrnAOo4nM 6jrl1ghmEsnrZ3SVU/FxhUeQJqm4T7QDALZGbISvrCWAqHKBMUO/g4oTfVZTBhzyyDLFLh xAUQN57kNZJILipsK/X6tPnDuIh9ZmV/bF2/Iujljgll0Yd+X4s5Q6yIO4HwnQNbkD9dX1 VJJVCwsqh1VJCyJem/bEfWH9BaCtpBiTxzp1S7DBt2NfzUUeRxI02GnzIiL+7Z0domTMBF YSCjyV8NohQtGWYMVN3w2Vn+g5dCs8SETiUQXGC9U1aESGFv0iE+VPzvavrz0A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779306032; a=rsa-sha256; cv=none; b=jR5DEl2Xq1Q7KXgENEADKILTk16eicJnZ70Q/jybRc4kQ08Kd2n5ZFVyZIB6+ScLERgtQA F6RCEvRpkjzUuZEOMA7rZxVM93iK9Rr2HlFNbqz92HCktlQ3A644Rs6smk/y3Pp0sisPUi CLz8Dg23gOswOJ+qmcgxUEwz6p1cRETUmcD3MbURrj/1iQ2xtUykRRjLUwVYbyDNu21Z5I nphbKdDcjDNBXvaQK16VkRmxJsztZZZYaYUEwc1AqlUMxoN2CTk9hOxLDz5B3nTQ4+U/mi kmZZjJJJ9yZkExaYMbcnEJdbAXo7cYpJDa8MzDDnpJd01vjeYAcuA3CWlJ1MFw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779306032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JzE2dSC2fmL6CrYGRlVGhusdcTmWYTROnEj3ImFANjg=; b=oL5pBSK1+YnK+8ZBHwi7TGTmBO/NAXvlVU68REUU+ZI6KnIuvFw60q5EE6bbrSHxb/Ca50 CNy8+IO1j9uI8bqgwShfN88jvYPLPAsfGib8h/wBTN4ntecw9+1sN2DU2o/4d7VpyQu3gi +RFNPxspf5EsCvLi0pIHnpyFnk02bNxxGN5xviklxXa4D/cZ43+EE+uMBmd0sKCG6vMCNq VlTpXlORv/mxHjcMynO8Fxdd1qYGFitffnrGkTOasz7RAewQOoVrfhiuPxQdTmyR5iGZa/ 9fn7uGMVYh2ANwmyS58ZmRJUsluqn860KlzUBr0RbFKEASM6rrLN9VwumicM2Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gLMMh50ZLz1DY2 for ; Wed, 20 May 2026 19:40:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3932c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 20 May 2026 19:40:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav From: Mark Johnston Subject: git: bfff5c180193 - releng/14.3 - setcred: Fix buffer overflow List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: bfff5c180193845664a0d9f56f94111214e7c80b Auto-Submitted: auto-generated Date: Wed, 20 May 2026 19:40:32 +0000 Message-Id: <6a0e0e30.3932c.516f7981@gitrepo.freebsd.org> The branch releng/14.3 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=bfff5c180193845664a0d9f56f94111214e7c80b commit bfff5c180193845664a0d9f56f94111214e7c80b Author: Dag-Erling Smørgrav AuthorDate: 2026-05-07 08:06:35 +0000 Commit: Mark Johnston CommitDate: 2026-05-19 23:48:36 +0000 setcred: Fix buffer overflow Since groups is a pointer to a pointer to an array of gid_t, we should use sizeof(**groups) or sizeof(gid_t) when calculating how much to allocate and copy in. We were using sizeof(*groups) instead, which meant that on 64-bit platforms, we would allocate and copy in twice as much as we should. Unfortunately, in the smallgroups case, we copy into a preallocated buffer which has the correct size, which means that if sc_supp_groups_nb >= CRED_SMALLGROUPS_NB / 2, we overflow smallgroups. This is a direct commit to stable/14. Approved by: so Security: FreeBSD-SA-26:18.setcred Reported by: Ryan of Calif.io Fixes: ddb3eb4efe55 ("New setcred() system call and associated MAC hooks") --- sys/kern/kern_prot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index d0f4c8cd6992..cec3fd829564 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -527,10 +527,10 @@ kern_setcred_copyin_supp_groups(struct setcred *const wcred, */ *groups = wcred->sc_supp_groups_nb < CRED_SMALLGROUPS_NB ? smallgroups : malloc((wcred->sc_supp_groups_nb + 1) * - sizeof(*groups), M_TEMP, M_WAITOK); + sizeof(gid_t), M_TEMP, M_WAITOK); error = copyin(wcred->sc_supp_groups, *groups + 1, - wcred->sc_supp_groups_nb * sizeof(*groups)); + wcred->sc_supp_groups_nb * sizeof(gid_t)); if (error != 0) return (error); wcred->sc_supp_groups = *groups + 1;