From nobody Wed May 20 19:39:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gLMLz3ckYz6fJbY for ; Wed, 20 May 2026 19:39:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gLMLy6zYnz3YXf for ; Wed, 20 May 2026 19:39:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779305995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mW2a+1iHML7idsFRJ2qAFc2m4kn5AouQkdeDOSmS8Ds=; b=FjB0/ZbHFsUHAO+X64m7K17Yh/Xqr/vR2fvVic2Z2uWR8Bsf685Lz1w03ElpwEVn5dzP26 hPez7IfpQi1CgsCohlcVsj60NjjiJG0ptpT2roru2NYUShUsaFj7DPB24/0SWuAg54DpxF bJOwliWSEcqYh44UlyA9/4NPFlucONT6ZBamLngrtecdzeiFupSZOPUyjDB4ll3LEMO5XL 2yuPqFlyyc0FLY/11Aub4+irItvuhTzzdOTR9n3wjtKsDOnviTORhnmGBjOruZv1Ce3lGK Pb/8UdW6WFgU3l815DUaIAKzd1ewQizhypT3pXS/HYL4sEXKazmPWgD/ZWlorQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779305995; a=rsa-sha256; cv=none; b=a2Knexb57Ik7Vgqb9WPworvPWWhAcH4Ay23nFVTCcBQHQC+XKyFmUT5HWJCOwYOd08aR0p fMthMUyKHaUq3Ahz8FczcABUyFLuKzRz7dRrzSgZ84mpX/x2oNxVtYAUvwIycuAFfUjXQI lKjdwKrzFhmmG4oSfZs49GjXeY/jqExjklcw9cI4yApbL3uoqPDwkYKlp+HPrvXeCDmk+m /qBeLKe2gu7uMV1tzzaXALTVHA+nvPnMS1hgNCnpJBMslhc/fBroJ7GeGNoBP1vGqI0IPe F/Z+UUBRKD9Ow36DCGZx/IjWjQ21Gbea8S3eLAZRTO6uzqvfbtbxp0YB7thjzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779305995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mW2a+1iHML7idsFRJ2qAFc2m4kn5AouQkdeDOSmS8Ds=; b=bpRoEa81N2LL8/N8B0ECYXms6Ns+R5PcH2ohmvsnYGO+fH3zAg0aBhMVNcRBsKN/dZMQJH /guEPC3tNM9fEOrgHTNniOzh65l9dEMyYFFQ5BpJIXZYSLjL1du8Be739hJrUDa174Djth SOtedzRfb+UBe8Q684mbdIat4Awq/Sn0GeEo61v/T6IQXwifvoEy059St6BLtnVyKVbXIW 5n46++c/hdFfkqfyZdTrZ3f9MQbAzl187jAzI6L3jIy/3BoGujC6/ElSo/e4wYz0JA786k POit0iACoan+weGQj4hHR+PxzWq2Cv9eVgwqHdKfc3syGxGO/9toxr3cVIOUEQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gLMLy6Rzzz1DfN for ; Wed, 20 May 2026 19:39:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3657d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 20 May 2026 19:39:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav From: Mark Johnston Subject: git: 34da5845b8d4 - releng/14.4 - setcred: Fix buffer overflow List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: 34da5845b8d401a451dabc6c1c5bff6973879105 Auto-Submitted: auto-generated Date: Wed, 20 May 2026 19:39:54 +0000 Message-Id: <6a0e0e0a.3657d.669c016e@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=34da5845b8d401a451dabc6c1c5bff6973879105 commit 34da5845b8d401a451dabc6c1c5bff6973879105 Author: Dag-Erling Smørgrav AuthorDate: 2026-05-07 08:06:35 +0000 Commit: Mark Johnston CommitDate: 2026-05-19 23:49:37 +0000 setcred: Fix buffer overflow Since groups is a pointer to a pointer to an array of gid_t, we should use sizeof(**groups) or sizeof(gid_t) when calculating how much to allocate and copy in. We were using sizeof(*groups) instead, which meant that on 64-bit platforms, we would allocate and copy in twice as much as we should. Unfortunately, in the smallgroups case, we copy into a preallocated buffer which has the correct size, which means that if sc_supp_groups_nb >= CRED_SMALLGROUPS_NB / 2, we overflow smallgroups. This is a direct commit to stable/14. Approved by: so Security: FreeBSD-SA-26:18.setcred Reported by: Ryan of Calif.io Fixes: ddb3eb4efe55 ("New setcred() system call and associated MAC hooks") --- sys/kern/kern_prot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 246413a54903..e2accd7f7729 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -527,10 +527,10 @@ kern_setcred_copyin_supp_groups(struct setcred *const wcred, */ *groups = wcred->sc_supp_groups_nb < CRED_SMALLGROUPS_NB ? smallgroups : malloc((wcred->sc_supp_groups_nb + 1) * - sizeof(*groups), M_TEMP, M_WAITOK); + sizeof(gid_t), M_TEMP, M_WAITOK); error = copyin(wcred->sc_supp_groups, *groups + 1, - wcred->sc_supp_groups_nb * sizeof(*groups)); + wcred->sc_supp_groups_nb * sizeof(gid_t)); if (error != 0) return (error); wcred->sc_supp_groups = *groups + 1;