From nobody Wed May 20 19:38:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gLMJq449Yz6fJfX for ; Wed, 20 May 2026 19:38:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gLMJp5Rwdz3VBB for ; Wed, 20 May 2026 19:38:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779305882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q6QM6nU4eRrQLkOJO21tz4OKzA5F01UySDHO6BrK6jw=; b=IiHbP86zELFIe+f9a2BJeewz51k/kHr5b380tTuMCDXJNRlssYzOmh513ihYcWVETEUryQ +2RrQzE8RaSEcRWyezIA6zXwnZYkYzBu4Nej/udzBgTOV9IA3eJEhGeL4T0+JBSFwnbDcd FPHZ9+KIsMVMDgVWnWrrNRCV4yOrnuM0WPs4rVLIC4fPLZPhMMjAbtKHLrNXE36gvq8wgr EfvFUDuZBF8wGN7i09uu6XP1PSG62ITfAAhB6zrFgg5RiQ0Bl7eCk/qE125STMW35sFcDt y6+JF4SyZ7FnY5/WtIkP4T8LPkTkFlMAmpQ6zqXgfddqRCgMAkGThUbejsUcsQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779305882; a=rsa-sha256; cv=none; b=fs6/sKu1ri/fHbEVFJVJr+kv6MCG8jTsDxknTOS06dp8QtKR54xxR0GgPeTzOzIjD4hH9F uaFN/E3vt3UP+J3ETQcbNrzpIin5u38aMWS1ci7gW6QjE6spobEf7Oke3g99QxYgkzI+gi nN7GDG/5M4T8CeDHSN2okAzYn6K0emDyajV+0kuzubpWeu0OeRroP3nW+uNXHdhclLGar7 2X/rowi6uwg/DoHdhgTy/ei0SMPefUL6hMKRcLpy0CP9nAeBStuOdm+i0UwTasSaB7RqcG lTHpblhTBkFQ808uxtRAtxNQJ6kX3VEEwkMV+mHX3sw2UHi1KbL+ym+AowwhCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779305882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q6QM6nU4eRrQLkOJO21tz4OKzA5F01UySDHO6BrK6jw=; b=TuH+I7xh3k6J922FOvqbhAKSnHFBf9XzQz3X6ZB9bOgUZ0luIJi00DSsberEwa+cVxX4pP bBbgImbFq+V8Ml8XVJoC01o2rifQbIfg9+vIWEEjCmLAPSFy4HAeWnSWEm9E3yooFzxuL6 zTDy8erACgY1MRwi6OkIuYlwGYI74mBcl0Ea+NzZ0kT27sO9bRliV1TZJfNpU7AjVRPn42 P8Lo7LQvTBEtYWCnFPyOVbMIJ+ndTVyw3MM7J9JanXFWfMJPGapZ9D97aVzFA3S7hNuGjI PSQbWGX5pQLYFFNnah8XsrdFjw+YhNREbro01uTE7SduF6B7AnFLhhS8u3lUVA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gLMJp4zWlz1DXl for ; Wed, 20 May 2026 19:38:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39215 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 20 May 2026 19:38:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 183726934845 - stable/14 - bsdinstall: Avoid invoking eval on the wlan SSID list List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1837269348458ade7042625ee7be180734f2c586 Auto-Submitted: auto-generated Date: Wed, 20 May 2026 19:38:02 +0000 Message-Id: <6a0e0d9a.39215.51a4ef7a@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=1837269348458ade7042625ee7be180734f2c586 commit 1837269348458ade7042625ee7be180734f2c586 Author: Mark Johnston AuthorDate: 2026-05-12 14:13:56 +0000 Commit: Mark Johnston CommitDate: 2026-05-20 19:37:14 +0000 bsdinstall: Avoid invoking eval on the wlan SSID list The wlanconfig utility is not careful about handling untrusted network names, which can contain shell metacharacters. Factor network selection into a subroutine and use the `set -- "$@"` trick to build up a list of positional parameters for bsddialog without evaluating them. Approved by: so Security: FreeBSD-SA-26:23.bsdinstall Security: CVE-2026-45255 Reported by: Austin Ralls Reviewed by: dteske, des, asiciliano Differential Revision: https://reviews.freebsd.org/D56973 --- usr.sbin/bsdinstall/scripts/wlanconfig | 47 ++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/usr.sbin/bsdinstall/scripts/wlanconfig b/usr.sbin/bsdinstall/scripts/wlanconfig index 33d94a933f45..aababf76c266 100755 --- a/usr.sbin/bsdinstall/scripts/wlanconfig +++ b/usr.sbin/bsdinstall/scripts/wlanconfig @@ -147,6 +147,34 @@ dialog_country_select() country_set "$regdomain" "$country" } +dialog_network_select() +{ + local ssid flags height width rows prompt + + # Avoid using eval on untrusted data. + set -- + while IFS=$'\t' read -r ssid flags; do + [ -n "$ssid" ] || continue + set -- "$@" "$ssid" "$flags" + done <&1 >&$DIALOG_TERMINAL_PASSTHRU_FD +} + ############################################################ MAIN : > "$BSDINSTALL_TMPETC/wpa_supplicant.conf" @@ -213,27 +241,14 @@ while :; do f_eval_catch -dk SCAN_RESULTS wlanconfig wpa_cli "wpa_cli scan_results" NETWORKS=$( echo "$SCAN_RESULTS" | awk -F '\t' ' - /..:..:..:..:..:../ && $5 { printf "\"%s\"\t\"%s\"\n", $5, $4 } + /..:..:..:..:..:../ && $5 { print $5 "\t" $4 } ' | sort | uniq ) if [ ! "$NETWORKS" ]; then f_dialog_title "$msg_error" f_yesno "No wireless networks were found. Rescan?" && continue else - f_dialog_title "Network Selection" - prompt="Select a wireless network to connect to." - f_dialog_menu_size height width rows "$DIALOG_TITLE" \ - "$DIALOG_BACKTITLE" "$prompt" "" $NETWORKS - NETWORK=$( eval $DIALOG \ - --title \"\$DIALOG_TITLE\" \ - --backtitle \"\$DIALOG_BACKTITLE\" \ - --extra-button \ - --extra-label \"Rescan\" \ - --menu \"\$prompt\" \ - $height $width $rows \ - $NETWORKS \ - 2>&1 >&$DIALOG_TERMINAL_PASSTHRU_FD - ) + NETWORK=$( dialog_network_select ) fi retval=$? f_dialog_data_sanitize NETWORK @@ -270,7 +285,7 @@ while :; do done [ "$ENCRYPTION" ] || ENCRYPTION=$( echo "$NETWORKS" | - awk -F '\t' "/^\"$NETWORK\"\t/ { print \$2 }" ) + awk -F '\t' "/^$NETWORK\t/ { print \$2 }" ) if echo "$ENCRYPTION" | grep -q PSK; then PASS=$( $DIALOG \