From nobody Tue May 19 15:49:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gKfJ54JDDz6fNMJ; Tue, 19 May 2026 15:49:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gKfJ52H7Lz440w; Tue, 19 May 2026 15:49:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779205797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5TrzdVFcyjzqgmN9BeOcEcsjr6qsBT3Rv+tlGd26iU4=; b=mqhiTax2TTqAbwDpquTLJj+iW7kV2kw01bNi4Fs4NYr2K1SVoFxdTBsoarzq9OJZciqs6G FGoR/jCrQrHqJXKScQnjHsJOyI/sPsG2rdwE6O92B71XaoaxzcQNqU0HOO4+4oAKerhlMm bqHEulgy13Wm4uxfccnCMRDlKCca+VN/ap07G6vJRq6Tsp433nZ70OnRo76pqDnAQDlBzA 3GFubfxEBivjL/ok3SNiCvpLu8oDBjYW3KFoDVP13uZCNgABG3XV5O0PKOEUsMOFu6cRzQ 27YYKrqy791wQCnYXQwbeoXVmd7anwaRctljBQ3qWEa6+AYBHaT4vGuGJ1Hhzg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779205797; a=rsa-sha256; cv=none; b=DWBSQjKbEUPOyNNIgjitDQt3LnOofBBqCRxLSxboc5nZxMfS1MB9hEpHW71ziK2b7SQhbK hL5mAko8AV8JTf9nDXyOTG6K+SvLklym3xTBSLycOoo9TlAuoha1Japi8MqjjCaXKP+IUN RQ7k6r/NjEINaOtEmCv1e6ilKrzo35zVsee18splkRudQs3W8H6C43edPjnKjb1mqGIBn+ m/I04D706k5FIz3pt0LSR0UnxE4lgnza98SXjfrFiOoYnq9AfIlHf1Kqa/VLdUIdg2WYVe xG9LUMYBK6AWAp2R0hiRZy+mUmWBNc90i5caljRKSwK2MQT7chDnt8Wg1iTGqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779205797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5TrzdVFcyjzqgmN9BeOcEcsjr6qsBT3Rv+tlGd26iU4=; b=kHoQqc2jREAG8PF/8RdjXymE7sGK7FsoVVzIOIebx2fQB1/Uhs9y4kOwOdL008DcrRXaG8 N6T/mynCyFAs1JrTvSLEGcacvniTOOvpq+b3MuYR1PEaBJn5vdBh6Kux+v+dAQ8F/G/vuh llS4aEpYdwPVYcJ1scE+t08ZRa0B7znB4l1x9WTErqqdbo6AlH6Ik9Oc7XdlQQ205ogpzt nS1xLMJ3nGX6AwN1p7uF/dk3Qr8HHR9bqpvp9dWFcA8LsHWweryQNMFpAxKF9ncBqEOsw8 X/QMqdvm08tCtCf1XBTVV0p8UoD2XxbAYe2p/Zx8qJSgK9zGxrkBdUFhF+35+g== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gKfJ50kTzzFdY; Tue, 19 May 2026 15:49:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 2689FA64805; Tue, 19 May 2026 15:49:31 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 6723D2D029E9; Tue, 19 May 2026 15:49:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 3_DDzXiupDGo; Tue, 19 May 2026 15:49:54 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 770B22D029D8; Tue, 19 May 2026 15:49:54 +0000 (UTC) Date: Tue, 19 May 2026 15:49:51 +0000 (UTC) From: "Bjoern A. Zeeb" To: src-committers@FreeBSD.org cc: dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e56f7becc7ef - main - iwx: clean up / document noise floor and RSSI fetching In-Reply-To: <6a0bf889.1e29a.6f1dfea2@gitrepo.freebsd.org> Message-ID: References: <6a0bf889.1e29a.6f1dfea2@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 19 May 2026, Adrian Chadd wrote: > The branch main has been updated by adrian: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e56f7becc7efe05acbb08162961dca574b152720 > > commit e56f7becc7efe05acbb08162961dca574b152720 > Author: Adrian Chadd > AuthorDate: 2025-11-16 03:13:59 +0000 > Commit: Adrian Chadd > CommitDate: 2026-05-19 05:27:59 +0000 > > iwx: clean up / document noise floor and RSSI fetching > > * Document what iwx_rxmq_get_signal_strength() is doing in a comment, > noting what the firmware returns and what math is being done on it > to turn it into a dBm value. > > * Document what iwx_get_noise() is supposed to do, that we can't just > go do math with log numbers like we're doing, but also that we're > seeing zeros in this firmware (AX210), which may mean we're decoding > using the wrong structs. > > * Swizzle around the RSSI calculation as a function, add min/max RSSI > values, and calculate RSSI against the noise floor. > > * And handle the lowest noise floor value - it can't be -127dBm as > that will throw things off. Cap it at -100dBm which is a little > lower than the thermal noise floor at 20MHz (-98dBm), but it matches > IWX_MIN_DBM. > > Differential Revision: https://reviews.freebsd.org/D53780 Given some comments remained 1:1 the same: initially based on https://reviews.freebsd.org/D50929 > --- > sys/dev/iwx/if_iwx.c | 83 ++++++++++++++++++++++++++++++++++++++++++------- > sys/dev/iwx/if_iwxreg.h | 17 ++++++++++ > 2 files changed, 89 insertions(+), 11 deletions(-) -- Bjoern A. Zeeb r15:7