From nobody Tue May 19 00:43:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gKGBF1Nlpz6d7Q3 for ; Tue, 19 May 2026 00:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gKGBF0J8cz4DC7 for ; Tue, 19 May 2026 00:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779151413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=96BhgOmD0GYyVm3TiP/qf7onmMVMy4xNXVK95o3jKmE=; b=p0GvwTXqsDctlL+LVdDnC7LFllmKQe29z+3oqA8Irlobfj8tNk97KcLo/y+kyY1LVMVTE2 9zrqoLN1XWyLDKXTvXBEWrVlv+8bc/g6VKKuRFlPsPekTZVpdpFtGiTpdNxFosPTwlDMUn +lEjhkmAqbQ7b1VPvYEyTqXtRlOSg+HlST4XhfY6XFbesGnhXMUbXjlmmOYQHVzhPgeoBv S0oPYgLxZOXEr8ehdNN2GiFEqbcMGR0zm/5i6+1vBHgUVhHHsO2JhjDKZYm4DNNv1UXBdR 4sU4QcQXvl9ldbveSCazwje3auAO5joWs4DR3opdLjkMEtt16p4F60sboW20IQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779151413; a=rsa-sha256; cv=none; b=JpWqSpl9YmINaiLxcqwRuyF+IzCpq1INKaCkkPeuQs625Cj+7IQny5D9nV/QICrB19LTUd 1BY55AIQEAzyEpFrr+irUSigr9/FpEbQdPEoKnpLmDOMrUhwW8GR1w+2MKI0/NMkRB8Qw7 0gWjCNjW5bmrua6RzeXUciXpSqh+XC4hliD4fM8YAoRZc2+AY57BxY737KG89JqNpUYCJw PbTzoK1lBGIvoZn/Qbb6fEYN69uBDwmYz7byoDmHuYrfqRfLDr6OK8uhWWmOciGP5sXtCz 5PKdlFv4DfBA9CnP/SG7HJJhS4Exhd3jnXNYMf4/ib7Fnsqw6Wes8D1H/lsWHg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779151413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=96BhgOmD0GYyVm3TiP/qf7onmMVMy4xNXVK95o3jKmE=; b=mi43Lr20G8zkPiYQ43Ro9+iUO8UeV3J5Xz5EXQW/gulqG7oBwLJSX6m6ScFLPi/E1FyZ6s aeIUa0QJ/1x80A1PR7qQ79scDAY5euOQJ0qLhFg+KzQxKZgvKf6tWliRlsdr6lqofjSjGh RVvqC+x+JUIGGqwBmMTolkLZiG7llOI7YEOCMy+Sf++PITSdcxZoEn9MixbsyfGqlK2yTh TYK5XaGfZzwDL0+Nucqu3iA9a9Hlo1+9+7cMn+49v+UztrW7rupipW0opeJuxoEs6W3cga Y2L6l0pWsqkIWRxb9vcQwK4gvXoCqmf4k0GQEgHhYANTDsUjqj4MGs8DTh8Viw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gKGBD6xfvzrjF for ; Tue, 19 May 2026 00:43:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26f88 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 19 May 2026 00:43:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 85afe03ac3de - stable/15 - Remove -fms-extensions throughout the tree List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 85afe03ac3de79a29973ff9d5e5a96bc05db251c Auto-Submitted: auto-generated Date: Tue, 19 May 2026 00:43:32 +0000 Message-Id: <6a0bb234.26f88.4d25d996@gitrepo.freebsd.org> The branch stable/15 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=85afe03ac3de79a29973ff9d5e5a96bc05db251c commit 85afe03ac3de79a29973ff9d5e5a96bc05db251c Author: Bjoern A. Zeeb AuthorDate: 2026-02-03 01:51:40 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-05-19 00:43:13 +0000 Remove -fms-extensions throughout the tree During a discussion about using -fms-extensions jhb pointed out that we have them enabled in the kernel for gcc by default (even multiple times in one part). I had missed all that and clang still failed on my use case (needing another option). The original cause for enabling them for our tree back then was that we needed to support C11 anonymous struct/unions. Our in-tree gcc 4.2.1, despite later patches, needed the -fms-extensions to support these even though this was not the expected use case for that option ( cc4a90c445aa0 enabled it globally for the kernel). clang at that time (or at least when it became default for 10.0) already was fine (with C11). Any later gcc (4.6.0 onwards) did not need that option anymore, even when compiled for -std=iso9899:1990 (which does not support anonymous structs/unions) unless one would add -pedantic (see gcc git 4bdd0a60b27a). This is also the reason why userland cddl sources now compile with the option removed despite CSTD=c99. The only driver which needed the option recently was ccp, but that was fixed in 8d3f41dbcb2a by jhb. So cleanup all uses cases of -fms-extensions for the moment as they are no longer needed given all compilers currently supported seem to be fine without them and gcc-4.2.1 was removed from the tree in stable/13 in 2020 (a9854bc3812b). Reported by: jhb (all this but possibly the world CDDL parts) Sponsored by: The FreeBSD Foundation Reviewed by: emaste (earlier), imp, jhb, glebius Differential Revision: https://reviews.freebsd.org/D55072 (cherry picked from commit 93d301d95ab230ea159b21b5412aac2ce5362ac5) --- cddl/lib/libzpool/Makefile | 1 - cddl/usr.bin/ztest/Makefile | 1 - cddl/usr.sbin/zdb/Makefile | 1 - sys/conf/kern.pre.mk | 3 +-- sys/conf/kmod.mk | 1 - sys/modules/iser/Makefile | 1 - sys/modules/pms/Makefile | 1 - sys/powerpc/conf/dpaa/config.dpaa | 2 +- 8 files changed, 2 insertions(+), 9 deletions(-) diff --git a/cddl/lib/libzpool/Makefile b/cddl/lib/libzpool/Makefile index 82ec0e890d56..407159a85255 100644 --- a/cddl/lib/libzpool/Makefile +++ b/cddl/lib/libzpool/Makefile @@ -283,7 +283,6 @@ CFLAGS+= -DWANTS_MUTEX_OWNED CFLAGS+= -I${SRCTOP}/lib/libpthread/thread CFLAGS+= -I${SRCTOP}/lib/libpthread/sys CFLAGS+= -I${SRCTOP}/lib/libthr/arch/${MACHINE_CPUARCH}/include -CFLAGS.gcc+= -fms-extensions LIBADD= md pthread z spl icp nvpair avl umem diff --git a/cddl/usr.bin/ztest/Makefile b/cddl/usr.bin/ztest/Makefile index ef4bd561b41a..cb51b5110f03 100644 --- a/cddl/usr.bin/ztest/Makefile +++ b/cddl/usr.bin/ztest/Makefile @@ -29,7 +29,6 @@ CSTD= c99 # Since there are many asserts in this program, it makes no sense to compile # it without debugging. CFLAGS+= -g -DDEBUG=1 -Wno-format -DZFS_DEBUG=1 -CFLAGS.gcc+= -fms-extensions HAS_TESTS= SUBDIR.${MK_TESTS}+= tests diff --git a/cddl/usr.sbin/zdb/Makefile b/cddl/usr.sbin/zdb/Makefile index 7d1e41e1690e..ad6e63f428a3 100644 --- a/cddl/usr.sbin/zdb/Makefile +++ b/cddl/usr.sbin/zdb/Makefile @@ -25,7 +25,6 @@ CFLAGS+= \ LIBADD= nvpair umem uutil zdb zfs_core zfs spl avl zutil zpool crypto -CFLAGS.gcc+= -fms-extensions # Since there are many asserts in this program, it makes no sense to compile # it without debugging. CFLAGS+= -g -DDEBUG=1 -DZFS_DEBUG=1 diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk index 0251486247da..5bbd1ec70cd3 100644 --- a/sys/conf/kern.pre.mk +++ b/sys/conf/kern.pre.mk @@ -78,10 +78,9 @@ CFLAGS= ${COPTFLAGS} ${DEBUG} CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h CFLAGS_PARAM_INLINE_UNIT_GROWTH?=100 CFLAGS_PARAM_LARGE_FUNCTION_GROWTH?=1000 -CFLAGS.gcc+= -fms-extensions -finline-limit=${INLINE_LIMIT} +CFLAGS.gcc+= -finline-limit=${INLINE_LIMIT} CFLAGS.gcc+= --param inline-unit-growth=${CFLAGS_PARAM_INLINE_UNIT_GROWTH} CFLAGS.gcc+= --param large-function-growth=${CFLAGS_PARAM_LARGE_FUNCTION_GROWTH} -CFLAGS.gcc+= -fms-extensions .if defined(CFLAGS_ARCH_PARAMS) CFLAGS.gcc+=${CFLAGS_ARCH_PARAMS} .endif diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk index b5e30d48fff1..b466dca4f0e4 100644 --- a/sys/conf/kmod.mk +++ b/sys/conf/kmod.mk @@ -139,7 +139,6 @@ CFLAGS+= -include ${.OBJDIR}/opt_global.h CFLAGS+= -I. -I${SYSDIR} -I${SYSDIR}/contrib/ck/include CFLAGS.gcc+= -finline-limit=${INLINE_LIMIT} -CFLAGS.gcc+= -fms-extensions CFLAGS.gcc+= --param inline-unit-growth=100 CFLAGS.gcc+= --param large-function-growth=1000 diff --git a/sys/modules/iser/Makefile b/sys/modules/iser/Makefile index 615199ec97a3..fadb0894ac85 100644 --- a/sys/modules/iser/Makefile +++ b/sys/modules/iser/Makefile @@ -19,7 +19,6 @@ CFLAGS+= -I${SYSDIR}/ofed/include/uapi CFLAGS+= ${LINUXKPI_INCLUDES} CFLAGS+= -DCONFIG_INFINIBAND_USER_MEM CFLAGS+= -DINET6 -DINET -CFLAGS+= -fms-extensions CFLAGS+=-DICL_KERNEL_PROXY diff --git a/sys/modules/pms/Makefile b/sys/modules/pms/Makefile index 8bd21fc4b502..81599e0a3ceb 100644 --- a/sys/modules/pms/Makefile +++ b/sys/modules/pms/Makefile @@ -17,7 +17,6 @@ ${SRCTOP}/sys/dev/pms/freebsd/driver/common CFLAGS+=-fno-builtin -CFLAGS+=-fms-extensions CFLAGS+=-Wredundant-decls CFLAGS+=-Wunused-variable diff --git a/sys/powerpc/conf/dpaa/config.dpaa b/sys/powerpc/conf/dpaa/config.dpaa index 6a923baed894..0b7c8fcf3b29 100644 --- a/sys/powerpc/conf/dpaa/config.dpaa +++ b/sys/powerpc/conf/dpaa/config.dpaa @@ -2,7 +2,7 @@ files "dpaa/files.dpaa" makeoptions DPAA_COMPILE_CMD="${LINUXKPI_C} ${DPAAWARNFLAGS} \ - -Wno-cast-qual -Wno-unused-function -Wno-init-self -fms-extensions \ + -Wno-cast-qual -Wno-unused-function -Wno-init-self \ -include $S/contrib/ncsw/build/dflags.h \ -Wno-error=missing-prototypes \ -I$S/contrib/ncsw/build/ \