From nobody Sat May 16 23:24:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gJ0X10xjfz6dGfN for ; Sat, 16 May 2026 23:24:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gJ0X10KDyz45q5 for ; Sat, 16 May 2026 23:24:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778973873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jd9NqqUomoOxEJKxnACsAaQeHX9d4dku61FGCZZcbNI=; b=Gp+4YsS1tJx/ksONETmzqfZZneDTTiR0xEAsfGEjSfn4iWYZ0/SbeS7poeZ9Q06HDohFB8 1vdSTA40X3v/QVDvx1itxEnBNaoXq2gaubZ/mwsjNpknVKKSTmD6hB0NQHdYWITC/T/BPu bVaLjDouHKb0RIv3gqF0OuDddtqEm8yibjo0iKM1/mLjGuJ6JL32c3325M/qeBpwBXOLJl K7GIZdLCCkuPHzed0TmMNHLBesNElOdVBlk824bvgmNykbEvNJmYJeBzCUsM3epOp1OS1t pKB1cAxtYBSGABmePHzWXiu0awVb2/x70NdlszhPkeRl8RNvGRPkWUbvZcGQmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778973873; a=rsa-sha256; cv=none; b=MnZuuB6qPZqC/bXk/vLgi0DFjXqwXD4iRgNTTRAjOHAsbLodrl9ZhLdRff8lAqFhhM/pjL RQz8nbrZE9Daix9LYIi7lg0Of6MFIXAlt2ChO2Lt/B1+IGKOZqWByDLQW1KCl6LfEhfSOL QutW/2rqEKMrQukQNSLhpn2D3CnRKrX3JujpetdyuazgETCmPL+UYjYr+FtfP09ni7J9DB DYou5x2jAP5bGDAiPMcekWXBCD8yLwXFug7eCZcQwaDa6oepoPdbhjnO1KrkoGjsuN/WW7 pXnAGJLVxI1FfIRJWJjENYISH9IdlB/TJqo1Ep3yCwFWPPOQa4VrEIItn1bLpw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778973873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jd9NqqUomoOxEJKxnACsAaQeHX9d4dku61FGCZZcbNI=; b=AHo6i7hqX1MNd4+jODTqiWc+lQJcXgT1ch5wCQernDZ/ItUvG1BUOcavEvCRXc3p+CjeAQ EgdwgIAYVbyXyatJ1zLquiPQmfe3V9Bxa8umxzj4MJ1jz2vSBsVDZbXOIEHMoJR1WX4CbM dlzLtSH1xa3Akg3nCQEVy12ZVW1QmL7okMAoUYHRpp+ay9Mho5V5+o5EFN744BHG7P3MYr Ors7Jf/WXmzcfWCxIXDUtJ9d6b8w7O8MjLfbA7V5Z8k6t3e4Y7QKtlmEYC3+xw99SH4yks OAbCQBqvaxIHx6ZAe/SMnh9NHNtdDScE7/4R3fMkSL8hg4jlDN8FRzAKPFEmZA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gJ0X06xTTz1Dx for ; Sat, 16 May 2026 23:24:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c6f7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 16 May 2026 23:24:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 43a8585cb2bb - main - sys/mount.h: restore KNF_NOKQLOCK in VFS_KNOTE_{,UN}LOCKED() call to KNOTE() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 43a8585cb2bb0e284df672174a57780e53107d27 Auto-Submitted: auto-generated Date: Sat, 16 May 2026 23:24:27 +0000 Message-Id: <6a08fcab.1c6f7.2f21ecdb@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=43a8585cb2bb0e284df672174a57780e53107d27 commit 43a8585cb2bb0e284df672174a57780e53107d27 Author: Konstantin Belousov AuthorDate: 2026-05-16 19:11:43 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-16 23:24:10 +0000 sys/mount.h: restore KNF_NOKQLOCK in VFS_KNOTE_{,UN}LOCKED() call to KNOTE() ZFS needs to take internal sleepable lock in its implementation of VOP_GETATTR(). Due to this, kq must be unlocked around calls to the vfs filter methods. Fixes: 1d5e4020e36e ("vnode: add VIRF_KNOTE flag") Reported and tested by: des Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/sys/mount.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/sys/mount.h b/sys/sys/mount.h index d6696bba0a4f..2e880bac9068 100644 --- a/sys/sys/mount.h +++ b/sys/sys/mount.h @@ -968,8 +968,8 @@ static inline void VFS_KNOTE_LOCKED(struct vnode *vp, int hint) { if ((vn_irflag_read(vp) & VIRF_KNOTE) != 0) { - KNOTE_LOCKED(&vp->v_pollinfo->vpi_selinfo.si_note, - hint); + KNOTE(&vp->v_pollinfo->vpi_selinfo.si_note, + hint, KNF_LISTLOCKED | KNF_NOKQLOCK); } } @@ -977,8 +977,8 @@ static inline void VFS_KNOTE_UNLOCKED(struct vnode *vp, int hint) { if ((vn_irflag_read(vp) & VIRF_KNOTE) != 0) { - KNOTE_UNLOCKED(&vp->v_pollinfo->vpi_selinfo.si_note, - hint); + KNOTE(&vp->v_pollinfo->vpi_selinfo.si_note, + hint, KNF_NOKQLOCK); } }