From nobody Fri May 15 23:38:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gHNtD05HTz6cRf6; Fri, 15 May 2026 23:38:12 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gHNtC59Btz3mw4; Fri, 15 May 2026 23:38:11 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778888291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7OcPsjbAw4fo5SvzY5/g5GO/iQUg0WivsVMkc2Ema2A=; b=i2o6kuYtKAz2KJ99RLpKutbSciP7txNxm7DoX6OwLNtATxKV1yMrs8P/9Z+1SdHjdShAi7 kyu7e3vNMqgjizDLLkl/neN6UTUkXfpIXzktKSRRCaIHtyq4x9REVbwALZbkv8wsCRtfmY sOfsAj84sgcM35Lxr094lKTCGGMMKbvjx6K913rrp/58EEnNfLMHQn2MOReemTXYhf5xnk 1P5xjBVQqVf9HvMUUK24ko6w6pogujI828SAVnD3gU34zf9N66JUeZQ8Nnh+TCvGl2QAzX aFdpFmvp+u+7ulBetXbimZs2i4ECoakd+ahvibXWLuu1b/irRlSWTTslM+gMRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778888291; a=rsa-sha256; cv=none; b=ct+wKHIOvEip54Mx8bKJXwCXrkLA+fH3BDagYzqLJDhoG7FBCu4LmLGYhMUyVjf+AfEjU5 Cn5201I7+6H54tTcoFIVlUjeXnE3mYFfYntwokAKl1oyDfEukNTPXF+GLcOGYIZR1P51PZ SjFYGhakYRWuJlcuTI6ynisUdP/QLsBa7Mey53aXcnSVqpaWXo8QkLQDssRnHCkQ+UoXFp tOmLcTXrWAuHLjwyoPGHF1q/2LnbPV6Hk7s3oYwHeUUm0yOg0+t5o8JOO4tXlmXL22VwiA Gc1JgqOKaW/gLTqE2pbsW1ZTvpNlCXf78mxXzahFpU5K6YDmP7V6ljjWB1hzqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778888291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7OcPsjbAw4fo5SvzY5/g5GO/iQUg0WivsVMkc2Ema2A=; b=S4aP7tiJc7rqHjQeJzGnaLHYYgQbHIAbu827BOyVukBLkNsKqBMK+dyZw+rm9Jduz4Elx3 FCfGUcbTBwi0k6fqCDJuIdD6UklydtSErzHW9cOYD1BQRhY6qpG9cDV+aFdzhDb35v6uU+ T6Yv6eAahUbQUbM0rsInhxjd1ESnJqe66MRCNOB4NWDEVBdREOPv9pgda8Jb1tXT1qaUWP 0j+r4echCQl5bvGApkontkzeySNRUZ1wKIvvlWELA888im8HzbqpRoUIfO6ze5JFWln8bv M7y3i55TUQPdu3HRkeG/y188s25Cspv79wOxeuWBBw1s5Q8i40NpYNJexgbCnw== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gHNtC2xZpzjxy; Fri, 15 May 2026 23:38:11 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id A62BDA64806; Fri, 15 May 2026 23:37:45 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id B3FEB2D029EC; Fri, 15 May 2026 23:38:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id U5oLsYKqq_2R; Fri, 15 May 2026 23:38:08 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 5B5CD2D029D8; Fri, 15 May 2026 23:38:08 +0000 (UTC) Date: Fri, 15 May 2026 23:38:08 +0000 (UTC) From: "Bjoern A. Zeeb" To: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 70fde0ed6bbb - main - md5: Encode non-printable filenames In-Reply-To: <69f250e0.37a65.1d7c90ca@gitrepo.freebsd.org> Message-ID: <95sp1227-9sp1-60q4-3qp6-4r598q63o152@mnoonqbm.arg> References: <69f250e0.37a65.1d7c90ca@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-493607577-1778888288=:11296" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-493607577-1778888288=:11296 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 29 Apr 2026, Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav wrote: > The branch main has been updated by des: > > URL: https://cgit.FreeBSD.org/src/commit/?id=70fde0ed6bbbb1f84c440190ba1e5435f8c90e13 > > commit 70fde0ed6bbbb1f84c440190ba1e5435f8c90e13 > Author: Dag-Erling Smørgrav > AuthorDate: 2026-04-29 18:41:05 +0000 > Commit: Dag-Erling Smørgrav > CommitDate: 2026-04-29 18:41:05 +0000 > > md5: Encode non-printable filenames > > Encode filenames in the VIS_CSTYLE | VIS_OCTAL style regardless of > output mode. When reading filenames from a checksum file, attempt to > decode them, and use the decoded name unless the decoded name does not > exist but the undecoded one does. > > This breaks compatibility with GNU coreutils, which unfortunately uses > a non-reversible encoding when outputting filenames containing > non-printable characters. > > While here, drop a sentence about preimage attacks against MD5 and SHA1 > from the manual page, as I no longer trust it to be true. > > MFC after: 1 week > Reviewed by: bcr, markj > Differential Revision: https://reviews.freebsd.org/D56615 > --- > sbin/md5/md5.1 | 30 ++++++++++++++++++++++-------- > sbin/md5/md5.c | 41 +++++++++++++++++++++++++++++++++++------ > 2 files changed, 57 insertions(+), 14 deletions(-) This breaks make makesum and related in ports for, e.g., filenames/URLs which have a '?' in them. If you, on an updated system, run make makesum in net/wifi-firmware-rtw88-kmod for example, you can see that the '?' are now quoted for the SHA256 lines while they were not previously. -TIMESTAMP = 1765584880 -SHA256 (linux-firmware/rtw88fw/rtw88/rtw8703b_fw.bin?h=20251125) = 5e32bd891c74a0719c871726b74490cf5e1a05cdcefb8fe2414f80fffdeb9f9d +TIMESTAMP = 1778888000 +SHA256 (linux-firmware/rtw88fw/rtw88/rtw8703b_fw.bin\?h=20251125) = 5e32bd891c74a0719c871726b74490cf5e1a05cdcefb8fe2414f80fffdeb9f9d SIZE (linux-firmware/rtw88fw/rtw88/rtw8703b_fw.bin?h=20251125) = 20290 -SHA256 (linux-firmware/rtw88fw/rtw88/rtw8703b_wow_fw.bin?h=20251125) = 7156b0d2b4580e63d11a3a78258c35ff28e840c7c6428953920ae6a1cd5d05ac +SHA256 (linux-firmware/rtw88fw/rtw88/rtw8703b_wow_fw.bin\?h=20251125) = 7156b0d2b4580e63d11a3a78258c35ff28e840c7c6428953920ae6a1cd5d05ac SIZE (linux-firmware/rtw88fw/rtw88/rtw8703b_wow_fw.bin?h=20251125) = 23074 -SHA256 (linux-firmware/rtw88fw/rtw88/rtw8723d_fw.bin?h=20251125) = 9c64e079815a333a3f7b731be7cc0be65206ebc883891659dc8ff5ed36a5e2f5 +SHA256 (linux-firmware/rtw88fw/rtw88/rtw8723d_fw.bin\?h=20251125) = 9c64e079815a333a3f7b731be7cc0be65206ebc883891659dc8ff5ed36a5e2f5 SIZE (linux-firmware/rtw88fw/rtw88/rtw8723d_fw.bin?h=20251125) = 28884 -SHA256 (linux-firmware/rtw88fw/rtw88/rtw8812a_fw.bin?h=20251125) = abdcca4e8bf76ebfba23d433de310ffefebd0ff9d01990639d4cd9602b32b71a +SHA256 (linux-firmware/rtw88fw/rtw88/rtw8812a_fw.bin\?h=20251125) = abdcca4e8bf76ebfba23d433de310ffefebd0ff9d01990639d4cd9602b32b71a SIZE (linux-firmware/rtw88fw/rtw88/rtw8812a_fw.bin?h=20251125) = 27030 -SHA256 (linux-firmware/rtw88fw/rtw88/rtw8814a_fw.bin?h=20251125) = aa6bf9d62b2d2d8a37254fd6d917ba2839888cdedc21850d4481874cb1d3d7cb +SHA256 (linux-firmware/rtw88fw/rtw88/rtw8814a_fw.bin\?h=20251125) = aa6bf9d62b2d2d8a37254fd6d917ba2839888cdedc21850d4481874cb1d3d7cb SIZE (linux-firmware/rtw88fw/rtw88/rtw8814a_fw.bin?h=20251125) = 68320 -SHA256 (linux-firmware/rtw88fw/rtw88/rtw8821a_fw.bin?h=20251125) = 4693ece655044d96f81bd3f3e8db14dc352b493219c4fd0a75788a6fbd9eac3c +SHA256 (linux-firmware/rtw88fw/rtw88/rtw8821a_fw.bin\?h=20251125) = 4693ece655044d96f81bd3f3e8db14dc352b493219c4fd0a75788a6fbd9eac3c SIZE (linux-firmware/rtw88fw/rtw88/rtw8821a_fw.bin?h=20251125) = 31898 ... That then results in trying to build the port: => No SHA256 checksum recorded for linux-firmware/rtw88fw/rtw88/rtw8703b_fw.bin?h=20251125. => No suitable checksum found for linux-firmware/rtw88fw/rtw88/rtw8703b_fw.bin?h=20251125. => No SHA256 checksum recorded for linux-firmware/rtw88fw/rtw88/rtw8703b_wow_fw.bin?h=20251125. => No suitable checksum found for linux-firmware/rtw88fw/rtw88/rtw8703b_wow_fw.bin?h=20251125. => No SHA256 checksum recorded for linux-firmware/rtw88fw/rtw88/rtw8723d_fw.bin?h=20251125. => No suitable checksum found for linux-firmware/rtw88fw/rtw88/rtw8723d_fw.bin?h=20251125. ... -- Bjoern A. Zeeb r15:7 --0-493607577-1778888288=:11296--