Re: git: 8766e2122ac0 - main - mandoc: Updating FreeBSD thead library descriptions

On Thu, May 14, 2026 at 02:56:38PM -0400, John Baldwin wrote:
> On 5/13/26 22:47, Konstantin Belousov wrote:
> > On Wed, May 13, 2026 at 04:34:25PM +0000, John Baldwin wrote:
> > > The branch main has been updated by jhb:
> > > 
> > > URL: https://cgit.FreeBSD.org/src/commit/?id=8766e2122ac02ff4d86c254d8ef1c41d4a7f76a0
> > > 
> > > commit 8766e2122ac02ff4d86c254d8ef1c41d4a7f76a0
> > > Author:     John Baldwin <jhb@FreeBSD.org>
> > > AuthorDate: 2026-05-13 16:33:29 +0000
> > > Commit:     John Baldwin <jhb@FreeBSD.org>
> > > CommitDate: 2026-05-13 16:33:29 +0000
> > > 
> > >      mandoc: Updating FreeBSD thead library descriptions
> > >      Remove libkse as it has been obsolete for many years and drop 1:1 from
> > >      description of libthr.
> > >      Reviewed by:    brooks
> > >      Sponsored by:   AFRL, DARPA
> > >      Differential Revision:  https://reviews.freebsd.org/D56850
> > > ---
> > >   contrib/mandoc/lib.in | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/contrib/mandoc/lib.in b/contrib/mandoc/lib.in
> > > index dcea23cf81ea..04d86f9add1e 100644
> > > --- a/contrib/mandoc/lib.in
> > > +++ b/contrib/mandoc/lib.in
> > > @@ -74,7 +74,6 @@ LINE("libisns",		"Internet Storage Name Service Library (libisns, \\-lisns)")
> > >   LINE("libjail",		"Jail Library (libjail, \\-ljail)")
> > >   LINE("libkcore",	"Kernel Memory Core Access Library (libkcore, \\-lkcore)")
> > >   LINE("libkiconv",	"Kernel-side iconv Library (libkiconv, \\-lkiconv)")
> > > -LINE("libkse",		"N:M Threading Library (libkse, \\-lkse)")
> > >   LINE("libkvm",		"Kernel Data Access Library (libkvm, \\-lkvm)")
> > >   LINE("libm",		"Math Library (libm, \\-lm)")
> > >   LINE("libm68k",		"m68k Architecture Library (libm68k, \\-lm68k)")
> > > @@ -126,7 +125,7 @@ LINE("libtacplus",	"TACACS+ Client Library (libtacplus, \\-ltacplus)")
> > >   LINE("libtcplay",	"TrueCrypt-compatible API library (libtcplay, \\-ltcplay)")
> > >   LINE("libtermcap",	"Termcap Access Library (libtermcap, \\-ltermcap)")
> > >   LINE("libterminfo",	"Terminal Information Library (libterminfo, \\-lterminfo)")
> > > -LINE("libthr",		"1:1 Threading Library (libthr, \\-lthr)")
> > > +LINE("libthr",		"Threading Library (libthr, \\-lthr)")
> > Arguably the suggested linker argument should be -lpthread instead.
> 
> I think there is a "libpthread" entry already and we could just use
> that in our manpages going forward instead of .Lb libthr which would
> have that effect. Actually, .Lib libthr is only used in a few places,
> and several of those could either be removed (e.g. the IMPLEMENTATION
> NOTES section in pthread(3) can probably just be removed, it was more
> relevant when there were multiple libraries) or updated (_umtx_op.2
> can just reference libpthread instead of libthr).
We do have libthr(3), and it should not be dropped.  The reference from
pthread(3) to libthr(3) in its current form IMO makes sense.

What I mean is only to stop suggesting in any way to link against libthr.so,
instead of libpthread.so. I do not envision that we ever would bump libthr
major version number, but libpthread.so might become linker script instead
of the symlink.

>
> It's not clear to me if there is true value in renaming the real
> library, though if we ever bump the major version for libthr we should
> probably use the opportunity to install it as libpthread for real.
> Given it uses symbol versioning it seems unlikely we will ever do that
> though. If we really cared we could rename it for 16 I guess. The
> compat15 package would just need to contain libthr.so.3.

I am only about man pages.