From nobody Wed May 13 17:45:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gG18F5C0xz6clTJ for ; Wed, 13 May 2026 17:45:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gG18F2gBcz451H for ; Wed, 13 May 2026 17:45:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778694333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IwvzIg28aU1VG2f9X8Q3WbPs4kSkjYwj9lNZWRBpd0Y=; b=Cr4q4C6xKGUjtsnGPXpbdfeiGGrOulipj2lwR/yWGlc0GwMnZzLFrNl6yRxQ2DobrgHd5L 6uq5oNlCA30xJIN0BLjeeIzVNMD2qouWdJGQrsv+h+xHgp+TDHlKoSpN2pVruxTK1wJrpK nE3W3HQTrFF0WSNv8iSs1Ius+r8Oi/34rOJHZGf++PO9d09DRUaccxkcSpocLC6zdjidP8 Gcy+THeHr6F18Meeq2Iz0qUfdfPAJQVDECEzH6Mas8VORGn5+7P+SGdMRTg/x1j3lGEEsf 50JhJyostqC57I5kob4PkwVxdAg5dwT5phukJTpGUpMp3O88eItDe1RAMaWD1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778694333; a=rsa-sha256; cv=none; b=jS9pGkD/kpqyzYnAqbzoETnWyEfebW352t2HPzMCMGm4gD9K7E1FbKa9DYjtvDBacwqlaB SdYn10ua/eHQf6WKgM/7oidkTxSMIkqYxn5QCYfOHsJoKlo7BwvXgbd7EjY0l+X7plQBVh ZHScRHZ4EdcZxAzf30UxDIu5GaMak5OU5+0CAtCUnQrzllc2oYjvnawYreESBD3/7O6Z7T s345inPp+NGghUDc+DxFDfxQQLSzjxw47jFFTlj4aBtncTjs/5n7SYx7uxZG44b39c5nu9 omo2abgNe2WFFPW5UF9PFSTpdc/zwQ39SyH8K/9Aii176SYXfRdROWLnbidyzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778694333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IwvzIg28aU1VG2f9X8Q3WbPs4kSkjYwj9lNZWRBpd0Y=; b=EVnZcR1hctRn5qutt1+KVFeU/HAgTt5NndGhSPAwrNySeu1MU75NMoExMw7X1bxr4xTelW M3Vwfq0MlhnNhgD7/cjJ9ueAAKPkUGTzaOPahWXHDYVJkS03i9GnyEgFl6zvNiZJQX8HLb /iU94o/NE1R45++FiJmLvD3I7LPqtXF75ETNuNbzPMz+DBevnxHTVxY8kWqsznSxZWPab/ H3+HsStGQJhCOlIuTnwUXtuITlWlXdBrsqYH4isj7bpX3gdUQxR3W18JahjCSHMh2FlwuQ PVjlTP9SDhphKwyVPgHeZ0GiNSSAP5M2/1N1CiKBM6ucc0xMLhIbdA8FhGt6qw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gG18F2Gwpz11Fv for ; Wed, 13 May 2026 17:45:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d59a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 13 May 2026 17:45:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: 2a56cedac2e4 - main - bq_insert: delay the BUF_UNLOCK if not bd_flush()ing List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2a56cedac2e43c77e037e2d0c7e5af2ccb083c53 Auto-Submitted: auto-generated Date: Wed, 13 May 2026 17:45:28 +0000 Message-Id: <6a04b8b8.1d59a.24dd7c7c@gitrepo.freebsd.org> The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=2a56cedac2e43c77e037e2d0c7e5af2ccb083c53 commit 2a56cedac2e43c77e037e2d0c7e5af2ccb083c53 Author: Ryan Libby AuthorDate: 2026-05-13 17:43:21 +0000 Commit: Ryan Libby CommitDate: 2026-05-13 17:43:21 +0000 bq_insert: delay the BUF_UNLOCK if not bd_flush()ing Reduce bufqueue lock contention by delaying the BUF_UNLOCK to after dropping the bufqueue lock. Still do the early BUF_UNLOCK if we actually have to bd_flush. Reviewed by: kib, markj Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D56948 --- sys/kern/vfs_bio.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c index 675f6fb4e526..181f2907c245 100644 --- a/sys/kern/vfs_bio.c +++ b/sys/kern/vfs_bio.c @@ -2053,22 +2053,26 @@ bq_insert(struct bufqueue *bq, struct buf *bp, bool unlock) bp->b_qindex = bq->bq_index; bp->b_subqueue = bq->bq_subqueue; - /* - * Unlock before we notify so that we don't wakeup a waiter that - * fails a trylock on the buf and sleeps again. - */ - if (unlock) - BUF_UNLOCK(bp); - if (bp->b_qindex == QUEUE_CLEAN) { /* * Flush the per-cpu queue and notify any waiters. + * + * Unlock before we notify so that we don't wakeup a waiter + * that fails a trylock on the buf and sleeps again. */ if (bd->bd_wanted || (bq != bd->bd_cleanq && - bq->bq_len >= bd->bd_lim)) + bq->bq_len >= bd->bd_lim)) { + if (unlock) { + BUF_UNLOCK(bp); + unlock = false; + } bd_flush(bd, bq); + } } BQ_UNLOCK(bq); + + if (unlock) + BUF_UNLOCK(bp); } /*