From nobody Wed May 13 12:40:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gFtMj1v5tz6dLPV for ; Wed, 13 May 2026 12:40:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gFtMh5T1pz3w60 for ; Wed, 13 May 2026 12:40:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778676000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+nNHoX3QxvgPNSRcw54T7d6M64JyHefePEHHSDdJ7/w=; b=EEXnQ4j6BaWX/hG9D75SqwwZj+MWkXjQBiNOOZ9Ra6zFPJ4KcmOciWhbyoD0eLql97ISUv oGihF6zT+D/KLFCqnTKPB3PZN0tTnC2m+vetqN9YwsXJPKKyZM8Mc3w8R+O7PIQNBWhglp DMuWm5w+1Wor7iktwOdEnL89BoFVO9KGR2l0L5TPc8l8h4E5zsRaza/3+L3liddHMVt0FC 5uRd+5B8vc+ehdjsnMnUk6ovLMuri7PRFUN+/BFmT11qeqOK1JqWBKlbXZ8U436PTCvmxu Oa/6Ne61I8UTFwCqEvE2nsPZELkucu4PFb1K4A18gTtj1QohojBiZMUf8adiVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778676000; a=rsa-sha256; cv=none; b=EYoAWqSELY8HcX8ziSKpE5j298c5hA2T80iiryncxu0TO5yTxGo4wEsyGqvmcRwR5oKrJp 7Vnp1f4PiFgLoe8MIjwG5BZkNit11CP96UhSLzqICUa2dOoErFAizQ+E6pDA+RGjvBO7pa uxBBikROl+3/GcQff1csWG2MyniZHsEV8Y19GJ1/SgBXnpCd6Wvp2zTqTd8CmLBOT+rk4H aPZ2vTt82uQ24EUx3Oxb8eYrIA4b7Def7HttBIzjnojecSggdGb8RjKTGAFCG5duQrog2m er5qaUa4tuvoS8XvzUmG7HcY2MyOWwE4U0B8GObj7/rHt9w2ijqWTOMspue9AA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778676000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+nNHoX3QxvgPNSRcw54T7d6M64JyHefePEHHSDdJ7/w=; b=Zwj9lFN9XKV96GUAbjK2zlV+/4zKXXTK961swmTuPM8YYA8CGv5ygF/8uEKhtozblovv6V z1E3L4pLWPSzNRcP9l0IYG1ainY5pI8QZtBkKRjyKOcvYDO5yWZx9JVoDHqtiU6XHBQGFS L2r7F5MmMLptAz4qqne3oL4Mlvw4h2+xdgW/IqyA8dtF+eKBoi7dbA5sA/NZ/SPWXLzQF8 hSDNVb9RQ1NtE67L8TK6k+Bb+fuI1cjuNI7p5u91Krh8nbzRErYPjQEgqZkrGsna1ViVMQ mCSD2NftiWEOEMgHpqdeJ+yNwI8roaptG07lDBcRldAkfxVTlUMNu3ninXfIwg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gFtMh4lTLzr27 for ; Wed, 13 May 2026 12:40:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c68a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 13 May 2026 12:40:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 6da01f06ef79 - main - acpi_spmc(4): Be less verbose by default List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6da01f06ef7964f8a58369e7d1605ce10a49b82c Auto-Submitted: auto-generated Date: Wed, 13 May 2026 12:40:00 +0000 Message-Id: <6a047120.1c68a.31982544@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=6da01f06ef7964f8a58369e7d1605ce10a49b82c commit 6da01f06ef7964f8a58369e7d1605ce10a49b82c Author: Olivier Certner AuthorDate: 2026-05-05 12:36:57 +0000 Commit: Olivier Certner CommitDate: 2026-05-13 12:38:24 +0000 acpi_spmc(4): Be less verbose by default Do not print by default details of failures that are unlikely to help a normal user and to have a crucial influence on whether suspension works correctly. Do so only on a verbose boot or if requested explicitly by the user via 'debug.acpi.spmc.verbose'. In particular: - On an Intel Framework laptop, the Microsoft DSM only reports the SLEEP_ENTRY and SLEEP_EXIT functions. That makes some sense since, according to its specification, all functions of a Microsoft DSM except these two are in fact redundant with Intel DSM's ones (also, that of AMD DSM's ones). Those functions being missing are only a potential problem if there is no other DSM than Microsoft's (yet to be observed in the field). - The details of malformed/unapplicable constraints or ones with a newer format the driver does not know about are not readily actionable pieces of information, but rather debug/developer-oriented ones. When verbosity is not requested, only print the details of the first such failure to encourage reporting and at the same time avoid cluttering the output. - Detecting and printing unknown DSM functions is not directly actionable either, and the driver not using these functions may not prevent suspending (but might, e.g., prevent reaching deeper sleep states). Reviewed by: obiwac Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56876 --- sys/dev/acpica/acpi_spmc.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index d67ac2770f7e..1ce4401ebcf4 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -448,7 +448,7 @@ acpi_spmc_dsm_print_functions(const struct acpi_spmc_softc *const sc, device_printf(sc->dev, "DSM %s: Supported functions: %#" PRIx64 "%s\n", dsm->name, supported_functions, buf); - if (missing != 0) { + if (VERBOSE() && missing != 0) { print_bit_field(buf, sizeof(buf), missing, "FUNC", pbf_function_name, dsm); device_printf(sc->dev, "DSM %s: Does not enumerate expected " @@ -456,7 +456,7 @@ acpi_spmc_dsm_print_functions(const struct acpi_spmc_softc *const sc, dsm->name, missing, buf); } - if (unknown != 0) { + if (VERBOSE() && unknown != 0) { print_bit_field(buf, sizeof(buf), unknown, "FUNC", pbf_function_name, dsm); device_printf(sc->dev, "DSM %s: Supports more functions than " @@ -528,8 +528,13 @@ acpi_spmc_parse_constraints_intel(struct acpi_spmc_softc *sc, ACPI_OBJECT *objec */ revision = detail->Package.Elements[0].Integer.Value; if (revision != 0) { - device_printf(sc->dev, "Intel: Unknown revision %d for " - "constraint %zu's detail package\n", revision, i); + /* Only print this error message once if not verbose. */ + if (VERBOSE() || sc->constraint_count == + object->Package.Count) + device_printf(sc->dev, + "Intel: Unknown revision %d for " + "constraint %zu's detail package\n", + revision, i); sc->constraint_count--; continue; } @@ -661,9 +666,11 @@ acpi_spmc_get_constraints(struct acpi_spmc_softc *const sc) status = acpi_GetHandleInScope(sc->handle, __DECONST(char *, constraint->name), &constraint->handle); if (ACPI_FAILURE(status)) { - device_printf(sc->dev, - "Constraints: Cannot get handle for %s, ignoring\n", - constraint->name); + if (VERBOSE()) + device_printf(sc->dev, + "Constraints: Cannot get handle for %s, " + "ignoring\n", + constraint->name); constraint->handle = NULL; } }