git: ee13d62417f2 - main - acpi_spmc(4): Constraint parsing: Clearer error messages

From: Olivier Certner <olce_at_FreeBSD.org>
Date: Wed, 13 May 2026 12:39:55 UTC
The branch main has been updated by olce:

URL: https://cgit.FreeBSD.org/src/commit/?id=ee13d62417f28ee22331ab81ecac2ed3457ea1e1

commit ee13d62417f28ee22331ab81ecac2ed3457ea1e1
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2026-05-04 19:42:40 +0000
Commit:     Olivier Certner <olce@FreeBSD.org>
CommitDate: 2026-05-13 12:38:23 +0000

    acpi_spmc(4): Constraint parsing: Clearer error messages
    
    Reviewed by:    imp, obiwac
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D56815
---
 sys/dev/acpica/acpi_spmc.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c
index 95d802f7688d..5aed9ad3e5e4 100644
--- a/sys/dev/acpica/acpi_spmc.c
+++ b/sys/dev/acpica/acpi_spmc.c
@@ -516,8 +516,8 @@ acpi_spmc_parse_constraints_intel(struct acpi_spmc_softc *sc, ACPI_OBJECT *objec
 		 */
 		revision = detail->Package.Elements[0].Integer.Value;
 		if (revision != 0) {
-			device_printf(sc->dev, "Unknown revision %d for "
-			    "device constraint detail package\n", revision);
+			device_printf(sc->dev, "Intel: Unknown revision %d for "
+			    "constraint %zu's detail package\n", revision, i);
 			sc->constraint_count--;
 			continue;
 		}
@@ -553,7 +553,8 @@ acpi_spmc_parse_constraints_amd(struct acpi_spmc_softc *sc, ACPI_OBJECT *object)
 	constraints = &object->Package.Elements[2];
 
 	if (constraints->Package.Count != constraint_count) {
-		device_printf(sc->dev, "constraint count mismatch (%d to %zu)\n",
+		device_printf(sc->dev,
+		    "AMD: Constraints: Count mismatch (%d to %zu)\n",
 		    constraints->Package.Count, constraint_count);
 		return (ENXIO);
 	}
@@ -566,7 +567,8 @@ acpi_spmc_parse_constraints_amd(struct acpi_spmc_softc *sc, ACPI_OBJECT *object)
 		/* Parse the constraint package. */
 		constraint_obj = &constraints->Package.Elements[i];
 		if (constraint_obj->Package.Count != 4) {
-			device_printf(sc->dev, "constraint %zu has %d elements\n",
+			device_printf(sc->dev,
+			    "AMD: Constraint %zu has %d elements, not 4\n",
 			    i, constraint_obj->Package.Count);
 			acpi_spmc_free_constraints(sc);
 			return (ENXIO);