From nobody Wed May 13 12:39:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gFtMK35WPz6dL7L for ; Wed, 13 May 2026 12:39:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gFtMK0bf9z3vSM for ; Wed, 13 May 2026 12:39:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778675981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bEgMcNlp8wcLt9eOVDDiN2owflpWR61NVR2deRdUqmw=; b=GfwIAZG1gDd7QQsbSZ5szCVHBoqOAC88oHuSw9MH6nmWwGTdOE9YJoifolqf87Pno6x6hL qRh6cbpnws8qRfshqHPZq8KWlZByC/8r4C9gxpUBljEPPPFBemCTIuT1qUHowMBfyq6Ftj U4+PeRDrthYOR8unKV6+DrQc3krp+1TUBONbwYlfWrWqXXu6O+kMfesD0D6NiFjylWdvfp QZnlq1wqrT8zrOXQe/T+1hWb/XdKfFVi/QkU3z9cvvuQK3KxmzqZ4N9nI8gezdC0dG8upI EkOYYJF0dQr7+U0stnMn2EGsmaNCGHJsQCdYq9aSy3/nftnoOXhN2hYMfp8oBg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778675981; a=rsa-sha256; cv=none; b=jaDdiV6BWTgcCTnlDl11iXpzv4Mwxqaz1oYJg0XrAN0F/SQxplf6jbMkEdDx+8z6GFPWW2 s7/35i+WzhYHK88eFznu10fCYsmKykvn/5FJYwHrg8IMmlluCQxExHHF5+x1nVcdLjXXmx 9uEp2jdgE+hlKXaH+6i5fZq3FiRNmpMD1U9YSTsELiKD/+xecHA3ci3Ba2mwX+OiSji+D8 CGXdPLfEJ4RCouoTRrTl/sxKqKd/aBtIWpBtikTKHjAjs42rwO7FSKFZSgtKcjoQve0ZGT Idd/2NSITTr0iCD1evkSxc5Tj+O6I83UPy0pYQn5wVp1p0kzLoqakMMA41rgMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778675981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bEgMcNlp8wcLt9eOVDDiN2owflpWR61NVR2deRdUqmw=; b=wxxJAoLpaUeNtBTUp6h2CbBOEH07coLHEFXe2FD6207wez1GEaz4/Uw+giAyDGUEjnjycl la7KEp6SdO4/XEyranAluQ1pAzojRFPYWGAG04lq34QX0bKyDozLQvyzmtCr+/uJDFDJNX B/Fsq6wQWoO/cGr9j1Ls0PkU3L1kobkRfnibSH7GeIaVcXAvlVEBvH3Yuz5lOE6MGkDbFv sETbE+J472MndA2GpOmZM5jGOWctk8y8TTSvv0AvblbvxToiUXgv2Um9uOL2nrTCAWZ5ka VfEfMqDZ7p6itr5jOXD4AIQ/unqP69elkRerEREWda2J/+uLn4yTkMQjEsqrog== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gFtMJ61VLzr6L for ; Wed, 13 May 2026 12:39:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1973a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 13 May 2026 12:39:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: f77731ee95c1 - main - acpi_spmc(4): Introduce supports_function() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f77731ee95c179cede7dec0e87bc8146a2c546bc Auto-Submitted: auto-generated Date: Wed, 13 May 2026 12:39:40 +0000 Message-Id: <6a04710c.1973a.14acb230@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=f77731ee95c179cede7dec0e87bc8146a2c546bc commit f77731ee95c179cede7dec0e87bc8146a2c546bc Author: Olivier Certner AuthorDate: 2026-05-04 14:52:31 +0000 Commit: Olivier Certner CommitDate: 2026-05-13 12:38:19 +0000 acpi_spmc(4): Introduce supports_function() For better readability and because this stance will be used in many more places in a subsequent commit. No functional change (intended). Reviewed by: imp (older version), obiwac Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56803 --- sys/dev/acpica/acpi_spmc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index e7f658dbcad0..a6b18767e91b 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -34,6 +34,9 @@ static char *spmc_ids[] = { NULL }; +/* Conversion of an index to a mask. */ +#define IDX_TO_BIT(idx) (1ull << (idx)) + enum intel_dsm_index { DSM_ENUM_FUNCTIONS = 0, DSM_GET_DEVICE_CONSTRAINTS = 1, @@ -172,6 +175,12 @@ struct acpi_spmc_softc { struct acpi_spmc_constraint *constraints; }; +static bool +supports_function(const struct dsm_desc *const dsm, const int function_index) +{ + return ((dsm->supported_functions & IDX_TO_BIT(function_index)) != 0); +} + static bool has_dsm(const struct acpi_spmc_softc *const sc, const int dsm_bit) { @@ -617,8 +626,7 @@ acpi_spmc_exit_notif(device_t dev) acpi_spmc_run_dsm(dev, &dsm_amd, AMD_DSM_EXIT_NOTIF); if (has_dsm(sc, DSM_MS)) { acpi_spmc_run_dsm(dev, &dsm_ms, DSM_EXIT_NOTIF); - if (dsm_ms.supported_functions & - (1 << DSM_MODERN_TURN_ON_DISPLAY)) + if (supports_function(&dsm_ms, DSM_MODERN_TURN_ON_DISPLAY)) acpi_spmc_run_dsm(dev, &dsm_ms, DSM_MODERN_TURN_ON_DISPLAY); acpi_spmc_run_dsm(dev, &dsm_ms, DSM_MODERN_EXIT_NOTIF);