From nobody Wed May 13 12:39:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gFtMD6f9Rz6dL9D for ; Wed, 13 May 2026 12:39:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gFtMD3SQSz3vk6 for ; Wed, 13 May 2026 12:39:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778675976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X4pjMafmaVeSqkQbpwVySNoMd1Mc2vvGjGYgy4ICC4I=; b=iLqorsOs3os2L77SO9enWtH47jy1g/sOopfrnZjR3vrLx2lsIExDooZnXH502tFlLWKloZ QmGc8PjXvIGdTn6xh1w0a5j2gt3h4ti2T4erVy3FxJWRUGtK1S9MkkFDaYEtY+kMaGprn1 0hRblp6knAMTUx1In9tEhtZHlxLpjnU519+cdOguJTJ83nazLZfr1w4IagNnANlSG7MQbO DdDKuLpWyyeQK11y3k15OIS1U9hFEEbLwQqInduvkziJkyAvgV302GDEa8GESITaHPYw8o Djnb+1vBGlYy5cEUbxgEa4MBr8aiX6nZGazeCtQ6bzKEQ5o4580p+sSV7f7KGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778675976; a=rsa-sha256; cv=none; b=U36Zg+NGFfBPrpD6y/+Qut9mPhilFdD/3/2uLPmx7MoJFYygP6aHzsPa4d3mQrzT8XRDhO PDA0GeUmF3DuVF0FcS1zlo0VXgqk9zpEzNE5mDJ3Rv2xbP93yF2UmSJzl+yUQBxxpR+ZdL UXOv2QYIWt/k5Zqd+AU2WFesCuJKPQGYxBhhu+sBxM9nR7GABMaJIJu0u2n0HHHcoqMJTG n4I258BlZJccgxziY/I0+lGjO5QJW/H3bKB6BvcjmUpeNYLmTedvcCwA5kaZagTEKyYfn0 gjK/UVAzH2K+cf5NQJiyNzLY54p0upbF5svep/Ixmk/gHaz2TVcyaVbVWjCd/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778675976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X4pjMafmaVeSqkQbpwVySNoMd1Mc2vvGjGYgy4ICC4I=; b=kTVMA6Ma5ZByRsIG1iycVewD16JO0UTRU6TNofq3LDwRwUwpajOHjzKfWv75eI+wlbJlbJ scUhXHWQ/bxkqMBjEaR0op2yGRhNZs8YgyjTmFc6yNpdCh0/I99e7psGu8MNzGl2hNhh62 dOejXGXRZDQqNU3rTHz8ZvNBSE+6EkoeXippuG7/FrH6yzy2Ch+8KelaQfMxNlog+wGOFU fYniRTIeBkkfZznX2IGIWm03TZT/K+J8qijRhxvrfjkvBuwbqhKSNaQJbGhe/SD4wkvDhX z4+PibWl4nMcGI9a1xL/L6pfSbMS4mHUjsIkELVtRPHI3J4WOhDc0tB4xOHixQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gFtMD2nG5zr6H for ; Wed, 13 May 2026 12:39:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 195e9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 13 May 2026 12:39:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: beca41dfb55f - main - acpi_spmc(4): Remove XXX from a comment about retrieving constraints List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: beca41dfb55f0b83612fe8a2aec508944c4b2138 Auto-Submitted: auto-generated Date: Wed, 13 May 2026 12:39:36 +0000 Message-Id: <6a047108.195e9.25848f99@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=beca41dfb55f0b83612fe8a2aec508944c4b2138 commit beca41dfb55f0b83612fe8a2aec508944c4b2138 Author: Olivier Certner AuthorDate: 2026-05-04 11:56:52 +0000 Commit: Olivier Certner CommitDate: 2026-05-13 12:38:18 +0000 acpi_spmc(4): Remove XXX from a comment about retrieving constraints There is really nothing we can do about a DSM function that works on first call but fails on subsequent calls, except calling it only once, which we already do. While here, soften the comment message, as failure was observed with some specific machines only. No functional change. Reviewed by: emaste, obiwac Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56799 --- sys/dev/acpica/acpi_spmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index d8fa5617c8bf..36a2c20e6be8 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -451,7 +451,7 @@ acpi_spmc_get_constraints(device_t dev) dsm_index.regular = DSM_GET_DEVICE_CONSTRAINTS; } - /* XXX It seems like this DSM fails if called more than once. */ + /* It seems like this DSM can fail if called more than once. */ status = acpi_EvaluateDSMTyped(sc->handle, (uint8_t *)&dsm_set->uuid, dsm_set->revision, dsm_index.i, NULL, &result, ACPI_TYPE_PACKAGE);