From nobody Wed May 13 00:24:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gFZ2x25Wwz6dM98 for ; Wed, 13 May 2026 00:24:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gFZ2x15X5z3RvB for ; Wed, 13 May 2026 00:24:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778631865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qFuaqnI2u5Mo1xgqAD5Llr0LTC1bWYidpYvmzHdzX14=; b=o8qy0WyhLso6wAnIPDzELiyT+sDjHFVWTKcUKpixENjOTx8+/6Zfi8QkB2uTh09ilKTXyk +T3TSLWE8mlsgyFXdBpSWUpyEzl393KjIB+Ag+OuDuxEmTMcyzIGU2ZicpnPdqjkW5uyxL 1e/S3PgJoelb7FD3t02AEOLeVzfrTZQaGHpJRKQHIxoHGk74NkTXoRvE5a0pRgQh+48/rX gznbMgA3G0fwRQzJWjdfPYos/cjnDzPAJqvwGRLpZvBWQa025lu8J1asVgAECHgnouRw/Y xfx2tKs9qasQqipuCFlWz+HGBHgOeYmCMav9jtmgY+pkM8xIl06JAbmUfSZqaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778631865; a=rsa-sha256; cv=none; b=ETxKhwbKCk2V70T7OJPeybDCCZnblu/8hFq2KvPBBK6yMq/qeJ9HCccmf3HTq3+4v62xEY HCKLaYfvG7ye5Y1CDI3CyMvzku90vMWEDWOXm+Mu29tI2T6UbMLQRRDteLUZJXFiouirjt 6HPYF5mf48qWtlhH59Ky+AdBtKfsFTaaggBuzRtou6kejVQPLeJO9md3tmcE+/PiPI6Zpy MrW8TZGeZIT5IUMYlesUtvXTpE7C84fQ73tzgluOL6oZA6arJT6/Xf+IRvuA9FixETrCa3 X5+I3V15x9nqhrBgYn1d/DskUd3PDxPIelboduexwzoYt+fBUiatpDp5cyvpxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778631865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qFuaqnI2u5Mo1xgqAD5Llr0LTC1bWYidpYvmzHdzX14=; b=OvUhkTOdh2QQjBpQCmkFHI8RaUHhmm2YASs+nx4pbTnmTm+zj6vXWrJAfxVdGnXXA5Wjl/ zU0T9NCT+G+38t9FRyLK95uXSk9tkCn8FtwiVQXizvj55JfqUu+Mo6FjPeBhLiZl6YDnTl QqTRyKi4SDbWFJXHpD/n9j7Lo1FoABfo9rYKpCgt8aT4bf/sc2mBihOlXXBBMpWLdv1rp3 b0m57vNSlsw/OOmHYoQr4J7p8WoRzonPEO9f7IrwNxvlHph25EawREGrCLVbTySPvraB2D DI9lh6r8Bi9OpNYAHZQK5ezMV5IMN60+nO6cS6Tzhk8fnVMoQc0DM8dEIcIrIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gFZ2x0cbtzBWH for ; Wed, 13 May 2026 00:24:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1eac1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 13 May 2026 00:24:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Ariel Ehrenberg From: Konstantin Belousov Subject: git: 8c5cc4498499 - stable/15 - mlx5en: destroy TIR before DEK during TLS RX teardown List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 8c5cc4498499f9e3bb64cb6e8244ccd212ee514a Auto-Submitted: auto-generated Date: Wed, 13 May 2026 00:24:25 +0000 Message-Id: <6a03c4b9.1eac1.7be30e3@gitrepo.freebsd.org> The branch stable/15 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=8c5cc4498499f9e3bb64cb6e8244ccd212ee514a commit 8c5cc4498499f9e3bb64cb6e8244ccd212ee514a Author: Ariel Ehrenberg AuthorDate: 2026-04-15 21:45:07 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-13 00:23:53 +0000 mlx5en: destroy TIR before DEK during TLS RX teardown (cherry picked from commit bf636accdde4bb9af2c6c07af5420dffffd82332) --- sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c b/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c index 89d2010656c5..b6a9a0c01d09 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c @@ -596,14 +596,21 @@ mlx5e_tls_rx_work(struct work_struct *work) if (ptag->flow_rule != NULL) mlx5e_accel_fs_del_inpcb(ptag->flow_rule); + /* + * Destroy TIR before DEK. DESTROY_TIR for a TLS- + * enabled TIR issues a TRA RX fence that drains all + * in-flight packets from the crypto pipeline. If the + * DEK were destroyed first, packets still in flight + * would hit a TPT encryption error (vendor syndrome + * 0x55) because the key they reference is already gone. + */ + if (ptag->tirn != 0) + mlx5_tls_close_tir(priv->mdev, ptag->tirn); + /* try to destroy DEK context by ID */ if (ptag->dek_index_ok) mlx5_encryption_key_destroy(priv->mdev, ptag->dek_index); - /* try to destroy TIR context by ID */ - if (ptag->tirn != 0) - mlx5_tls_close_tir(priv->mdev, ptag->tirn); - /* free tag */ mlx5e_tls_rx_tag_zfree(ptag); break;