Re: git: fab4acbb7db8 - main - vmem: Include param.h in the userspace port as well
Date: Tue, 12 May 2026 20:37:32 UTC
On Tue, May 12, 2026 at 10:18:59PM +0200, Olivier Certner wrote: > Hi Mark, > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=fab4acbb7db8ffc7082d1b60b3c8e446a7cfef90 > > > > commit fab4acbb7db8ffc7082d1b60b3c8e446a7cfef90 > > Author: Mark Johnston <markj@FreeBSD.org> > > AuthorDate: 2026-05-12 17:46:24 +0000 > > Commit: Mark Johnston <markj@FreeBSD.org> > > CommitDate: 2026-05-12 20:05:18 +0000 > > > > vmem: Include param.h in the userspace port as well > > > > It is required at least for NBBY. > > > > MFC after: 1 week > > Strictly speaking, NBBY requires only <sys/_param.h>, a header I created to put simple and frequently used definitions such as nitems(), howmany() and round*(). Using it in these cases may be preferable. Yes, it looks like _param.h is sufficient here. I think it's ok to just keep it as param.h given that 1) it's not a header and 2) we already include sys/param.h in the #ifdef _KERNEL case.