From nobody Tue May 12 19:00:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gFQsd2cXLz6cwHM for ; Tue, 12 May 2026 19:00:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gFQsc6sRlz3PwR for ; Tue, 12 May 2026 19:00:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778612453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F3sfRDeXUE0GtABXaPL5ora9/tYPz7wecPclWApEWU0=; b=tVwxylvrOL27NHPOCf24m/LXf014NYrQSH7XZgsdeiIoLiyV/A4UkF4vt6FvTVOO1rGfMB IJv4RSemd1RA/UpzNqugYtgH0cI9eRsJScuwadhTO4JivWV66Wsgkz7nERneubjKDjIAiX wGSmvI1ICWSpDvNKi6Zu8gzWOCqdMAdk7xGWG48g0rNV/BXzByRb12aXBg379wmtUIPS6Y RU6uDnBo5+dcVWBJEOcp61j53YXu7qU8Vi2yAxj7Uzsevck1wxPPUESYZAFUJ64JIyOEX6 LVJT4naHE8x9QCRqrq13WfghzuxgfRRldwKz2sVUrrRVOnNerjTPg7KoxujJ6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778612453; a=rsa-sha256; cv=none; b=Ma4Je6b1gkhxl3EklwYx6bMLTeoWehVAa3aOlSLah6w15xw5A6buCZGid8lrmExDh78Hju YLIYexhosTlx3LFoFh3QNT5bbAJPwTxdhIV9kaH0nlhPuv2hlsXLAJaqm8O0mDPUjMTmbJ gNNr2mK2TO829SYrx2IHvIQu7uU5gHyqSPZJ4PjgFD+85jiqG6u1MRh5Dnl/VXQKi6tFBX ez9YVAr/TW+tTF4cpelu1RZAaMLzoWs0Isq36XJvJ+XVmAuB5/2Hdh5q9Ev/a7hsX6jVwe M4k3Ttac+oMBGPkrwOo8vmOtRCT1kLDNOaC7uNE1CjQ3DMkB4nfiTgIBnCEzqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778612453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F3sfRDeXUE0GtABXaPL5ora9/tYPz7wecPclWApEWU0=; b=tswKZzcTdf7UCPJglejTRdGAHmghh16HqrpMArmo8rd4vPf69sTvcHUKwgZtlOu1qoI0iS Ph/e/nJ8t+sWypBVRHLATpgZwsfB6Nbxsm/1KeUPjsE7JY2UF2rlwZSQl3hUA+Jvl75EYt 3eaxq3fIRm2gVus9048kni0rQ2G4rHF1c/VkHDJYLRXlwu5G2ms0KMcIQnSekoUL82YjG2 gqgUOgy7PayPtjwU9/MkGv85aJm2rCzmumB9AcbLwrRheQp78+vMC04bvCOkCJYHndxGXo DRDRVn10oGpfAxq1pwcGaa2hEZnHiHjA61zo20fiEhJL4NpIUtnKJVLFkl/MmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gFQsc6Rryz11Z for ; Tue, 12 May 2026 19:00:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 196c9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 12 May 2026 19:00:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Johan=?utf-8?Q? S=C3=B6llv?=ander From: Colin Percival Subject: git: 379805b29732 - releng/15.1 - ctld: normalize iSCSI TargetName on login List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.1 X-Git-Reftype: branch X-Git-Commit: 379805b29732c4160fbbd6d109e9a5a1585d8e6f Auto-Submitted: auto-generated Date: Tue, 12 May 2026 19:00:52 +0000 Message-Id: <6a0378e4.196c9.172920a3@gitrepo.freebsd.org> The branch releng/15.1 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=379805b29732c4160fbbd6d109e9a5a1585d8e6f commit 379805b29732c4160fbbd6d109e9a5a1585d8e6f Author: Johan Söllvander AuthorDate: 2026-04-24 07:44:43 +0000 Commit: Colin Percival CommitDate: 2026-05-12 19:00:43 +0000 ctld: normalize iSCSI TargetName on login Case-insensitive TargetName matching on logins was accidentally removed, let's fix that by normalizing TargetName again according to RFC 3722. Approved by: re (cperciva) PR: 294522 Fixes: 4b1aac931465f39c5c26bfa1d5539a428d340f20 Sponsored by: ConnectWise Reviewed by: asomers, jhb Approved by: asomers (mentor) Differential Revision: https://reviews.freebsd.org/D56469 (cherry picked from commit eb837cb8b2073c09bafaf3318f5bb103827b2bca) (cherry picked from commit 0baae6223a6350215d7b11264e59408362b15a19) --- usr.sbin/ctld/login.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/login.cc b/usr.sbin/ctld/login.cc index cda11cc1f21b..fb4b60c37f54 100644 --- a/usr.sbin/ctld/login.cc +++ b/usr.sbin/ctld/login.cc @@ -967,12 +967,18 @@ iscsi_connection::login() login_send_error(request, 0x02, 0x07); log_errx(1, "received Login PDU without TargetName"); } + /* + * Normalize target_name according to RFC 3722 + */ + std::string t_name(target_name); + for (char &c : t_name) + c = tolower(c); - conn_port = pg->find_port(target_name); + conn_port = pg->find_port(t_name); if (conn_port == NULL) { login_send_error(request, 0x02, 0x03); log_errx(1, "requested target \"%s\" not found", - target_name); + t_name.c_str()); } conn_target = conn_port->target(); }