From nobody Sat May 09 09:09:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gCKtk04J2z6d0Xf for ; Sat, 09 May 2026 09:09:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gCKtj4hCyz4Hgq for ; Sat, 09 May 2026 09:09:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778317773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=melgQ2BZ+8xiyZkjEn7KjmxuZ0WdtL1vz98Rf+uZh/U=; b=wQtIGYPXWoTkYQ/0BtDIzbY25u6QYtL5BhL1Nh8DFJe6x7E432eoDR/Vas87yYOoXD6jDL /jUnyHC6v8wIest3jDwMvlo03j4QqZv/e4NMIR+CMKJVq4Oca7iQCTviuBUf2K949IjpM5 Wq399uhT7QhAqGPgxeZxjpgyaZC92fhLLDl6Vaolm2G1Uh+zbymabWcteS91tc8noFFj3k q/kQ7coPTBdEy4qFzOPDI3akIW7MMyvc6923Pgahm/5iyTPzrZ+dla1TvYzof2D17GgfRv xn8bGr7qYy3Pj5MCrDE1Kzy2pmNZ0Iii6a3jyOf+Km86kelzoNBgDPvBNfj/rQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778317773; a=rsa-sha256; cv=none; b=niXMlzyGW8/nM/1h663h6Qbg1udOJOIPhgx77trTvDIH7rJxzsMGEhnLnGVMDw9PAyC+3a weWNBk/aeL4WjqQn9b/Ymk6X4eM4Jhjor88X2VkWsUbrh7Nix1nisNkjpCnyuM6F74uf1f x6L4ddemb8hNGTm56VTVF3kLFv5PjOz1HaQekXc1aMsPhWJDfo9lvZRPv/38Vyev9TEbi8 fpnWPMP9Y3mqSnweVCJidXSE2umhYFDd7I2YbvDuoDTMPwGcLWl7odAIiT3PGPwX9yaD5S 09UIRUHnxeuiezjZrScm0/fyKQNI9qmnOjjbz7aisE0195AxhxLK9XCVaBPm5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778317773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=melgQ2BZ+8xiyZkjEn7KjmxuZ0WdtL1vz98Rf+uZh/U=; b=gJ/KsBVWUAz2h7thtAsW1/Il7hyXoUdpByfNBb6okNVKxW4CQDejMmbY1tLZy4BSRnPBNE QPlzW3S3lMpGtCvcOtLADzOozzZbwuFNFy9Dn7T8ExlIoQT5Btzr3DpYSH6W1mV37lYv1a 5goZBsL3jocwc+6D/BTBR8NERfWFdMzq+AdM7PURMytMXikZH4EOHb3kxXxoWtc5kFHrAh sEPxmm1DMzBN7KldholA+gCYJU+c9921OmWbviKmPZsy4klkvYEaON9tcaShMkYnfu/iBw y5jNEjX8AGSdTq3/C7b/0RrxR64cExYoKLEZ3Ne5x0ROVhyiWuKMRsAhuK+EFA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gCKtj3qM0zsLy for ; Sat, 09 May 2026 09:09:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21772 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 09 May 2026 09:09:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Gisle Nes From: ShengYi Hung Subject: git: 555ffd9022de - main - pci: use uint32_t for eecp List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 555ffd9022de0c497881bafc413e3e1d05af10d4 Auto-Submitted: auto-generated Date: Sat, 09 May 2026 09:09:28 +0000 Message-Id: <69fef9c8.21772.3c013dce@gitrepo.freebsd.org> The branch main has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=555ffd9022de0c497881bafc413e3e1d05af10d4 commit 555ffd9022de0c497881bafc413e3e1d05af10d4 Author: Gisle Nes AuthorDate: 2026-04-07 16:48:15 +0000 Commit: ShengYi Hung CommitDate: 2026-05-09 09:09:05 +0000 pci: use uint32_t for eecp eecp holds the extended capability offset. If that offset is larger than 0xff, storing it in uint8_t truncates it, which can make the early EHCI/XHCI capability walk read the wrong location and loop during boot. Seen on AMD device 1022:151e, where HCCPARAMS1 = 0x0118ffc5 and the first xHCI extended capability offset is 0x460. Widen eecp to uint32_t in xhci_early_takeover(), matching xhci_pci_take_controller(). Signed-off-by: Gisle Nes Reviewed by: zlei, aokblast MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/2127 Closes: https://github.com/freebsd/freebsd-src/pull/2127 --- sys/dev/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c index 0dddd2dd263f..b5a3012accd6 100644 --- a/sys/dev/pci/pci.c +++ b/sys/dev/pci/pci.c @@ -3756,7 +3756,7 @@ xhci_early_takeover(device_t self) struct resource *res; uint32_t cparams; uint32_t eec; - uint8_t eecp; + uint32_t eecp; uint8_t bios_sem; uint8_t offs; int rid;