From nobody Thu May 07 17:32:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gBK7X4BfHz6ctvN for ; Thu, 07 May 2026 17:32:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gBK7X3H0Wz3nnW for ; Thu, 07 May 2026 17:32:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778175128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4+lUhU3vmI0ppXQDAX57CD1W2o11vdXOSI3UaSOqc64=; b=WCpM+yqvwbe7Vsr7LfePHoT7WKv/vDcbKUFb7QbJfiTPwiACKRhPFV+VenRiC5Dcttb57e lYryu0rL3zp7euiGUdvBUem2hd0/8d9IpkwLyFbjP+8olIVLaGUeuGlE0WYO9TJWHJIG6L fedmlXef4vhsY6CZqYFFKq8653FFYVtGo7DIlmeq6Anqsvt7ln+vh3CMhEoOqCPPFUNMxn FJWIOkn8wD0AFPnmyh7oJUEqxaANmaDdpQyE7XU3o4cd6q9UmdZV4HG9E2QXNeis0ykPX2 OGUj/gowwMgmU+DWDjUqApGbmoaNtoFKiE0FOpxtRnjcPm8yzaWEOhDjhf9DUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778175128; a=rsa-sha256; cv=none; b=fDJCuODLbSuitwBjEFcIlBrNvUSNOQEVL8HOWW3+ZL6OTyUNjNxikHmtK2E8RWyxijWMDS MqnPlJxrF3pqtY+xKjYxZsYK9khXzxZmvtzPYkzzfUiobx6WgB4pMrSr8JV7xTK4Xea3SH NKdg0O/qp/hlJ0HbaOgdvkrTyzmn0jAciDxjUDKZD3bVytm5tyHddzrfkY36agZG4OtfdA Myc770HsyDJSBIEhhaQTYWMEFzRZEyBf1cArhz4iESZJdOIhsCBMdwY/2JYh6lawIFsldo STgUwqwia3CxoTTVlY4x3T9EVnCEm4sURGKMmPklmC5h/DKBa90KVZTKckjqcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778175128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4+lUhU3vmI0ppXQDAX57CD1W2o11vdXOSI3UaSOqc64=; b=wMLFHmndWYPkvYwGxt5Tx2sP7GpSsxyDK+ig/BA/GG7L3z5XfwylJSjrD/wLievS85rVKR x6ZkuF6CFHKEHm4tt4UgGtIddp8NK5UpDVpPu1EKvm/e9CpHV85qNGbONyYA4kWMwzS1Je hCUea9OJcHsc/haCcoeSWyJUGwj0fBdM2Te1N2wBPsx38XErWi0QsoQGtOqWU2D4zvvhkh mp2zXG0/UVcLrJIiHOZvmGW/qC5dVg7ofv1+qEZh87y+PIr+GlyZKyOjhW7sVLoUv9uknC k74lBdT1k56Agoy89UoQ+B9IpzWhMFUJETUg2IzKL5AlRKORGe0DaI+Ap7MVqQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gBK7X2kYyzcG1 for ; Thu, 07 May 2026 17:32:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c66f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 07 May 2026 17:32:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: 944a4eb089b3 - main - stand/libsa/zfs: disable ZSTD_TRACE and DYNAMIC_BMI2 code paths List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 944a4eb089b33241b21979253e0a373ce0bdf984 Auto-Submitted: auto-generated Date: Thu, 07 May 2026 17:32:08 +0000 Message-Id: <69fccc98.3c66f.1f43e0bb@gitrepo.freebsd.org> The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=944a4eb089b33241b21979253e0a373ce0bdf984 commit 944a4eb089b33241b21979253e0a373ce0bdf984 Author: Ryan Libby AuthorDate: 2026-05-07 17:30:05 +0000 Commit: Ryan Libby CommitDate: 2026-05-07 17:30:05 +0000 stand/libsa/zfs: disable ZSTD_TRACE and DYNAMIC_BMI2 code paths Enabling ZSTD_TRACE leaves behind undefined weak symbols, which causes a problem for gcc builds. The bfd linker emits an obscure error about overlapping FDEs. We don't need ZSTD_TRACE for libsa, so just disable it. Also disable BMI2 instruction optimizations. The addition of the optional BMI2 code paths caused the boot loader binaries to grow larger (28 KiB for clang, 32 KiB for gcc). The boot loader binaries are size constrained, and this pushed the gcc-generated lua_loader.bin over the 500000 byte limit, and the clang one to within 4k of the limit. Fixes: 8a62a2a5659d ("zfs: merge openzfs/zfs@f8e5af53e") Reviewed by: delphij, imp, mm Differential Revision: https://reviews.freebsd.org/D56866 --- stand/libsa/zfs/Makefile.inc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/stand/libsa/zfs/Makefile.inc b/stand/libsa/zfs/Makefile.inc index 3df6779559c9..540635d144ef 100644 --- a/stand/libsa/zfs/Makefile.inc +++ b/stand/libsa/zfs/Makefile.inc @@ -75,9 +75,13 @@ CFLAGS.zfs.c+= -DHAS_ZSTD_ZFS \ # # ZSTD coding style has some issues, so suppress clang's warnings. Also, zstd's # use of BMI instrucitons is broken in this environment, so avoid them. +# Avoid generating the DYNAMIC_BMI2 code paths because the code duplication +# inflates the resulting binaries. Disable ZSTD_TRACE because we don't need it +# and the bfd linker trips over the weak undefined symbols it generates. # .for i in ${ZSTD_SRC} -CFLAGS.$i+= -U__BMI__ ${NO_WBITWISE_INSTEAD_OF_LOGICAL} +CFLAGS.$i+= -U__BMI__ -DDYNAMIC_BMI2=0 -DZSTD_TRACE=0 \ + ${NO_WBITWISE_INSTEAD_OF_LOGICAL} .endfor CFLAGS.zfs_zstd.c+= -DIN_BASE -DIN_LIBSA