From nobody Wed May 06 23:29:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g9s655Bpbz6d1qZ for ; Wed, 06 May 2026 23:29:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g9s654RxQz3KvM for ; Wed, 06 May 2026 23:29:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778110157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/ykTCWnnvC1cQS0WCSLVWqey3lN4C4/BgJyF4JSfvUM=; b=HT+bK8CqxAEh+F6QwBwTfq089+jAUYrqwHLF1ZrSHFo0RydOz3ifP2relXIZsX9wksvgTM fucX+O9NRKzbo12CsWptmxdo8rYRZHIudNNmRELzuNscc+4ot0r054RjRWFsFmjzQWb7rc U0GLVsLTa8heuvkGpSnqDT7hhRWiR11ZHBXYFGAUSZbpaeSHgwzVq5rQyouHNchV3qlBMu jE6ECcsMi2iV/1MW4znSJWEpsMkGhGfs6PgBRSFGsAqhTO445P88zrn8XT1yvwrLK3Qixo 7aAvu2w4dvt/QP52JK47i38xTdI/S7vDbqaHC6u78+b49QjRMIJFIxfLHB/5iw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778110157; a=rsa-sha256; cv=none; b=H8VnTLsyUcaxwKXsA00l2cX32dXCEkJsSAGF+w071A4oviE2b+0jOch5lkaMXXSjZ98Ura uZ3e+qbmxLzIE9n3sJkWn0J/umZ5xOwFM5hsxmC8qLUr0U4syeBMF+4G8VmcAb/PLREsfM /uxzHvsnC88t2ycszwLO+zkJSYCvtcTnUVIC/lZMnIMJlP5DkPLLOc61CJC80MM7LS50bP HAzhSu2Axe9T4dcFjXy0YswVneiBWuKniBN1plxaD9S6VVOV17vAlV5utENKEX32/0eYbn 1la4hLWa+vAlFplSV7Uu72GJasQVjTlTOmhm382wI72Gtw13rjOj9zy1OqECRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778110157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/ykTCWnnvC1cQS0WCSLVWqey3lN4C4/BgJyF4JSfvUM=; b=knUfFbOp39eaH+jJyrsij68OXwOZSdBEDmUftu0hIP7DqET1Oqcs77lraFuUrwalpgifba TKoRE1MmUF6CcOOVN99NQL0Yd/0ItyWojuZmGOhB8OAU5JOt8FUcHBtTxKtaZeXXHwkN6M mJCXbYJIRYDVurLVggpw/M5Kh3TU5ORVZMB3iepqSbQgfExzxsw/OAtsV2AVqLlyBUYjOp tR/imFVQu60G9cYWiNiO353smUQYT180ECQnxemI2aPqP7T5P+Sw+2BrhuqD3UzNWJE8YX Fxef1YRgItR8gluEV6TViXca3+x3Cntpz3hHDJ1oqpA0o0JYxgdCW9cpW+FBsg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g9s653jcMz114M for ; Wed, 06 May 2026 23:29:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3acf5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 06 May 2026 23:29:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Jan Bramkamp From: Kyle Evans Subject: git: 58811b0ae096 - main - jail: open the fstab files with fopen("re") List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 58811b0ae096c134af372bcf475aea1d8d0e3c08 Auto-Submitted: auto-generated Date: Wed, 06 May 2026 23:29:17 +0000 Message-Id: <69fbcecd.3acf5.85ed4df@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=58811b0ae096c134af372bcf475aea1d8d0e3c08 commit 58811b0ae096c134af372bcf475aea1d8d0e3c08 Author: Jan Bramkamp AuthorDate: 2026-05-06 23:28:53 +0000 Commit: Kyle Evans CommitDate: 2026-05-06 23:28:53 +0000 jail: open the fstab files with fopen("re") This protects against accidentally leaking them past fork()+exec() in future refactorings. PR: 295052 Reviewed by: kevans --- usr.sbin/jail/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/jail/config.c b/usr.sbin/jail/config.c index f1e2da215790..188f48732561 100644 --- a/usr.sbin/jail/config.c +++ b/usr.sbin/jail/config.c @@ -726,7 +726,7 @@ check_intparams(struct cfjail *j) TAILQ_FOREACH(s, &j->intparams[IP_MOUNT_FSTAB]->val, tq) { if (s->len == 0) continue; - f = fopen(s->s, "r"); + f = fopen(s->s, "re"); if (f == NULL) { jail_warnx(j, "mount.fstab: %s: %s", s->s, strerror(errno));