From nobody Wed May 06 20:52:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g9nd85nMPz6cnXx for ; Wed, 06 May 2026 20:52:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g9nd84jr1z47cY for ; Wed, 06 May 2026 20:52:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778100748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Mz7aCwAmLagYvkBWYzJa0hQbyvKScGi2w6AH1DYTsS0=; b=wgAO73UcY6Ga56YyyhFTxIeAC/WM5zErweXzL9Fza4txqEulb4zDpdx6x1K8zUKJofk6b9 kkL3Qgwa8Me3nhqXrzTjhfmYzsazz1tRl+ObJJPm3x1D8fTbVie+L/puaKG1sMK8RHIfMW kXsMeie3PIuFeDfHKZCk4M7lRG0ijvmv2rsBpyyS7R6F+Lttuqpba/DN478QnhZtYrabeH HQo1Ab/9cf6mK2grDfxGkehIZbdjSVExGT0CNSuvtpAL2az0gpOB/gcwTQHb3s8Z0Agi+D 7hSf7yOH+Wyqz/PLsJk4EpArNPCpN+Pm2y4ESL8dLIjrG7UZQwm3x1A7z9iXqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778100748; a=rsa-sha256; cv=none; b=qNaO7DthS6bRr2EzzwVuWto9h13yBwBj8/X1aF9U4Ua4W3U+LR1CwM4YJZoaP1PpmjnZat j/g9lqHnOf6exc0fFpIG5vKNdyvpkJJQb+gRz/ohhdUiUKUDK04bak5Q7eJ4EdGLcaohsB XsGyo7YvdX53OiUSabScHCtE9qszSbqB6eSDyJ1IWKQixeLaQhOAyo98RkUAyfW09nqhpG iBxAkcGV4V6FiqkqFTpskAJjXFtWHmOf9F01rk3R4Z/MErMMr8rou/loEDlkxePndD5igz FXauMrV0n9tb2nHT1P00wmzZ3p84tiDAyeX+zxF5f1RhFkvSbDTlccD6xdPnlQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778100748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Mz7aCwAmLagYvkBWYzJa0hQbyvKScGi2w6AH1DYTsS0=; b=vo6PFNfoeWBK/Y2PJNNBK399NPjJZpBR9XCX+MYFnRpdaOdYScUnLKd+XZViCmzVxCI6P5 MNAsQwD+m0Rk1aJqw8TMX5p96E3Ce9A28PNMely06GcCBwOMrHRemX85TH+dn9neNKK7d2 WScajOA40Fyz1SLWwJTwR7B1xCHk6pOHmn3oXBAKX3u9PKxi/t7LRUBPzGBYCHwHTfg8No sll62qIcWkv9GR7D1GEmyxlEBRqLjYRW7BKrmTNRTSal/BQN7yCr2FNoC4llVDYt+av1T7 aQ9LQq0K7r81zW54VZabFfY0Kd0sbUj96PAzWEnXSFd9JWmKcrLQhRqg+vjEwA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g9nd84GCmzw4T for ; Wed, 06 May 2026 20:52:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 229d5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 06 May 2026 20:52:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ariel Ehrenberg From: Konstantin Belousov Subject: git: bf636accdde4 - main - mlx5en: destroy TIR before DEK during TLS RX teardown List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bf636accdde4bb9af2c6c07af5420dffffd82332 Auto-Submitted: auto-generated Date: Wed, 06 May 2026 20:52:28 +0000 Message-Id: <69fbaa0c.229d5.2dc77e0e@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=bf636accdde4bb9af2c6c07af5420dffffd82332 commit bf636accdde4bb9af2c6c07af5420dffffd82332 Author: Ariel Ehrenberg AuthorDate: 2026-04-15 21:45:07 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-06 20:52:12 +0000 mlx5en: destroy TIR before DEK during TLS RX teardown Reorder the TLS RX teardown sequence so the TIR is destroyed before the DEK. DESTROY_TIR for a TLS-enabled TIR issues a TRA RX fence that drains all in-flight packets from the crypto pipeline. If the DEK is destroyed first, packets still in flight hit a TPT encryption error (vendor syndrome 0x55) because the key they reference is already gone. Reviewed by: kib Sponsored by: Nvidia networking MFC after: 1 week --- sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c b/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c index 89d2010656c5..b6a9a0c01d09 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls_rx.c @@ -596,14 +596,21 @@ mlx5e_tls_rx_work(struct work_struct *work) if (ptag->flow_rule != NULL) mlx5e_accel_fs_del_inpcb(ptag->flow_rule); + /* + * Destroy TIR before DEK. DESTROY_TIR for a TLS- + * enabled TIR issues a TRA RX fence that drains all + * in-flight packets from the crypto pipeline. If the + * DEK were destroyed first, packets still in flight + * would hit a TPT encryption error (vendor syndrome + * 0x55) because the key they reference is already gone. + */ + if (ptag->tirn != 0) + mlx5_tls_close_tir(priv->mdev, ptag->tirn); + /* try to destroy DEK context by ID */ if (ptag->dek_index_ok) mlx5_encryption_key_destroy(priv->mdev, ptag->dek_index); - /* try to destroy TIR context by ID */ - if (ptag->tirn != 0) - mlx5_tls_close_tir(priv->mdev, ptag->tirn); - /* free tag */ mlx5e_tls_rx_tag_zfree(ptag); break;