From nobody Tue May 05 19:52:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g98Lc3k8Wz6cGpR for ; Tue, 05 May 2026 19:52:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g98Lc2wz4z3YCx for ; Tue, 05 May 2026 19:52:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778010760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5eW6mZTs1TUNd91ANTGgVpZHrOPsrISYx9KSUTnWTLs=; b=b8bMp6dXJq3oyyajzU/GJ5heqanBUEj9G4qcojvRQuqGkYRA4J8Bbgtpo1aBy7rTvikoKO g7c9k2FKWjor0fQWWfYvzsCRZynnCrN6I+EBiq/zH2xv3MhNVH2uq3UkdopzJZHEU/7cuO 4G2pNQnAoNI2SWVfBPHYOu3m9Wx6qx1tVvj7mZEj8y0vVyGDm0uH5imK88618QnKcZdd/k UEEnPss7CuHFz8Yo3/55Ied0O3HGZoOkKHsJ5TIwKojLq07niECb+WVNPKjr5JG4fWl9Qw oyG2W43t51CLoUPrd5QcWOmx5OOuQRF/jh1WS9zi0JqFM+25Yam463bfZBgG5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778010760; a=rsa-sha256; cv=none; b=c/JbYd/3adQ3FM7xkDAvDz3kcq5zxsQ7lAoIVMMSbdaBsAmjPEklubWHpMHMsNxDjzWjY5 nHvHCMSkuzpakbxHJlWcETHCLtDYUBsRP6JXZb2JL9Ym+hnZ1Nysod35/giKABKmpOnpvj 5jPwAEcjgZBDyOaS/XdGm3cz8Ucke8DaDbLP7CPCMg6nVtD/E4AVdWhqjmKJD4CBPVegiS S7O2rI1e69Ldkw2YFvjIMrXprEevaPlFq6pCNxZX69RfZfFuM+vE2zYpByiQiDrUYkrTgv eBcxqBxxMKj1FVJHNHDV1ccGC0Iud+t0w9XaD5EILqtePYkEWrK6BysfmQcKMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778010760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5eW6mZTs1TUNd91ANTGgVpZHrOPsrISYx9KSUTnWTLs=; b=xk1djWGKYHnFkCSgatXEkYBdyatmKCz8ogra8iRmyXvANWeZDcL5GvpjRmY1N0W/U/ef8L yx0ljf3sKglyOvfFadTxfAEVZ/CwgaI13V0EMG4H0e7w6bcXOk4qWpC4HB8WL84ZiKrj59 uEwdGFjB3lz27pnV/q3MUoXIKWlxIDtYsdrr1svIlLkJYio63CLGppob6s2ppRjO07PIRL 02HpHS+D6Lk+OzqAUKNBGZ0xDbcmpzh/pwev4w0EQTRHIKiMOKfxKjiBTC5A9qSLODzxH5 QEtLMkj7DdssdJxWYkODKgC5UtRqPs6yPH3NHblNammd+nmKa3UEVJYVYJWKAA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g98Lc2MSSz1L6s for ; Tue, 05 May 2026 19:52:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 407d8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 05 May 2026 19:52:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Enji Cooper Subject: git: 7619d14d08a0 - main - acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7619d14d08a0036a07dce670f55b9568f8133b38 Auto-Submitted: auto-generated Date: Tue, 05 May 2026 19:52:40 +0000 Message-Id: <69fa4a88.407d8.5b776998@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=7619d14d08a0036a07dce670f55b9568f8133b38 commit 7619d14d08a0036a07dce670f55b9568f8133b38 Author: Abdelkader Boudih AuthorDate: 2026-05-05 19:49:01 +0000 Commit: Enji Cooper CommitDate: 2026-05-05 19:51:38 +0000 acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown acpi_panasonic_shutdown() calls hkey_sound_mute() without holding the ACPI serial lock. Every other call site holds `ACPI_SERIAL_BEGIN(panasonic)` before calling it, as the locking model is caller-owned. This seems to affect the whole Panasonic Toughtbook lineup btw. Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D56718 --- sys/dev/acpi_support/acpi_panasonic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/acpi_support/acpi_panasonic.c b/sys/dev/acpi_support/acpi_panasonic.c index 8fea47ee45e8..5f54ca07c5a6 100644 --- a/sys/dev/acpi_support/acpi_panasonic.c +++ b/sys/dev/acpi_support/acpi_panasonic.c @@ -233,7 +233,9 @@ acpi_panasonic_shutdown(device_t dev) /* Mute the main audio during reboot to prevent static burst to speaker. */ sc = device_get_softc(dev); mute = 1; + ACPI_SERIAL_BEGIN(panasonic); hkey_sound_mute(sc->handle, HKEY_SET, &mute); + ACPI_SERIAL_END(panasonic); return (0); }