Re: git: ce9ced951a0b - main - libusb: change callback register handler to int
Date: Tue, 05 May 2026 16:45:05 UTC
Hi bapt, I also totally forget I have replied under your patch. I will revert my version to address your problem at least for now. Best, ShengYi Hung On 5/5/26 23:52, Baptiste Daroussin wrote: > On Tue 05 May 15:48, ShengYi Hung wrote: >> The branch main has been updated by aokblast: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=ce9ced951a0b9d004a3b007d4ac6e9087a1301a2 >> >> commit ce9ced951a0b9d004a3b007d4ac6e9087a1301a2 >> Author: ShengYi Hung <aokblast@FreeBSD.org> >> AuthorDate: 2025-12-13 15:12:11 +0000 >> Commit: ShengYi Hung <aokblast@FreeBSD.org> >> CommitDate: 2026-05-05 15:48:22 +0000 >> >> libusb: change callback register handler to int >> >> libusb upstream uses int for register handler. This causes some library >> user (like pyusb) to assume that we have int in all implementations and >> therefore provides a 4 byte storage only. This causes Segmentation >> fault as we will right the pointer. >> >> Reviewed by: adrian >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D54211 > This breaks backward compatibility this is why I did: > c > https://reviews.freebsd.org/D55687 > > sorry I didn't catchup on it, and sorry I missed you version of the patch. > > we don't know if we don't have users relying on the previous ABI imho this > should go via symbol versioning and then backward compat. > > Best regards, > Bapt