From nobody Tue May 05 15:52:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g93235N5Cz6cKlN; Tue, 05 May 2026 15:52:59 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g93234gKpz3nMQ; Tue, 05 May 2026 15:52:59 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777996379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t3pjM6V1LGv6cLRXonY/EVHpWPFIwY0QXJVwMX9Yffk=; b=L67Hcp/MPb2bELCBFtpsb2ONIgn9yaYUzh5E7vvqhf0ejYb0mPIkkzXz/OgQMK/SxoD8FH /EmajafiRsF2Dakhq3HCxtua94go6IIsHjZPsUhoGMfS7VFeFigKfWqaFPyTkBeRLNPN8N aR11TLht3MG307MkJbml0aE0c2cvKz43UyJM7rYOyuMf/HsWAeitBdJqJbNxIocIog5Zwr SBJohaIPWK5sH0ws8AFytD+Bbo0rd/91iu0IMpwGSrF9qSt+WYldkKhcWIj6/TrvA8DVet YdFK784Q5cV6WVAAxzyJChLRSmlYMgz7AiQjIFOZpKSWpetilBwbSD2+3ONOVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777996379; a=rsa-sha256; cv=none; b=hgInyUvQKCZ6++sTXizgaz59811frEeVV57qp9xbXkUj/r+zdU0cp9xdiL3cRU/L80EMHw vq8MkpDFQPh21OOdh+ShQtWCY6L7AS3sdn7qOcPjKJWRv5lKLhaPzLmo0FUbsurJqQAJKR aGO+bvHCtJ5Hd6aigSFTISokwd0R5GOlZsZtWed5t3I0pkguaaYklB9Xz0LgkvJc0V9hAz u3zkd3HjPQ7yoCSPETAevtzoSU2Ura3V/JKUPu6nPWBY8gE4eA2n1Jezx2k0ENPF6caTQE IMWCyaRmW3PiTyO6d0qjbyDhDl8aCQVRLcluOZ92WhuB5u+EHPmQVN8J0SR00A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777996379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t3pjM6V1LGv6cLRXonY/EVHpWPFIwY0QXJVwMX9Yffk=; b=bWk1ASaZgINCEamYNwm0vm8wmX38pxVjLziQ69VTBCMwvv7P+yUje9OXwXgWHV1NTNvSd0 I1CErmg6GDCn1nMsmTlH0LlU3ipGC4yqPjjEylMkealhIatwbGJl7eCS7qkI6LbwaQNvls sNWR3U3IvrwCDNaKGTCjPEmOmWTad3yubZ95/+9ql4tItyVaVrNed0UJ3kDTls7IFtOlw0 bSTaGaTz7DR5yC75EH/a6DjQw/v5pBPUHlBBaWePZsK6whzfnkzpr1NlrHNJYjpDmSrWiN Yq+AaeSCcwLKJLUXpZUWbcZ2VtS1leB5VW217Lf24n3BzXt7pbN070DX9FEd/A== Received: from b.nours.eu (b.nours.eu [IPv6:2001:41d0:303:5e39::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g93233d42z2Jc; Tue, 05 May 2026 15:52:59 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by b.nours.eu (Postfix, from userid 1001) id 56C86416CD; Tue, 05 May 2026 17:52:55 +0200 (CEST) Date: Tue, 5 May 2026 17:52:55 +0200 From: Baptiste Daroussin To: ShengYi Hung Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ce9ced951a0b - main - libusb: change callback register handler to int Message-ID: References: <69fa115c.1eae4.306694d3@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69fa115c.1eae4.306694d3@gitrepo.freebsd.org> On Tue 05 May 15:48, ShengYi Hung wrote: > The branch main has been updated by aokblast: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ce9ced951a0b9d004a3b007d4ac6e9087a1301a2 > > commit ce9ced951a0b9d004a3b007d4ac6e9087a1301a2 > Author: ShengYi Hung > AuthorDate: 2025-12-13 15:12:11 +0000 > Commit: ShengYi Hung > CommitDate: 2026-05-05 15:48:22 +0000 > > libusb: change callback register handler to int > > libusb upstream uses int for register handler. This causes some library > user (like pyusb) to assume that we have int in all implementations and > therefore provides a 4 byte storage only. This causes Segmentation > fault as we will right the pointer. > > Reviewed by: adrian > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D54211 This breaks backward compatibility this is why I did: https://reviews.freebsd.org/D55686 https://reviews.freebsd.org/D55687 sorry I didn't catchup on it, and sorry I missed you version of the patch. we don't know if we don't have users relying on the previous ABI imho this should go via symbol versioning and then backward compat. Best regards, Bapt