From nobody Mon May 04 20:59:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g8YtD1Bgyz6cQlg for ; Mon, 04 May 2026 20:59:32 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yx1-xb133.google.com (mail-yx1-xb133.google.com [IPv6:2607:f8b0:4864:20::b133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g8YtC5jlpz3ggW for ; Mon, 04 May 2026 20:59:31 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yx1-xb133.google.com with SMTP id 956f58d0204a3-651bc83e74aso3995790d50.2 for ; Mon, 04 May 2026 13:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777928366; cv=none; d=google.com; s=arc-20240605; b=gY3wZT3f+vDVsBfF09ZBYmwXzr7JYnHTK5WkGvU2+63HIBUG3WJM3sCSdNF42HbDGH BXFkLxXku8FD1luRR5akKBM0hQfKsiiYn5RGdtmGoKrxi32tglNCI2C1thyuvHlEdXtf ih8WeIHCJ87tCNTf+wEyaWoSgkcIVu7fFlerjFa1hjqerPq1rs/qP2Y5/R/1HLo5yMrd INuSei01Hgg7b3pgGusJ26VOfNWy1CYnEBN23U4OlyL5JCx/ztosrwikDILvSnEhMLXL sh4TPYc5HcPo1BlifqzxWcnO3By0cKQRdNdtKalCr7zrw0CL5uK75Qrf1AjY29T6/NqY 44Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature; bh=+rAGedD6vDvl3FBbMUZx2Mw0OId1sF03Se0KPGkJ/FY=; fh=6Cgd8xiu0zkNL9NFAnJkWIQO5lfF29kpCWBD6ukKVcg=; b=Y/a4KjieScmU8LZe0vdTNMX6QdinLG0NFZi7bgLzTknAdbrMeDRFDZBRJCDNY9ijGz EXLhdzNTDNkO7OoZ3fozjFpVcNKBbmwbjhT53lOjccauUJO3Ltzyxbmy6GtlzaHDLa7X morotB2j0vWHuD4tXKZYTEQ5/TD1D19KaMeWlBloWWfAQhi4kONy2ORot3EdzVFHtZ6z FPihVFg+ww6ErDhbj+nFotCyNohESbDTZSmPF5o7JjjxtCGKMOZ0y3MzOtlHSN4HhEXD itEQ3YAgaNXKqumzQrKVztIp8LAYOeTnQn2GLcb5pnqWgLMpSuYJTAr8VaQ0uMsz694Q T0bQ==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777928366; x=1778533166; darn=freebsd.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+rAGedD6vDvl3FBbMUZx2Mw0OId1sF03Se0KPGkJ/FY=; b=aQlZNACntaQV/ypMNWUVbBFK9SVzKNq64fnjHPAFrbpeg67TWFewQ7KaC0HwED9Bb3 a3KBpkobP4dt3MAzbtre2hjGH/cDatSPKZuSlXinriIOh6O1dVKnxMh+tUMnMMZ+4aX2 VRqx6nS9IenYVD5L3jFFzUQp7L95KdiZ/zS6euK1BrvOK4Pfl65Oy5LFn0syiOHxv0xt wtjY8tsKtDnz3rLWAZyWN0mGpT5QK8TiHSKFVnyNLrDi+TskIHzL554C1AUzuojZ2PpB 6lBFVjXMCNeZW2JHxEqkgm6NXIhJGJdDXu54+n4UJOncARc9W+ylhSxR2w8wjLp4tJW/ Z5rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777928366; x=1778533166; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rAGedD6vDvl3FBbMUZx2Mw0OId1sF03Se0KPGkJ/FY=; b=bDly7FQfqw2OxtxztrcYpeIEBFLJbDRTko0yPuJZ1pdFpCvrcok/wV309DUR5DrkaL tWibzNAdh1o8dJGxJllj77b1Ggmye5zJZlDxFEYC/Kjox1Aa6CzimqbUVT1U3cbX/HYz QKVQ0/wh0pD6AvHDEpKB2XlYkBdhUGrlG9nCwQvQ46wNBFpechRXnifz1+Fo9LkfJYBm /iaylybmsZ91Ai6ezEbSEnOJKQjt9533T+EjOdckRM7C2j7OhlNdzEywHmjjoem2WAa3 h9HfPilK/zqX9lTEDgh4LImfIgdb8cHv0wlKojrdsbWAYaytvz0+eLzUvPS/KKr81IRn UlvQ== X-Forwarded-Encrypted: i=1; AFNElJ8OvyKCpX3ZI746GStUqXoqkyNeRQGLAcCIn+IokUjHNdP7z+IuC6c0bIOw3UfXjsuUu4A1TZFPc+19fYQ60RcGYmCN@freebsd.org X-Gm-Message-State: AOJu0YyAN/OX7DTdtMXdqLvrq6w4TEF16VyPz47474tJmIT2ESsmcW2m ij34UY6mvn95QvTGtKeywojBqTeAYwVRMaZN7LZycWZyj+chjEu5/3065Wt+GnTzQkx3aARIFOZ 5H7Jxv9NIwiIqq06TLMnEehr7fcyPbxuctg== X-Gm-Gg: AeBDieu9Z4L26DqSF+uFxwVrt+YV2xZkqHQ+NO3ygGfhDfZQ8EMI9tVeGjK+7QruPJV lWP64wnYm0G42IX4pwuQw6Hc6Ac6Qami1KKsZd+Hlnd89QmqUPNnbNccOmek29xawNDpTn44/Y0 JKTW1Ppkv5yfHurNb6CayC5Gn8nA9EseARQZ0bX6aSLLWA9yggMXGuIxa8Ne87vRBMCIY2kmTOm xFNatSFXnqk/Z2QqiVr18MBGbeZMQpJR3Wwr0/tEjrkC2ETGR7cXE67ut8bZbIDel3tr+mYX1bT bq9hGrzA929dsSFvuvfE0GKABD0CiYMQHwj60XOz+x84QoP/5PQ= X-Received: by 2002:a05:690e:d5a:b0:651:b67e:6e58 with SMTP id 956f58d0204a3-65c3d9a379amr10654700d50.7.1777928366164; Mon, 04 May 2026 13:59:26 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Received: by 2002:a05:7011:a1cb:b0:515:3e23:509f with HTTP; Mon, 4 May 2026 13:59:24 -0700 (PDT) In-Reply-To: <14577.1777919687@kaos.jnpr.net> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> <6875.1777333471@kaos.jnpr.net> <6906.1777574491@kaos.jnpr.net> <14577.1777919687@kaos.jnpr.net> From: Oliver Pinter Date: Mon, 4 May 2026 21:59:24 +0100 X-Gm-Features: AVHnY4KqwATf_61TGu3cocY3DWtVNPynoPJq-WNDTVpUgDh_i3Gv5a7R1iXnqcQ Message-ID: Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently To: "Simon J. Gerraty" Cc: "Enji Cooper (yaneurabeya)" , =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000b38fa80651043442" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4g8YtC5jlpz3ggW X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --000000000000b38fa80651043442 Content-Type: text/plain; charset="UTF-8" Hi! On Monday, May 4, 2026, Simon J. Gerraty wrote: > Simon J. Gerraty wrote: > > > Oliver Pinter wrote: > > > Could you please add some unit test for the supported use cases to > > > avoid future confusions? > > > > Sure. safe_eval.sh is setup to support that. > > https://reviews.freebsd.org/D56795 > > Not sure if anything else needs updating. Thanks! I've seen that it tests for ``, but what's about $()? Tests work as expected from src tree. > --000000000000b38fa80651043442 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi!

On Monday, May 4, 2026, Simon J. Gerraty <sjg@juniper.net> wrote:
Simon J. Gerraty <sjg@juniper.n= et> wrote:

> Oliver Pinter <oliver.pntr= @gmail.com> wrote:
> > Could you please add some unit test for the supported use cases t= o
> > avoid future confusions?
>
> Sure.=C2=A0 safe_eval.sh is setup to support that.

https://re= views.freebsd.org/D56795

Not sure if anything else needs updating.

T= hanks! I've seen that it tests for ``, but what's about $()?

Tests work as expected from src tree.
--000000000000b38fa80651043442--