git: fbecfc4aa028 - main - fdescfs: do not change vnode type on VOP_GETATTR()
Date: Sun, 03 May 2026 19:59:02 UTC
The branch main has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=fbecfc4aa028964f972a0457809aa041d415f61b
commit fbecfc4aa028964f972a0457809aa041d415f61b
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2026-05-03 19:09:15 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-05-03 19:58:36 +0000
fdescfs: do not change vnode type on VOP_GETATTR()
There is no point to do it. The VNON type is good enough for fdescfs
operations, and changing the type on stat(2) is arbitrary and does not
serve much purpose, because we recalculate the returned file type on
each stat(2) anyway.
But setting the type to VLNK has undesired consequence of namei()
trying VOP_READLINK() there, which might fail since it defer the
calculation of path to vn_fullpath().
Submitted by: Mike <mmpestorich@gmail.com>
PR: 294768
MFC after: 2 weeks
---
sys/fs/fdescfs/fdesc_vnops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c
index c1188c3819e7..267e80918d1b 100644
--- a/sys/fs/fdescfs/fdesc_vnops.c
+++ b/sys/fs/fdescfs/fdesc_vnops.c
@@ -469,7 +469,6 @@ fdesc_getattr(struct vop_getattr_args *ap)
break;
}
- vp->v_type = vap->va_type;
return (0);
}