Re: git: 5a6d9479ae22 - main - blocklistd: Fix RFC1918 typo

From: Jose Luis Duran <jlduran_at_freebsd.org>
Date: Sun, 03 May 2026 15:26:26 UTC
On Sun, May 3, 2026 at 10:10 AM Dag-Erling Smørgrav <des@freebsd.org> wrote:
>
> Jose Luis Duran <jlduran@FreeBSD.org> writes:
> > commit 5a6d9479ae2271a97dd23ceee8ad284770302874
> > Author:     Jose Luis Duran <jlduran@FreeBSD.org>
> > AuthorDate: 2026-05-03 05:31:51 +0000
> > Commit:     Jose Luis Duran <jlduran@FreeBSD.org>
> > CommitDate: 2026-05-03 05:31:51 +0000
> >
> >     blocklistd: Fix RFC1918 typo
> >
> >     The address in the configuration file example was intended to be from
> >     the 192.168.0.0/16 range of IPv4 private addresses (RFC1918).
>
> I'm sure it was but we should be using RFC 5737 addresses instead.  At
> least the IPv6 examples are correct...

Yesterday, when I was pushing this patch I realized that we should
indeed be using documentation-specific addresses for
blocklistd.conf(5), instead of using IPs from Level 3 and APNIC.
I'll submit a patch upstream based on your suggestion. Thanks!

> >     Reported on mastodon.social at
> >     https://mastodon.social/@asmodai/116316630762241486.
>
> that's asmodai@freebsd.org

Reported by: asmodai

> >
> >     Fix submitted upstream by emaste@.  Fixing locally first.
> >
> >     Reviewed by:    emaste
> >     MFC after:      1 week
> >     Differential Revision:  https://reviews.freebsd.org/D56773
>
> DES
> --
> Dag-Erling Smørgrav - des@FreeBSD.org


-- 
Jose Luis Duran