git: 648d0fefd757 - main - ipfw: skip tests if required sysctl is not set
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 25 Mar 2026 15:58:31 UTC
The branch main has been updated by olivier:
URL: https://cgit.FreeBSD.org/src/commit/?id=648d0fefd7573080b01d44cad8c39ad658f8e44f
commit 648d0fefd7573080b01d44cad8c39ad658f8e44f
Author: Olivier Cochard <olivier@FreeBSD.org>
AuthorDate: 2026-03-25 15:47:44 +0000
Commit: Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2026-03-25 15:55:57 +0000
ipfw: skip tests if required sysctl is not set
Since this is a configuration prerequisite rather than a test failure, use
atf_skip instead.
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D56069
---
tests/sys/netpfil/common/utils.subr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/sys/netpfil/common/utils.subr b/tests/sys/netpfil/common/utils.subr
index 8f298960bef5..8885495cec11 100644
--- a/tests/sys/netpfil/common/utils.subr
+++ b/tests/sys/netpfil/common/utils.subr
@@ -88,7 +88,7 @@ firewall_init()
if ! kldstat -q -m ipfw; then
atf_skip "This test requires ipfw"
elif [ $(sysctl -n net.inet.ip.fw.default_to_accept) -ne 1 ]; then
- atf_fail "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable"
+ atf_skip "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable"
fi
elif [ ${firewall} == "pf" ]; then
if [ ! -c /dev/pf ]; then